Re: Fatal warnings breaks ipfw on LP64

2002-10-02 Thread Mike Barcroft

It's been one month, have you made any progress on this?

Mike Barcroft [EMAIL PROTECTED] writes:
 
 cc1: warnings being treated as errors
 /usr/src/sys/netinet/ip_fw2.c: In function `ipfw_ctl':
 /usr/src/sys/netinet/ip_fw2.c:2508: warning: cast from pointer to integer of 
different size
 /usr/src/sys/netinet/ip_fw2.c:2521: warning: cast from pointer to integer of 
different size
 
 Some of the code in question looks questionable:
 /*
  * abuse 'next_rule' to store the set_disable word
  */
 (u_int32_t)(((struct ip_fw *)bp)-next_rule) =
 set_disable;
 
 The rvalue is being cast in an assignment to make a pointer store an
 integer?  Surely this can be written better.
 
 Best regards,
 Mike Barcroft

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Fatal warnings breaks ipfw on LP64

2002-09-02 Thread Mike Barcroft


cc1: warnings being treated as errors
/usr/src/sys/netinet/ip_fw2.c: In function `ipfw_ctl':
/usr/src/sys/netinet/ip_fw2.c:2508: warning: cast from pointer to integer of different 
size
/usr/src/sys/netinet/ip_fw2.c:2521: warning: cast from pointer to integer of different 
size

Some of the code in question looks questionable:
/*
 * abuse 'next_rule' to store the set_disable word
 */
(u_int32_t)(((struct ip_fw *)bp)-next_rule) =
set_disable;

The rvalue is being cast in an assignment to make a pointer store an
integer?  Surely this can be written better.

Best regards,
Mike Barcroft

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message