Re: Is UPS_PORT_POWER wrong?

2012-01-28 Thread Kohji Okuno
Hi HPS, Do you have better idea? From: Kohji Okuno okuno.ko...@jp.panasonic.com Date: Tue, 24 Jan 2012 09:53:29 +0900 (JST) Hi HPS, On Monday 23 January 2012 09:12:46 Kohji Okuno wrote: Hi HPS, I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap. And, in xhci.c you set

Re: Is UPS_PORT_POWER wrong?

2012-01-28 Thread Hans Petter Selasky
On Saturday 28 January 2012 12:53:39 Kohji Okuno wrote: Hi HPS, Do you have better idea? It might be we should implement a separate control request to get the information we need? Though that needs to be standardized. What do you think about that? --HPS

Is UPS_PORT_POWER wrong?

2012-01-23 Thread Kohji Okuno
Hi HPS, I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap. And, in xhci.c you set UPS_PORT_POWER as folows. When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will return incorrect value. if (v XHCI_PS_PP) { /*

Re: Is UPS_PORT_POWER wrong?

2012-01-23 Thread Hans Petter Selasky
On Monday 23 January 2012 09:12:46 Kohji Okuno wrote: Hi HPS, I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap. And, in xhci.c you set UPS_PORT_POWER as folows. When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will return incorrect value. if (v

Re: Is UPS_PORT_POWER wrong?

2012-01-23 Thread Kohji Okuno
Hi HPS, On Monday 23 January 2012 09:12:46 Kohji Okuno wrote: Hi HPS, I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap. And, in xhci.c you set UPS_PORT_POWER as folows. When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will return incorrect value.