Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-09 Thread mike tancsa
On 11/9/2020 7:32 AM, Lev Serebryakov wrote: > On 07.11.2020 2:46, Eric Joyner wrote: > >> The other issue is that I still don't know which devices need a >> restart / which devices do not, or whether a restart is strictly >> necessary and if there is another way to do this without worrying >>

Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-09 Thread Lev Serebryakov
On 07.11.2020 2:46, Eric Joyner wrote: The other issue is that I still don't know which devices need a restart / which devices do not, or whether a restart is strictly necessary and if there is another way to do this without worrying about restarting the device. Could this be copied from

Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-06 Thread Eric Joyner
Ah -- I didn't implement the fix I had in that bugzilla correctly -- em and igb devices will use the same function instead of using two different ones even though it seems em devices generally require the interface restart yet igb devices do not. The other issue is that I still don't know which

Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-06 Thread mike tancsa
On 11/6/2020 5:32 PM, Eric Joyner wrote: > Could you reply to that issue with what you've found? > > Though, as far as I can recall, igb(4) devices are not supposed to do > the iflib reset talked about in the bug, so I wouldn't expect to see a > link flap on those. > Hi Eric,     I have added my

Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-06 Thread Eric Joyner
Could you reply to that issue with what you've found? Though, as far as I can recall, igb(4) devices are not supposed to do the iflib reset talked about in the bug, so I wouldn't expect to see a link flap on those. - Eric On Fri, Nov 6, 2020 at 12:48 PM mike tancsa wrote: > On 11/6/2020 2:17

Re: Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-06 Thread mike tancsa
On 11/6/2020 2:17 PM, mike tancsa wrote: > On 5/31/2020 5:39 PM, Lev Serebryakov wrote: >> Hello Ian, >> >> Thursday, May 28, 2020, 2:45:48 AM, you wrote: >> >>> I noticed that my VLAN interfaces stopped working after a recent build.  >>> tcpdump showed traffic leaving leaving and entering the

Link flap when adding / removing a vlan (was Re: r360902 breaks VLAN interface on if_em (82579LM))

2020-11-06 Thread mike tancsa
On 5/31/2020 5:39 PM, Lev Serebryakov wrote: > Hello Ian, > > Thursday, May 28, 2020, 2:45:48 AM, you wrote: > >> I noticed that my VLAN interfaces stopped working after a recent build.  >> tcpdump showed traffic leaving leaving and entering the interface but no >> host on the network actually