Re: MEXTFREE

2001-12-22 Thread Bosko Milekic


On Sat, Dec 22, 2001 at 12:54:16AM -0700, Chad David wrote:
 MEXTFREE results in a call to _mext_free() which is only defined within
 subr_mbuf.c, and is not static.  Should the prototype be moved into
 sys/mbuf.h, or should MEXTFREE be moved into subr_mbuf.c, or is it ok
 like this?

  It should stay like this. The easy (macro) case deals with only the
reference count issue. We only call the function if we really have to
free the object (i.e. ref count is dropped to zero).

 Thanks.
 
 -- 
 Chad David[EMAIL PROTECTED]
 ACNS Inc. Calgary, Alberta Canada

-- 
 Bosko Milekic
 [EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: MEXTFREE

2001-12-22 Thread Bruce Evans

On Sat, 22 Dec 2001, Bosko Milekic wrote:

 On Sat, Dec 22, 2001 at 12:54:16AM -0700, Chad David wrote:
  MEXTFREE results in a call to _mext_free() which is only defined within
  subr_mbuf.c, and is not static.  Should the prototype be moved into
  sys/mbuf.h, or should MEXTFREE be moved into subr_mbuf.c, or is it ok
  like this?

   It should stay like this. The easy (macro) case deals with only the
 reference count issue. We only call the function if we really have to
 free the object (i.e. ref count is dropped to zero).

But clients that use MEXTFREE (if any) see the function call, so they
need a prototype in scope.

Bruce


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



MEXTFREE

2001-12-21 Thread Chad David

MEXTFREE results in a call to _mext_free() which is only defined within
subr_mbuf.c, and is not static.  Should the prototype be moved into
sys/mbuf.h, or should MEXTFREE be moved into subr_mbuf.c, or is it ok
like this?

Thanks.

-- 
Chad David[EMAIL PROTECTED]
ACNS Inc. Calgary, Alberta Canada

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message