Re: Race VT+X11 on -current

2015-05-21 Thread Hans Petter Selasky
On 05/11/15 21:52, Ed Maste wrote: On 10 May 2015 at 13:14, Hans Petter Selasky h...@selasky.org wrote: Your patch is correct from what I can see. Signed modulus can be creepy sometimes! Better if VT_MAXWINDOWS was power of two and we used a bitwise AND. The patch is correct, although

Re: Race VT+X11 on -current

2015-05-11 Thread Ed Maste
On 10 May 2015 at 13:14, Hans Petter Selasky h...@selasky.org wrote: Your patch is correct from what I can see. Signed modulus can be creepy sometimes! Better if VT_MAXWINDOWS was power of two and we used a bitwise AND. The patch is correct, although signedness doesn't come into play. The

Re: Race VT+X11 on -current

2015-05-10 Thread Hans Petter Selasky
On 05/09/15 23:05, Wolfgang Zenker wrote: * Allan Jude allanj...@freebsd.org [150508 16:29]: [..] My experience is a little different. When suspend/resuming my laptop (Lenovo T530 with nVidia gpu) Sometimes when I resume, it seems like the keyboard is frozen. If I alt+f1, then alt+f9, it

Re: Race VT+X11 on -current

2015-05-10 Thread Wolfgang Zenker
Hi, * Hans Petter Selasky h...@selasky.org [150510 14:47]: On 05/09/15 23:05, Wolfgang Zenker wrote: * Allan Jude allanj...@freebsd.org [150508 16:29]: [..] My experience is a little different. When suspend/resuming my laptop (Lenovo T530 with nVidia gpu) Sometimes when I resume, it seems

Re: Race VT+X11 on -current

2015-05-10 Thread Hans Petter Selasky
On 05/10/15 18:53, Wolfgang Zenker wrote: Hi, * Hans Petter Selasky h...@selasky.org [150510 14:47]: On 05/09/15 23:05, Wolfgang Zenker wrote: * Allan Jude allanj...@freebsd.org [150508 16:29]: [..] My experience is a little different. When suspend/resuming my laptop (Lenovo T530 with

Re: Race VT+X11 on -current

2015-05-10 Thread Oliver Pinter
Hi Hans! On 5/10/15, Hans Petter Selasky h...@selasky.org wrote: On 05/10/15 18:53, Wolfgang Zenker wrote: Hi, * Hans Petter Selasky h...@selasky.org [150510 14:47]: On 05/09/15 23:05, Wolfgang Zenker wrote: * Allan Jude allanj...@freebsd.org [150508 16:29]: [..] My experience is a little

Re: Race VT+X11 on -current

2015-05-10 Thread Hans Petter Selasky
On 05/10/15 19:00, Oliver Pinter wrote: Hi Hans! Hi, Sounds good. I'll MFC the patch sometime next week. Seems like more people need it for daily FreeBSD use :-) I have this fix or enhancements in our HardenedBSD codebase:

Re: Race VT+X11 on -current

2015-05-09 Thread Wolfgang Zenker
* Allan Jude allanj...@freebsd.org [150508 16:29]: [..] My experience is a little different. When suspend/resuming my laptop (Lenovo T530 with nVidia gpu) Sometimes when I resume, it seems like the keyboard is frozen. If I alt+f1, then alt+f9, it seems to work fine after that. I'd never

Re: Race VT+X11 on -current

2015-05-08 Thread Garrett Cooper
On May 7, 2015, at 21:34, Hans Petter Selasky h...@selasky.org wrote: Hi, I have a fix, attached. I'll just throw this in if nobody objects. Seems like a trivial issue: Prevent switching to NULL or own window in the vt_proc_window_switch function. This fixes an issue where X11

Re: Race VT+X11 on -current

2015-05-08 Thread Hans Petter Selasky
On 05/08/15 11:56, Garrett Cooper wrote: On May 7, 2015, at 21:34, Hans Petter Selasky h...@selasky.org wrote: Hi, I have a fix, attached. I'll just throw this in if nobody objects. Seems like a trivial issue: Prevent switching to NULL or own window in the vt_proc_window_switch function.

Re: Race VT+X11 on -current

2015-05-08 Thread Allan Jude
On 2015-05-08 06:07, Hans Petter Selasky wrote: On 05/08/15 11:56, Garrett Cooper wrote: On May 7, 2015, at 21:34, Hans Petter Selasky h...@selasky.org wrote: Hi, I have a fix, attached. I'll just throw this in if nobody objects. Seems like a trivial issue: Prevent switching to NULL or

Re: Race VT+X11 on -current

2015-05-07 Thread Hans Petter Selasky
On 05/07/15 20:23, Garrett Cooper wrote: On May 7, 2015, at 09:43, Kevin Oberman rkober...@gmail.com wrote: On Thu, May 7, 2015 at 5:39 AM, Hans Petter Selasky h...@selasky.org wrote: Hi, Sometimes when logging into X11 the keyboard input is not working. Pressing ALT+F9 makes it work. Any

Re: Race VT+X11 on -current

2015-05-07 Thread Garrett Cooper
On May 7, 2015, at 09:43, Kevin Oberman rkober...@gmail.com wrote: On Thu, May 7, 2015 at 5:39 AM, Hans Petter Selasky h...@selasky.org wrote: Hi, Sometimes when logging into X11 the keyboard input is not working. Pressing ALT+F9 makes it work. Any idea where the race is? --HPS

Re: Race VT+X11 on -current

2015-05-07 Thread Hans Petter Selasky
Hi, I have a fix, attached. I'll just throw this in if nobody objects. Seems like a trivial issue: Prevent switching to NULL or own window in the vt_proc_window_switch function. This fixes an issue where X11 keyboard input can appear stuck. The cause of the problem is a duplicate TTY device

Re: Race VT+X11 on -current

2015-05-07 Thread Hans Petter Selasky
On 05/07/15 22:00, Hans Petter Selasky wrote: On 05/07/15 20:23, Garrett Cooper wrote: On May 7, 2015, at 09:43, Kevin Oberman rkober...@gmail.com wrote: On Thu, May 7, 2015 at 5:39 AM, Hans Petter Selasky h...@selasky.org wrote: Hi, Sometimes when logging into X11 the keyboard input is

Re: Race VT+X11 on -current

2015-05-07 Thread Kevin Oberman
On Thu, May 7, 2015 at 5:39 AM, Hans Petter Selasky h...@selasky.org wrote: Hi, Sometimes when logging into X11 the keyboard input is not working. Pressing ALT+F9 makes it work. Any idea where the race is? --HPS Actually, I have found that switching to ANY other terminal (e.g. ALT-F2) and

Race VT+X11 on -current

2015-05-07 Thread Hans Petter Selasky
Hi, Sometimes when logging into X11 the keyboard input is not working. Pressing ALT+F9 makes it work. Any idea where the race is? --HPS ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To