Re: Who is responsible for the install check goo in Makefile.inc1
[ Moved to -current ]
On Tue, Jul 29, 2003 at 07:12:09PM -0700, Peter Wemm wrote:
John Birrell wrote:
[...]
The installworld check for a kernel with the new sigaction promptly
core-dumped sh with the unsupported syscall. I think this check should
be based on sysctl kern.osreldate, not just running the new shell to see
if it core dumps. Thats kind of sub-optimal because I normally associate
core dumps during build/installworld with a dodgy build. In this case,
the build wasn't dodgy... I just hadn't realised that I was missing a toe.
The problem is that some of the install scripts run the host /bin/sh *after*
src/bin has been installed. If your sh in ${OBJDIR} wont run, you *WILL*
be hosed later on in the build with about a 50:50 split between old and new
worlds. I dont recall which scripts are the culprits, but it is a side
effect of #! /bin/sh that is on a script that is run during installworld.
In theory, the 'make installworld' stuff copies everything needed for an
installworld to a /tmp directory, but it still misses a bunch of
#! /bin/sh type things. This isn't a cross build issue because the shell
scripts are run on the host.
For what its worth, this test saved me yesterday when I was trying to update
an ancient ia64 box to -current.
That wasn't the point John was trying to make, IMO.
I'm regularly upgrading 4.0-RELEASE to 5.x-CURRENT to check that
the upgrade path wasn't broken, and this check comes very handy.
I wouldn't object though if it was done using kern.osreldate.
I'd happily test any patches in this direction for you, John.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
[EMAIL PROTECTED] Sunbay Software Ltd,
[EMAIL PROTECTED] FreeBSD committer
pgp0.pgp
Description: PGP signature
Re: Who is responsible for the install check goo in Makefile.inc1
On Wed, Jul 30, 2003 at 10:24:42AM +0300, Ruslan Ermilov wrote: I'm regularly upgrading 4.0-RELEASE to 5.x-CURRENT to check that the upgrade path wasn't broken, and this check comes very handy. I wouldn't object though if it was done using kern.osreldate. I'd happily test any patches in this direction for you, John. Thanks. Since Peter made the change, I'd like to wait for him to comment on the code I sent him that would avoid the core dump. I think that running sh as a final check is valid, but I'd like to see a 'probable' case checked first and an message printed accordingly before making the core dump as a last resort (in favour of shooting the whole foot off - one toe is better than the whole foot!). -- John Birrell ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: Who is responsible for the install check goo in Makefile.inc1
On Wed, Jul 30, 2003 at 05:34:01PM +1000, John Birrell wrote: On Wed, Jul 30, 2003 at 10:24:42AM +0300, Ruslan Ermilov wrote: I'm regularly upgrading 4.0-RELEASE to 5.x-CURRENT to check that the upgrade path wasn't broken, and this check comes very handy. I wouldn't object though if it was done using kern.osreldate. I'd happily test any patches in this direction for you, John. Thanks. Since Peter made the change, I'd like to wait for him to comment on the code I sent him that would avoid the core dump. I think that running sh as a final check is valid, but I'd like to see a 'probable' case checked first and an message printed accordingly before making the core dump as a last resort (in favour of shooting the whole foot off - one toe is better than the whole foot!). Sure, that would be a much better (and safer) approach. Could you please send me your code as well, I'm interested in revieweing it. P.S. Nice to see you're still in the FreeBSD business. :-) Cheers, -- Ruslan Ermilov Sysadmin and DBA, [EMAIL PROTECTED] Sunbay Software Ltd, [EMAIL PROTECTED] FreeBSD committer pgp0.pgp Description: PGP signature
Re: Who is responsible for the install check goo in Makefile.inc1
On Wed, Jul 30, 2003 at 10:37:29AM +0300, Ruslan Ermilov wrote: Sure, that would be a much better (and safer) approach. Could you please send me your code as well, I'm interested in revieweing it. I'd just like to add something like this before Peter's check that runs sh: @OSRELDATE=`sysctl -n kern.osreldate`; \ if [ $$OSRELDATE -lt 500043 ]; then \ echo The kernel you are running does not support the executables you are about to install!; \ echo You need to install a new kernel and reboot before doing an installworld.; \ echo If you have already installed a new kernel, perhaps your loader configuration; \ echo needs to be updated to reflect the fact that kernels are now installed below; \ echo the /boot directory (not in the root directory.; \ exit 1; \ fi P.S. Nice to see you're still in the FreeBSD business. :-) Actually I'm /only/ in the FreeBSD business. I've been concentrating on getting a FreeBSD based product ready for release. I'm at the second prototype stage and things are looking promising. The SCO vs IBM case is a reminder of why I chose *BSD in the first place. I'm a bit embarrassed that I haven't contributed more in the last year or so. At some point I'll need to upgrade the product to 5.X, so I need to start working in that direction. While I'm getting a current machine up and running I'd like to sort out the uprade issues while I'm still prepared to trash the install. Peter's grim reaper email is a regular reminder. I think I'm up to number 11. Hehehehe. -- John Birrell ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
