Re: buildworld trouble: multiple struct dos_partition.
Bruce Evans wrote:
> "pc98_partition" is OK, but "mbr_partition" is bogus since partition tables
> are not restricted to the MBR -- there is one in every extended partition.
>
> is similarly OK and is similarly bogus.
>
> "at386" would be a better prefix/suffix than "mbr" for the non-pc98 pc's.
> It is used for the main bus space header.
>
> The normal prefix for "partition table" seems to be "" according to google.
> FreeBSD has "dos_partition" and NetBSD has "mbr_partition".
The PReP specification ("PPC Reference Platform") goes into great
gory detail on DOS Partition Tables, as does the DEC Alpha boot
documentation. The fact is that DOS Partition tables are used in
a lot of places that are unrelated to x86.
PS: The PReP documentation is probably the finest documentation
for the DOS partition table format available anywhere.
-- Terry
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Re: buildworld trouble: multiple struct dos_partition.
On Fri, 3 Jan 2003 [EMAIL PROTECTED] wrote: > In message <[EMAIL PROTECTED]>, Takahashi Yoshihiro > writes: > >In article <[EMAIL PROTECTED]> > >Poul-Henning Kamp <[EMAIL PROTECTED]> writes: > > > >> I think you need to either #ifdef something here (and there may be > >> more some similar code in places like truss or the debugger) or > >> alternatively rename the structure to "pc98_partition" or similar. > > > >I think that the name "dos_partition" is not suitable for both i386 > >and pc98. I wonder what does "dos" mean here. For example, it should > >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, > >respectively. > > You are correct in principle. "pc98_partition" is OK, but "mbr_partition" is bogus since partition tables are not restricted to the MBR -- there is one in every extended partition. is similarly OK and is similarly bogus. "at386" would be a better prefix/suffix than "mbr" for the non-pc98 pc's. It is used for the main bus space header. The normal prefix for "partition table" seems to be "" according to google. FreeBSD has "dos_partition" and NetBSD has "mbr_partition". Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: buildworld trouble: multiple struct dos_partition.
In message <[EMAIL PROTECTED]>, Takahashi Yoshihiro writes: >In article <[EMAIL PROTECTED]> >Poul-Henning Kamp <[EMAIL PROTECTED]> writes: > >> I think you need to either #ifdef something here (and there may be >> more some similar code in places like truss or the debugger) or >> alternatively rename the structure to "pc98_partition" or similar. > >I think that the name "dos_partition" is not suitable for both i386 >and pc98. I wonder what does "dos" mean here. For example, it should >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, >respectively. You are correct in principle. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: buildworld trouble: multiple struct dos_partition.
In article <[EMAIL PROTECTED]> Poul-Henning Kamp <[EMAIL PROTECTED]> writes: > I think you need to either #ifdef something here (and there may be > more some similar code in places like truss or the debugger) or > alternatively rename the structure to "pc98_partition" or similar. I think that the name "dos_partition" is not suitable for both i386 and pc98. I wonder what does "dos" mean here. For example, it should be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98, respectively. --- TAKAHASHI Yoshihiro <[EMAIL PROTECTED]> To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
buildworld trouble: multiple struct dos_partition.
I think you need to either #ifdef something here (and there may be more some similar code in places like truss or the debugger) or alternatively rename the structure to "pc98_partition" or similar. I would advocate the latter. Poul-Henning ===> usr.bin/kdump cc -O -pipe -mcpu=pentiumpro -I/bang/src/usr.bin/kdump/../ktrace -I/bang/src/usr .bin/kdump/../..-c /bang/src/usr.bin/kdump/kdump.c cc -O -pipe -mcpu=pentiumpro -I/bang/src/usr.bin/kdump/../ktrace -I/bang/src/usr .bin/kdump/../..-c /bang/src/usr.bin/ktrace/subr.c gzip -cn /bang/src/usr.bin/kdump/kdump.1 > kdump.1.gz cc -O -pipe -mcpu=pentiumpro -I/bang/src/usr.bin/kdump/../ktrace -I/bang/src/usr .bin/kdump/../..-c ioctl.c In file included from ioctl.c:93: /usr/obj/bang/src/i386/usr/include/sys/diskpc98.h:47: redefinition of `struct do s_partition' -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
