Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Jakob Alvermark

On 4/26/23 16:00, Dmitry Chagin wrote:

On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote:

Hi,


I use net/citrix_ica for work.

https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a

Yes, this works. Thanks for the quick response!

After a recent change to -current in compat/linux it no longer works.
The binary just segfaults.

I have bisected and it happened after this commit:

commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
Author: Dmitry Chagin 
Date:   Sat Apr 22 22:17:17 2023 +0300

      linux(4): Export the AT_RANDOM depending on the process osreldata

      AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.

      Reviewed by:    emaste
      Differential Revision:  https://reviews.freebsd.org/D39646
      MFC after:  1 month

   sys/compat/linux/linux_elf.c | 3 ++-
   sys/compat/linux/linux_mib.h | 1 +
   2 files changed, 3 insertions(+), 1 deletion(-)


If I revert the change, citrix_ica works again.


Thanks,

Jakob Alvermark





Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Dmitry Chagin
On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote:
> Hi,
> 
> 
> I use net/citrix_ica for work.

https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a

> 
> After a recent change to -current in compat/linux it no longer works. 
> The binary just segfaults.
> 
> I have bisected and it happened after this commit:
> 
> commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
> Author: Dmitry Chagin 
> Date:   Sat Apr 22 22:17:17 2023 +0300
> 
>      linux(4): Export the AT_RANDOM depending on the process osreldata
> 
>      AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.
> 
>      Reviewed by:    emaste
>      Differential Revision:  https://reviews.freebsd.org/D39646
>      MFC after:  1 month
> 
>   sys/compat/linux/linux_elf.c | 3 ++-
>   sys/compat/linux/linux_mib.h | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> 
> If I revert the change, citrix_ica works again.
> 
> 
> Thanks,
> 
> Jakob Alvermark
> 



Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Dmitry Chagin
On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote:
> Hi,
> 
> 
> I use net/citrix_ica for work.
> 
> After a recent change to -current in compat/linux it no longer works. 
> The binary just segfaults.
> 
> I have bisected and it happened after this commit:
> 
> commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
> Author: Dmitry Chagin 
> Date:   Sat Apr 22 22:17:17 2023 +0300
> 
>      linux(4): Export the AT_RANDOM depending on the process osreldata
> 
>      AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.
> 
>      Reviewed by:    emaste
>      Differential Revision:  https://reviews.freebsd.org/D39646
>      MFC after:  1 month
> 
>   sys/compat/linux/linux_elf.c | 3 ++-
>   sys/compat/linux/linux_mib.h | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> 
> If I revert the change, citrix_ica works again.
> 

Hi, thanks, I'll commit fix today after some testing

> 
> Thanks,
> 
> Jakob Alvermark
> 



Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Alexander Leidinger
Quoting Jakob Alvermark  (from Wed, 26 Apr 2023  
09:01:00 +0200):



Hi,


I use net/citrix_ica for work.

After a recent change to -current in compat/linux it no longer  
works. The binary just segfaults.


What does "sysctl compat.linux.osrelease" display? If it is not 2.6.30  
or higher, try to set it to 2.6.30 or higher.


Bye,
Alexander.


I have bisected and it happened after this commit:

commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
Author: Dmitry Chagin 
Date:   Sat Apr 22 22:17:17 2023 +0300

    linux(4): Export the AT_RANDOM depending on the process osreldata

    AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.



--
http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.orgnetch...@freebsd.org  : PGP 0x8F31830F9F2772BF


pgpvwszGFGPAo.pgp
Description: Digitale PGP-Signatur


change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Jakob Alvermark

Hi,


I use net/citrix_ica for work.

After a recent change to -current in compat/linux it no longer works. 
The binary just segfaults.


I have bisected and it happened after this commit:

commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
Author: Dmitry Chagin 
Date:   Sat Apr 22 22:17:17 2023 +0300

    linux(4): Export the AT_RANDOM depending on the process osreldata

    AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.

    Reviewed by:    emaste
    Differential Revision:  https://reviews.freebsd.org/D39646
    MFC after:  1 month

 sys/compat/linux/linux_elf.c | 3 ++-
 sys/compat/linux/linux_mib.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)


If I revert the change, citrix_ica works again.


Thanks,

Jakob Alvermark