Re: fuser does not list id of processes that have a file

2018-10-20 Thread Ali Abdallah
>> I tested on zfs, perhaps there is something extra going on on other
filesystems.

I tested on UFS2, and I get nothing out of the patched fuser.c.

On Thu, Oct 18, 2018 at 11:24 PM Mateusz Guzik  wrote:

> On 10/17/18, Ali Abdallah  wrote:
> >> diff --git a/usr.bin/fstat/fuser.c b/usr.bin/fstat/fuser.c
> >> index b4225328fc1f..17d06f1c5b13 100644
> >> --- a/usr.bin/fstat/fuser.c
> >>  +++ b/usr.bin/fstat/fuser.c
> >>  @@ -92,7 +92,7 @@ struct consumer {
> >>STAILQ_ENTRY(consumer)  next;
> >> };
> >> struct reqfile {
> >> -   uint32_tfsid;
> >>  +   uint64_tfsid;
> >>uint64_tfileid;
> >>const char  *name;
> >>STAILQ_HEAD(, consumer) consumers;
> >
> > The above patch does not resolve the problem for me.
> >
>
> Are you sure you recompiled and reinstalled the tool with the patch
> applied?
> You can recompile and install like this:
> # make -j 3 clean all install
>
> If this indeed still does not work, can you show output of:
> uname -m
> mount
>
> I tested on zfs, perhaps there is something extra going on on other
> filesystems.
>
> --
> Mateusz Guzik 
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: fuser does not list id of processes that have a file

2018-10-18 Thread Mateusz Guzik
On 10/17/18, Ali Abdallah  wrote:
>> diff --git a/usr.bin/fstat/fuser.c b/usr.bin/fstat/fuser.c
>> index b4225328fc1f..17d06f1c5b13 100644
>> --- a/usr.bin/fstat/fuser.c
>>  +++ b/usr.bin/fstat/fuser.c
>>  @@ -92,7 +92,7 @@ struct consumer {
>>STAILQ_ENTRY(consumer)  next;
>> };
>> struct reqfile {
>> -   uint32_tfsid;
>>  +   uint64_tfsid;
>>uint64_tfileid;
>>const char  *name;
>>STAILQ_HEAD(, consumer) consumers;
>
> The above patch does not resolve the problem for me.
>

Are you sure you recompiled and reinstalled the tool with the patch applied?
You can recompile and install like this:
# make -j 3 clean all install

If this indeed still does not work, can you show output of:
uname -m
mount

I tested on zfs, perhaps there is something extra going on on other filesystems.

-- 
Mateusz Guzik 
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: fuser does not list id of processes that have a file

2018-10-17 Thread Ali Abdallah
> diff --git a/usr.bin/fstat/fuser.c b/usr.bin/fstat/fuser.c
> index b4225328fc1f..17d06f1c5b13 100644
> --- a/usr.bin/fstat/fuser.c
>  +++ b/usr.bin/fstat/fuser.c
>  @@ -92,7 +92,7 @@ struct consumer {
>STAILQ_ENTRY(consumer)  next;
> };
> struct reqfile {
> -   uint32_tfsid;
>  +   uint64_tfsid;
>uint64_tfileid;
>const char  *name;
>STAILQ_HEAD(, consumer) consumers;

The above patch does not resolve the problem for me.

Regards.


On Tue, Oct 16, 2018 at 5:17 PM Ed Schouten  wrote:

> Hi there,
>
> Op di 16 okt. 2018 om 15:05 schreef Mateusz Guzik :
> >  struct reqfile {
> > -   uint32_tfsid;
> > +   uint64_tfsid;
> > uint64_tfileid;
>
> Considering that these are based on sb.st_{ino,dev}, maybe better to
> use the occasion to switch these fields to dev_t and ino_t?
>
> --
> Ed Schouten 
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: fuser does not list id of processes that have a file

2018-10-16 Thread Ed Schouten
Hi there,

Op di 16 okt. 2018 om 15:05 schreef Mateusz Guzik :
>  struct reqfile {
> -   uint32_tfsid;
> +   uint64_tfsid;
> uint64_tfileid;

Considering that these are based on sb.st_{ino,dev}, maybe better to
use the occasion to switch these fields to dev_t and ino_t?

-- 
Ed Schouten 
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: fuser does not list id of processes that have a file

2018-10-16 Thread Mateusz Guzik
On 10/16/18, Ali Abdallah  wrote:
> Hello,
>
> On FreeBSD 12 ALPHA9
>
>> less .vimrc
>> fuser .vimrc
> .vimrc:
>
> gives no pid, on FreeBSD 11.2 the above works as expected.
>

try this:
diff --git a/usr.bin/fstat/fuser.c b/usr.bin/fstat/fuser.c
index b4225328fc1f..17d06f1c5b13 100644
--- a/usr.bin/fstat/fuser.c
+++ b/usr.bin/fstat/fuser.c
@@ -92,7 +92,7 @@ struct consumer {
STAILQ_ENTRY(consumer)  next;
 };
 struct reqfile {
-   uint32_tfsid;
+   uint64_tfsid;
uint64_tfileid;
const char  *name;
STAILQ_HEAD(, consumer) consumers;


-- 
Mateusz Guzik 
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


fuser does not list id of processes that have a file

2018-10-16 Thread Ali Abdallah
Hello,

On FreeBSD 12 ALPHA9

> less .vimrc
> fuser .vimrc
.vimrc:

gives no pid, on FreeBSD 11.2 the above works as expected.

Regards,
Ali
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"