Re: mbuf LOR

2003-04-04 Thread Nate Lawson
On Thu, 3 Apr 2003, Andrew Gallatin wrote: Nate Lawson writes: I was testing some changes to make fxp MPSAFE and got a LOR in allocating the mbuf cluster and then finally a panic when trying to dereference the cluster header. Is the mbuf system MPSAFE? Is it ok to call m_getcl with

Giant required by uma (was Re: mbuf LOR)

2003-04-04 Thread Andrew Gallatin
Nate Lawson writes: You're right about where the problem is (top of stack trace and listing below). However, your patch causes an immediate panic on boot due to a NULL deref. I don't think you want it to always return NULL if called with M_NOWAIT set. :) Other ideas? I

Re: mbuf LOR

2003-04-04 Thread Andrew Gallatin
Nate Lawson writes: You're right about where the problem is (top of stack trace and listing below). However, your patch causes an immediate panic on boot due to a NULL deref. I don't think you want it to always return NULL if called with M_NOWAIT set. :) Other ideas? The following

Re: mbuf LOR

2003-04-03 Thread Harti Brandt
On Wed, 2 Apr 2003, Bosko Milekic wrote: BM For what concerns DONTWAIT, you should theoretically be allowed to BM hold a driver lock. But again, there may be a problem. Specifically, BM I see that UMA code has some explicit Giant acquires/frees in certain BM places. When the UMA code gets

Re: mbuf LOR

2003-04-03 Thread Andrew Gallatin
Nate Lawson writes: I was testing some changes to make fxp MPSAFE and got a LOR in allocating the mbuf cluster and then finally a panic when trying to dereference the cluster header. Is the mbuf system MPSAFE? Is it ok to call m_getcl with a device lock held (but not Giant)? The

mbuf LOR

2003-04-02 Thread Nate Lawson
I was testing some changes to make fxp MPSAFE and got a LOR in allocating the mbuf cluster and then finally a panic when trying to dereference the cluster header. Is the mbuf system MPSAFE? Is it ok to call m_getcl with a device lock held (but not Giant)? The lock reversal was: 1. fxp softc

Re: mbuf LOR

2003-04-02 Thread Andrew Gallatin
Nate Lawson writes: I was testing some changes to make fxp MPSAFE and got a LOR in allocating the mbuf cluster and then finally a panic when trying to dereference the cluster header. Is the mbuf system MPSAFE? Is it ok to call m_getcl with a device lock held (but not Giant)? The

Re: mbuf LOR

2003-04-02 Thread Bosko Milekic
On Wed, Apr 02, 2003 at 12:39:30PM -0800, Nate Lawson wrote: I was testing some changes to make fxp MPSAFE and got a LOR in allocating the mbuf cluster and then finally a panic when trying to dereference the cluster header. Is the mbuf system MPSAFE? Is it ok to call m_getcl with a device