Re: old top and new -current: missing arcstat sysctl
On Tue, Aug 28, 2018 at 08:40:15AM +0200, Alexander Leidinger wrote: > Hi, > > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > 12.0-alpha3 with a top from an old-ish -current. > > Is/will this be handled via a compat-11 sysctl (my kernel is without > compat-xx), or did this slip through? This should be fixed by r338395. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
On 2018-08-29 11:18, Mark Johnston wrote: > On Wed, Aug 29, 2018 at 07:44:31AM +0200, Alexander Leidinger wrote: >> >> Quoting Mark Johnston (from Tue, 28 Aug 2018 >> 10:48:42 -0400): >> >>> On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: On 2018-08-28 02:40, Alexander Leidinger wrote: > Hi, > > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > 12.0-alpha3 with a top from an old-ish -current. > > Is/will this be handled via a compat-11 sysctl (my kernel is without > compat-xx), or did this slip through? >> That is not something that a compat-xx package can handle. >>> >>> s/package/kernel option/? >> >> Sorry, the COMPAT_FREEBSDx kernel options was what I had in mind when >> I wrote this. >> That arcstat was broken up into 3 individual stats, which the 12.0-alpha3 version of top will sum together for you. I don't think we've had compat shims like this for previous versions of top, I recall having similar issues when the 'laundry' counter was introduced. >>> >>> IIRC that would have been the inverted case of running a newer top(1) >>> with an older kernel lacking the v_laundry_pages sysctl. In general I'd >>> expect us to support running an older top(1) with newer kernels if we >>> don't have to bend over backwards to provide compatibility. >> >> If the new top is summing the 3 up anyway, it sounds like we could >> provide the old one as backwards compatibility, even if it is >> redundant. I rather have an redundant counter and an old top working >> (in the generic case of what we promise to our users; in this specific >> case for me I just need to get around to update the jails on the >> corresponding systems), than bailing out without displaying anything. > > I'm inclined to agree, especially since this (running older top(1)s) has > come up before when I removed some VM sysctls: > https://reviews.freebsd.org/D16943 > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > I misunderstood previously (COMPAT_FREEBSDxx vs the compat-xx package). I am in agreement with Mark about fixing this for 12.0 -- Allan Jude signature.asc Description: OpenPGP digital signature
Re: old top and new -current: missing arcstat sysctl
On Wed, Aug 29, 2018 at 07:44:31AM +0200, Alexander Leidinger wrote: > > Quoting Mark Johnston (from Tue, 28 Aug 2018 > 10:48:42 -0400): > > > On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: > >> On 2018-08-28 02:40, Alexander Leidinger wrote: > >> > Hi, > >> > > >> > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > >> > 12.0-alpha3 with a top from an old-ish -current. > >> > > >> > Is/will this be handled via a compat-11 sysctl (my kernel is without > >> > compat-xx), or did this slip through? > > >> That is not something that a compat-xx package can handle. > > > > s/package/kernel option/? > > Sorry, the COMPAT_FREEBSDx kernel options was what I had in mind when > I wrote this. > > >> That arcstat was broken up into 3 individual stats, which the > >> 12.0-alpha3 version of top will sum together for you. > >> > >> I don't think we've had compat shims like this for previous versions of > >> top, I recall having similar issues when the 'laundry' counter was > >> introduced. > > > > IIRC that would have been the inverted case of running a newer top(1) > > with an older kernel lacking the v_laundry_pages sysctl. In general I'd > > expect us to support running an older top(1) with newer kernels if we > > don't have to bend over backwards to provide compatibility. > > If the new top is summing the 3 up anyway, it sounds like we could > provide the old one as backwards compatibility, even if it is > redundant. I rather have an redundant counter and an old top working > (in the generic case of what we promise to our users; in this specific > case for me I just need to get around to update the jails on the > corresponding systems), than bailing out without displaying anything. I'm inclined to agree, especially since this (running older top(1)s) has come up before when I removed some VM sysctls: https://reviews.freebsd.org/D16943 ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
Quoting Eitan Adler (from Tue, 28 Aug 2018 22:54:04 -0700): On Tue, 28 Aug 2018 at 22:46, Alexander Leidinger wrote: > > IIRC that would have been the inverted case of running a newer top(1) > with an older kernel lacking the v_laundry_pages sysctl. In general I'd > expect us to support running an older top(1) with newer kernels if we > don't have to bend over backwards to provide compatibility. If the new top is summing the 3 up anyway, it sounds like we could provide the old one as backwards compatibility, even if it is redundant. I rather have an redundant counter and an old top working (in the generic case of what we promise to our users; in this specific case for me I just need to get around to update the jails on the corresponding systems), than bailing out without displaying anything. I'd support this but don't feel like it justifies breaking the freeze. After the 12.x freeze is over I'll implement this. I would rather say this justifies breaking the freeze. Think about an user updating to 12.0... and having a 11.x jail inside (maybe as a first step before updating the jail itself, or not at all because of a bug in a 12.0 library he haven't found but is hitting the user). We want him to be able to have top working, don't we? Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
On Tue, 28 Aug 2018 at 22:46, Alexander Leidinger wrote: > > > > IIRC that would have been the inverted case of running a newer top(1) > > with an older kernel lacking the v_laundry_pages sysctl. In general I'd > > expect us to support running an older top(1) with newer kernels if we > > don't have to bend over backwards to provide compatibility. > > If the new top is summing the 3 up anyway, it sounds like we could > provide the old one as backwards compatibility, even if it is > redundant. I rather have an redundant counter and an old top working > (in the generic case of what we promise to our users; in this specific > case for me I just need to get around to update the jails on the > corresponding systems), than bailing out without displaying anything. I'd support this but don't feel like it justifies breaking the freeze. After the 12.x freeze is over I'll implement this. -- Eitan Adler ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
Quoting Mark Johnston (from Tue, 28 Aug 2018 10:48:42 -0400): On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: On 2018-08-28 02:40, Alexander Leidinger wrote: > Hi, > > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > 12.0-alpha3 with a top from an old-ish -current. > > Is/will this be handled via a compat-11 sysctl (my kernel is without > compat-xx), or did this slip through? That is not something that a compat-xx package can handle. s/package/kernel option/? Sorry, the COMPAT_FREEBSDx kernel options was what I had in mind when I wrote this. That arcstat was broken up into 3 individual stats, which the 12.0-alpha3 version of top will sum together for you. I don't think we've had compat shims like this for previous versions of top, I recall having similar issues when the 'laundry' counter was introduced. IIRC that would have been the inverted case of running a newer top(1) with an older kernel lacking the v_laundry_pages sysctl. In general I'd expect us to support running an older top(1) with newer kernels if we don't have to bend over backwards to provide compatibility. If the new top is summing the 3 up anyway, it sounds like we could provide the old one as backwards compatibility, even if it is redundant. I rather have an redundant counter and an old top working (in the generic case of what we promise to our users; in this specific case for me I just need to get around to update the jails on the corresponding systems), than bailing out without displaying anything. Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
On Tue, Aug 28, 2018 at 10:25:39AM -0400, Allan Jude wrote: > On 2018-08-28 02:40, Alexander Leidinger wrote: > > Hi, > > > > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > > 12.0-alpha3 with a top from an old-ish -current. > > > > Is/will this be handled via a compat-11 sysctl (my kernel is without > > compat-xx), or did this slip through? > > > > Bye, > > Alexander. > > > > That is not something that a compat-xx package can handle. s/package/kernel option/? > That arcstat was broken up into 3 individual stats, which the > 12.0-alpha3 version of top will sum together for you. > > I don't think we've had compat shims like this for previous versions of > top, I recall having similar issues when the 'laundry' counter was > introduced. IIRC that would have been the inverted case of running a newer top(1) with an older kernel lacking the v_laundry_pages sysctl. In general I'd expect us to support running an older top(1) with newer kernels if we don't have to bend over backwards to provide compatibility. ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: old top and new -current: missing arcstat sysctl
On 2018-08-28 02:40, Alexander Leidinger wrote: > Hi, > > top reports missing sysctl kstat.zfs.misc.arcstats.other_size for > 12.0-alpha3 with a top from an old-ish -current. > > Is/will this be handled via a compat-11 sysctl (my kernel is without > compat-xx), or did this slip through? > > Bye, > Alexander. > That is not something that a compat-xx package can handle. That arcstat was broken up into 3 individual stats, which the 12.0-alpha3 version of top will sum together for you. I don't think we've had compat shims like this for previous versions of top, I recall having similar issues when the 'laundry' counter was introduced. -- Allan Jude signature.asc Description: OpenPGP digital signature
old top and new -current: missing arcstat sysctl
Hi, top reports missing sysctl kstat.zfs.misc.arcstats.other_size for 12.0-alpha3 with a top from an old-ish -current. Is/will this be handled via a compat-11 sysctl (my kernel is without compat-xx), or did this slip through? Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
