--
Message: 4
Date: Wed, 7 Mar 2012 10:45:11 -0800
From: Adrian Chadd adr...@freebsd.org
Subject: Re: patches for if_iwi and wlan for WEP mode
To: Mitsuru IWASAKI iwas...@jp.freebsd.org
Cc: freebsd-current@freebsd.org, freebsd-wirel...@freebsd.org,
Hi,
I'd rather you didn't commit iwi_update_mcast() unless you absolutely
know that the NIC doesn't need to be notified of multicast group
membership changes. If so, please commit that as a separate fix.
OK, I'd do so. I don't need mcast stuff for the time being,
instead I'd check other area
On 8 March 2012 09:32, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote:
Hi,
I'd rather you didn't commit iwi_update_mcast() unless you absolutely
know that the NIC doesn't need to be notified of multicast group
membership changes. If so, please commit that as a separate fix.
OK, I'd do so. I
On Wednesday, March 07, 2012 2:43:52 pm Adrian Chadd wrote:
On 7 March 2012 11:17, Bernhard Schmidt bschm...@freebsd.org wrote:
On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote:
.. except that the default if_transmit handling breaks fragments. Sigh.
So we're going to have to implement
On 8 March 2012 07:43, John Baldwin j...@freebsd.org wrote:
However, you could do that by having a net80211_ifattach() type thing that
sets if_transmit and invokes the driver-provided if_start. I don't think
wireless devices are using multiple transmit queues in such a way that
if_transmit
I'd rather you file a PR first describing what you just did, then
commit the fix and close the PR.
OK, I've just submitted a PR. I'll follow the procedure you suggested.
http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/165819
Thanks
___
In RELENG_7, data frame is transmitted by iwi_tx_start() like this.
ether_output
ether_output_frame
IFQ_HANDOFF/IFQ_HANDOFF_ADJ
if_start
iwi_start
iwi_tx_start
After 8.0-RELEASE, device specific if_transmit() is called via net80211
Hi,
I'd rather you didn't commit iwi_update_mcast() unless you absolutely
know that the NIC doesn't need to be notified of multicast group
membership changes. If so, please commit that as a separate fix.
I'll look at iwi later and give you feedback on that particular change.
Thanks for chasing
On Wednesday 07 March 2012 16:38:44 Mitsuru IWASAKI wrote:
So iwi_transmit and iwi_qflush would not be necessary.
correct
Today's version of patches at:
http://people.freebsd.org/~iwasaki/iwi/iwi-20120307.diff
This would be the final version I hope.
I gave it a quick spin, works for me.
On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote:
.. except that the default if_transmit handling breaks fragments. Sigh.
So we're going to have to implement if_transmit for all net80211
drivers soon and fix fragment handling.
Not saying that you are wrong, it is unrelated to the issue
On 7 March 2012 11:17, Bernhard Schmidt bschm...@freebsd.org wrote:
On Tuesday 06 March 2012 21:12:55 Adrian Chadd wrote:
.. except that the default if_transmit handling breaks fragments. Sigh.
So we're going to have to implement if_transmit for all net80211
drivers soon and fix fragment
On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote:
Hi,
I'd rather you didn't commit iwi_update_mcast() unless you absolutely
know that the NIC doesn't need to be notified of multicast group
membership changes. If so, please commit that as a separate fix.
Oh well, iwi(4) receives
It's on topic because he included that in his patch. :)
Adrian
Sent from my Palm Pre on ATamp;T
On Mar 7, 2012 12:18 PM, Bernhard Schmidt lt;bschm...@freebsd.orggt; wrote:
On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote:
gt; Hi,
gt;
gt; I'd rather you didn't commit
Thanks Bernhard and Adrian, I think the problem seems to be solved.
My patches set IEEE80211_NODE_ASSOCID bit only if ni-ni_associd
is set. Any suggestions on this part are welcome.
Are you sure the net80211 part is correct? It looks to me as if you
are just masking the real issue. The
Hi,
I'd rather you file a PR first describing what you just did, then
commit the fix and close the PR.
Since you've found a problem, it sounds like a great reason to open a
Problem Report. :)
You can then link the commit against the PR so they reference each other.
I've been doing it for my
On Tuesday 06 March 2012 18:30:46 Mitsuru IWASAKI wrote:
Thanks Bernhard and Adrian, I think the problem seems to be solved.
My patches set IEEE80211_NODE_ASSOCID bit only if ni-ni_associd
is set. Any suggestions on this part are welcome.
Are you sure the net80211 part is correct?
.. except that the default if_transmit handling breaks fragments. Sigh.
So we're going to have to implement if_transmit for all net80211
drivers soon and fix fragment handling.
Adrian
On 6 March 2012 11:05, Bernhard Schmidt bschm...@freebsd.org wrote:
On Tuesday 06 March 2012 18:30:46 Mitsuru
Hi,
I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work
in WEP mode, which seems to be broken since 8.0-RELEASE.
The patches against HEAD at:
http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff
I'm not sure that changes on ieee80211 layer are right fixes,
but all of mbufs were
Hi!
(cc'ing freebsd-wireless, where we try to talk about this kind of stuff...)
On 5 March 2012 09:42, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote:
Hi,
I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work
in WEP mode, which seems to be broken since 8.0-RELEASE.
Thanks for looking
On Monday 05 March 2012 18:42:12 Mitsuru IWASAKI wrote:
Hi,
I've fixed iwi(4) so that Intel(R) PRO/Wireless 2915ABG work
in WEP mode, which seems to be broken since 8.0-RELEASE.
The patches against HEAD at:
http://people.freebsd.org/~iwasaki/iwi/iwi-20120305.diff
I'm not sure that
20 matches
Mail list logo
