Re: py-libzfs build failure on current, zpool_search_import() missing
Quoting Ryan Moeller (from Fri, 3 Feb 2023 10:48:35 -0500): The build still fails on -current as of end of Jan with "too few argument to function call, expected 4, have 3" for zfs_iter_filesystems. Is a patch for openzfs in -current missing? I haven't seen a commit to -current in openzfs in the last 2 days. The openzfs changes aren't that recent, but the py-libzfs port has been out of date for a while. I'll spin up a new snapshot VM and fix whatever is still broken. I can confirm that the 20230207 version of py-libzfs builds (and works) on -current. Thanks! Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF pgpMIsS8likHB.pgp Description: Digitale PGP-Signatur
Re: py-libzfs build failure on current, zpool_search_import() missing
Quoting Ryan Moeller (from Thu, 2 Feb 2023 10:43:53 -0500): I've updated the py-libzfs port to fix the build. The build still fails on -current as of end of Jan with "too few argument to function call, expected 4, have 3" for zfs_iter_filesystems. Is a patch for openzfs in -current missing? I haven't seen a commit to -current in openzfs in the last 2 days. Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF pgpXHOYNsPe15.pgp Description: Digitale PGP-Signatur
Re: py-libzfs build failure on current, zpool_search_import() missing
Thanks! But for the record, what was the actual required change? Could you like to the PR? On Thu, Feb 2, 2023 at 8:44 AM Ryan Moeller wrote: > > I've updated the py-libzfs port to fix the build. > > -- > Ryan Moeller > iXsystems, Inc. > OS Developer > Email: r...@ixsystems.com
Re: py-libzfs build failure on current, zpool_search_import() missing
Quoting Alan Somers (from Thu, 2 Feb 2023 06:58:35 -0700): Unfortunately libzfs doesn't have a stable API, so this kind of breakage is to be expected. libzfs_core does, but libzfs_core is incomplete. You should report this problem upstream at https://github.com/truenas/py-libzfs . I did already. https://github.com/truenas/py-libzfs/issues/224 There is no libzfs_core.h in /usr/include, can it be that we need to install this there? Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF pgpqkRgAqlhhN.pgp Description: Digitale PGP-Signatur
Re: py-libzfs build failure on current, zpool_search_import() missing
Unfortunately libzfs doesn't have a stable API, so this kind of breakage is to be expected. libzfs_core does, but libzfs_core is incomplete. You should report this problem upstream at https://github.com/truenas/py-libzfs . On Thu, Feb 2, 2023 at 2:37 AM Alexander Leidinger wrote: > > Hi, > > the build of py-libzfs fails on -current due to a missing > zpool_search_import(), and as such iocage can not be build (and the > old iocage segfaults, so the ABI seems to have changed too). The > symbol is available in libzutil, but I can not find > zpool_search_import() in /usr/include. > > Anyone with an idea if there is something missing (maybe something to > be installed into /usr/include), or what needs to be done to py-libzfs? > > Bye, > Alexander. > > -- > http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF > http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF
py-libzfs build failure on current, zpool_search_import() missing
Hi, the build of py-libzfs fails on -current due to a missing zpool_search_import(), and as such iocage can not be build (and the old iocage segfaults, so the ABI seems to have changed too). The symbol is available in libzutil, but I can not find zpool_search_import() in /usr/include. Anyone with an idea if there is something missing (maybe something to be installed into /usr/include), or what needs to be done to py-libzfs? Bye, Alexander. -- http://www.Leidinger.net alexan...@leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.orgnetch...@freebsd.org : PGP 0x8F31830F9F2772BF pgpT2LpLYHf04.pgp Description: Digitale PGP-Signatur
