Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "matt" Here are the delete methods: deleteflag: ATA_TRIM (2) = 1 da4: Delete methods: deleteflag: ATA_TRIM (2) = 1 da3: Delete methods: deleteflag: ATA_TRIM (2) = 1 Here is a truncated dmesg | fgrep mps mps0: port 0xb000-0xb0ff mem 0xfe83c000-0xfe83,0

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 19:13, Steven Hartland wrote: > > Thats correct, the mps controllers I have here announce UNMAP support for > SATA disks that support TRIM and then do firmware translation on the > commands sent from the OS before passing them to the disks. > > This is why I was expecting your controlle

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "matt" To: "Steven Hartland" Cc: Sent: Sunday, April 28, 2013 3:03 AM Subject: Re: r249939+ not detecting ata trim On 04/27/13 18:51, Steven Hartland wrote: - Original Message - From: "matt" FYI: Change only r

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 18:51, Steven Hartland wrote: > - Original Message - From: "matt" >>> FYI: Change only requires kernel, world would be identical, which >>> should save you some time. >> >> And some untrimmed deletes! >> >> Thanks, with geom/cam/disk stuff I usually assume that it could affect >

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "matt" FYI: Change only requires kernel, world would be identical, which should save you some time. And some untrimmed deletes! Thanks, with geom/cam/disk stuff I usually assume that it could affect userland out of caution. BTW...ata identify is working fin

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 18:32, Steven Hartland wrote: > > FYI: Change only requires kernel, world would be identical, which > should save you some time. > >Regards >Steve > > And some untrimmed deletes! Thanks, with geom/cam/disk stuff I usually assume that it could affect userland out of caution. BT

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "matt" On 04/27/13 15:58, Steven Hartland wrote: If your controller doesn't support UNMAP then this will be the reason, however mps should support this. Could you confirm if previously you where seeing UNMAP as the reported delete_method? I am rebuilding wo

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 15:58, Steven Hartland wrote: > > If your controller doesn't support UNMAP then this will be the reason, > however mps should support this. > > Could you confirm if previously you where seeing UNMAP as the reported > delete_method? > >Regards >Steve > > =

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "Steven Hartland" I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me before r249939. When I saw that this functionality was being added to current, I built world/kernel without the patches. In

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: "matt" To: Sent: Saturday, April 27, 2013 10:00 PM Subject: r249939+ not detecting ata trim I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me before r249939. When

r249939+ not detecting ata trim

2013-04-27 Thread matt
I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me before r249939. When I saw that this functionality was being added to current, I built world/kernel without the patches. Indeed, many of the commits are quite similar to the update