savecore.c broken now, breaks world

2002-05-05 Thread Szilveszter Adam

Hello,

src/sbin/savecore.c has been broken today, with the commit of rev 1.59
by Bill Fenner.

It appears that a new magic value, KERNELDUMPMAGIC_CLEARED, has been
introduced but its value never #define-d in (probably)
src/sys/sys/kerneldump.h. This way, the program does not compile.

There is only so much one can deduce from the code, it is the author who
should know what was intended here.

This breaks the world.

-- 
Regards:

Szilveszter ADAM
Szombathely Hungary

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: savecore.c broken now, breaks world

2002-05-05 Thread Maxime Henrion

Szilveszter Adam wrote:
 Hello,
 
 src/sbin/savecore.c has been broken today, with the commit of rev 1.59
 by Bill Fenner.

This is fixed in revision 1.4 of src/sys/sys/kerneldump.h.

Cheers,
Maxime

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: savecore.c broken now, breaks world

2002-05-05 Thread Maxim Konovalov

On 15:17+0200, May 5, 2002, Szilveszter Adam wrote:

 Hello,

 src/sbin/savecore.c has been broken today, with the commit of rev 1.59
 by Bill Fenner.

 It appears that a new magic value, KERNELDUMPMAGIC_CLEARED, has been
 introduced but its value never #define-d in (probably)
 src/sys/sys/kerneldump.h. This way, the program does not compile.

 There is only so much one can deduce from the code, it is the author who
 should know what was intended here.

 This breaks the world.

This patch solves the problem:

Index: sys_sys/kerneldump.h
===
RCS file: /home/ncvs/src/sys/sys/kerneldump.h,v
retrieving revision 1.3
diff -u -r1.3 kerneldump.h
--- sys_sys/kerneldump.h3 Apr 2002 07:24:10 -   1.3
+++ sys_sys/kerneldump.h5 May 2002 13:49:04 -
@@ -60,6 +60,7 @@
 struct kerneldumpheader {
charmagic[20];
 #defineKERNELDUMPMAGIC FreeBSD Kernel Dump
+#defineKERNELDUMPMAGIC_CLEARED FreeBSD Cleard Dump
chararchitecture[12];
uint32_tversion;
 #defineKERNELDUMPVERSION   1

%%%

-- 
Maxim Konovalov, MAcomnet, Internet Dept., system engineer
phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message