Re: smartmontools now broken on -current (by svn r301771, r301778?)

2016-06-11 Thread Warner Losh
Also, on my system running nda, smartmontools work. And the latest version
is compiling in Netflix's tree, which is where I took all these patches from...

Warner

On Sat, Jun 11, 2016 at 5:57 PM, Warner Losh  wrote:
> I'm skeptical. The ATA stuff isn't anything that I've committed to, so
> that isn't new.
>
> The nvme stuff is because smartmontools defines nvme stuff that
> conflicts with the FreeBSD defines...
>
> Warner
>
>
> On Sat, Jun 11, 2016 at 9:42 AM, Ngie Cooper (yaneurabeya)
>  wrote:
>>
>>> On Jun 11, 2016, at 09:40, Michael Butler  
>>> wrote:
>>>
>>> The recent nvme updates have broken smartmontools ..
>>>
>>> imb@toshi:/home/imb> sudo smartctl -a /dev/ada0
>>> smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-ALPHA2 amd64] (local build)
>>> Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org
>>>
>>> /dev/ada0: Inappropriate ioctl for device
>>> Please specify device type with the -d option.
>>>
>>> Attempts to recompile the utility also fail:
>>
>> Hi Michael,
>> Please file a bug — in ports first, and if necessary in the base 
>> system.
>> Thank you!
>> -Ngie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: smartmontools now broken on -current (by svn r301771, r301778?)

2016-06-11 Thread Warner Losh
I'm skeptical. The ATA stuff isn't anything that I've committed to, so
that isn't new.

The nvme stuff is because smartmontools defines nvme stuff that
conflicts with the FreeBSD defines...

Warner


On Sat, Jun 11, 2016 at 9:42 AM, Ngie Cooper (yaneurabeya)
 wrote:
>
>> On Jun 11, 2016, at 09:40, Michael Butler  
>> wrote:
>>
>> The recent nvme updates have broken smartmontools ..
>>
>> imb@toshi:/home/imb> sudo smartctl -a /dev/ada0
>> smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-ALPHA2 amd64] (local build)
>> Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org
>>
>> /dev/ada0: Inappropriate ioctl for device
>> Please specify device type with the -d option.
>>
>> Attempts to recompile the utility also fail:
>
> Hi Michael,
> Please file a bug — in ports first, and if necessary in the base 
> system.
> Thank you!
> -Ngie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: smartmontools now broken on -current (by svn r301771, r301778?)

2016-06-11 Thread Ngie Cooper (yaneurabeya)

> On Jun 11, 2016, at 09:40, Michael Butler  wrote:
> 
> The recent nvme updates have broken smartmontools ..
> 
> imb@toshi:/home/imb> sudo smartctl -a /dev/ada0
> smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-ALPHA2 amd64] (local build)
> Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org
> 
> /dev/ada0: Inappropriate ioctl for device
> Please specify device type with the -d option.
> 
> Attempts to recompile the utility also fail:

Hi Michael,
Please file a bug — in ports first, and if necessary in the base system.
Thank you!
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail


smartmontools now broken on -current (by svn r301771, r301778?)

2016-06-11 Thread Michael Butler
The recent nvme updates have broken smartmontools ..

imb@toshi:/home/imb> sudo smartctl -a /dev/ada0
smartctl 6.5 2016-05-07 r4318 [FreeBSD 11.0-ALPHA2 amd64] (local build)
Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org

/dev/ada0: Inappropriate ioctl for device
Please specify device type with the -d option.

Attempts to recompile the utility also fail:

c++ -DHAVE_CONFIG_H -I.  -DBUILD_INFO='"(local build)"'
-DSMARTMONTOOLS_SYSCONFDIR='"/usr/local/etc"'
-DSMARTMONTOOLS_SMARTDSCRIPTDIR='"/usr/local/etc"'
-DSMARTMONTOOLS_DRIVEDBDIR='"/usr/local/share/smartmontools"'-O2
-pipe -march=core2 -fstack-protector -fno-strict-aliasing  -Wall -W -c
-o cciss.o cciss.cpp
In file included from os_freebsd.cpp:43:
./atacmds.h:77:9: warning: 'ATA_SET_FEATURES' macro redefined
[-Wmacro-redefined]
#define ATA_SET_FEATURES0xef
^
/usr/include/sys/ata.h:399:10: note: previous definition is here
#define ATA_SET_FEATURES0x05/* set features */
^
In file included from os_freebsd.cpp:74:
./freebsd_nvme_ioctl.h:34:8: error: redefinition of 'nvme_command'
struct nvme_command
   ^
/usr/include/dev/nvme/nvme.h:201:8: note: previous definition is here
struct nvme_command
   ^
In file included from os_freebsd.cpp:74:
./freebsd_nvme_ioctl.h:67:8: error: redefinition of 'nvme_status'
struct nvme_status {
   ^
/usr/include/dev/nvme/nvme.h:234:8: note: previous definition is here
struct nvme_status {
   ^
In file included from os_freebsd.cpp:74:
./freebsd_nvme_ioctl.h:77:8: error: redefinition of 'nvme_completion'
struct nvme_completion {
   ^
/usr/include/dev/nvme/nvme.h:244:8: note: previous definition is here
struct nvme_completion {
   ^
In file included from os_freebsd.cpp:74:
./freebsd_nvme_ioctl.h:94:8: error: redefinition of 'nvme_pt_command'
struct nvme_pt_command {
   ^
/usr/include/dev/nvme/nvme.h:765:8: note: previous definition is here
struct nvme_pt_command {
   ^
1 warning and 4 errors generated.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"