Re: unused in_cksum_update() ?

2014-01-27 Thread Ulrich Spörlein
On Fri, 2014-01-10 at 19:24:48 +0100, Luigi Rizzo wrote: On Fri, Jan 10, 2014 at 02:31:40PM +0400, Gleb Smirnoff wrote: On Thu, Jan 09, 2014 at 08:21:14PM +0100, Luigi Rizzo wrote: L a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h) L have a lengthy definition for L L

Re: unused in_cksum_update() ?

2014-01-10 Thread Gleb Smirnoff
On Thu, Jan 09, 2014 at 08:21:14PM +0100, Luigi Rizzo wrote: L a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h) L have a lengthy definition for L L in_cksum_update(struct ip *ip) L L which seems completely unused in our source tree. L Time to remove it perhaps ? L L grep

Re: unused in_cksum_update() ?

2014-01-10 Thread Luigi Rizzo
On Fri, Jan 10, 2014 at 02:31:40PM +0400, Gleb Smirnoff wrote: On Thu, Jan 09, 2014 at 08:21:14PM +0100, Luigi Rizzo wrote: L a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h) L have a lengthy definition for L Lin_cksum_update(struct ip *ip) L L which seems completely

unused in_cksum_update() ?

2014-01-09 Thread Luigi Rizzo
a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h) have a lengthy definition for in_cksum_update(struct ip *ip) which seems completely unused in our source tree. Time to remove it perhaps ? grep cannot find any use at least since stable/8 cheers luigi

Re: unused in_cksum_update() ?

2014-01-09 Thread Adrian Chadd
It's likely used elsewhere; it's the kind of thing you abuse when doing header rewriting and reinjection. So, what's the NAT and such code using? -a On 9 January 2014 11:21, Luigi Rizzo ri...@iet.unipi.it wrote: a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h) have a lengthy

Re: unused in_cksum_update() ?

2014-01-09 Thread Luigi Rizzo
On Thu, Jan 09, 2014 at 01:27:52PM -0800, Adrian Chadd wrote: It's likely used elsewhere; it's the kind of thing you abuse when doing header rewriting and reinjection. So, what's the NAT and such code using? natd/libalias has its own code with a DifferentialChecksum() function in