Re: vfs_mouse.c breakage?
On 6/1/20 5:10 PM, Rick Macklem wrote: It also needed . It is ancient code (that started out in SunOS. if I recall correctly), where they used things like "bool_t" and set them with TRUE/FALSE (upper case). Unfortunately, those includes love to include other includes... Anyhow, I think it is fixed now, rick I can confirm on my end as well - thanks Rick! -pete -- Pete Wright p...@nomadlogic.org @nomadlogicLA ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: vfs_mouse.c breakage?
It also needed .
It is ancient code (that started out in SunOS. if I recall correctly), where
they
used things like "bool_t" and set them with TRUE/FALSE (upper case).
Unfortunately, those includes love to include other includes...
Anyhow, I think it is fixed now, rick
From: Pete Wright
Sent: Monday, June 1, 2020 8:05 PM
To: Rick Macklem; FreeBSD Current
Subject: Re: vfs_mouse.c breakage?
CAUTION: This email originated from outside of the University of Guelph. Do not
click links or open attachments unless you recognize the sender and know the
content is safe. If in doubt, forward suspicious emails to ith...@uoguelph.ca
On 6/1/20 2:50 PM, Rick Macklem wrote:
> Pete Wright wrote:
>> Subject: vfs_mouse.c breakage?
> Not sure if the vfs mouse is broken (sorry, I couldn't resist), but...
hah nice - dyslexia + poor eyesight are not good bedfellows :^)
>
> I think it needs a:
> #include
>
> but it will take a little while for me to test this.
>
> Thanks for reporting it, rick
no prob - adding that include thew some more errors
$ git diff
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
index 03f95b2845f9..4282b1938095 100644
--- a/sys/kern/vfs_mount.c
+++ b/sys/kern/vfs_mount.c
@@ -39,6 +39,7 @@
#include
__FBSDID("$FreeBSD$");
+#include
#include
#include
#include
here's a snippet of the exception:
--- vfs_mount.o ---
In file included from /usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:42:
In file included from /usr/home/pete/git/freebsd/sys/rpc/auth.h:50:
/usr/home/pete/git/freebsd/sys/rpc/xdr.h:105:3: error: type name
requires a specifier or qualifier
bool_t (*x_getlong)(struct XDR *, long *);
I'll sit tight for now - thanks for checking it out!
-pete
--
Pete Wright
p...@nomadlogic.org
@nomadlogicLA
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: vfs_mouse.c breakage?
On 6/1/20 2:50 PM, Rick Macklem wrote:
Pete Wright wrote:
Subject: vfs_mouse.c breakage?
Not sure if the vfs mouse is broken (sorry, I couldn't resist), but...
hah nice - dyslexia + poor eyesight are not good bedfellows :^)
I think it needs a:
#include
but it will take a little while for me to test this.
Thanks for reporting it, rick
no prob - adding that include thew some more errors
$ git diff
diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
index 03f95b2845f9..4282b1938095 100644
--- a/sys/kern/vfs_mount.c
+++ b/sys/kern/vfs_mount.c
@@ -39,6 +39,7 @@
#include
__FBSDID("$FreeBSD$");
+#include
#include
#include
#include
here's a snippet of the exception:
--- vfs_mount.o ---
In file included from /usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:42:
In file included from /usr/home/pete/git/freebsd/sys/rpc/auth.h:50:
/usr/home/pete/git/freebsd/sys/rpc/xdr.h:105:3: error: type name
requires a specifier or qualifier
bool_t (*x_getlong)(struct XDR *, long *);
I'll sit tight for now - thanks for checking it out!
-pete
--
Pete Wright
p...@nomadlogic.org
@nomadlogicLA
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: vfs_mouse.c breakage?
Pete Wright wrote: >Subject: vfs_mouse.c breakage? Not sure if the vfs mouse is broken (sorry, I couldn't resist), but... I think it needs a: #include but it will take a little while for me to test this. Thanks for reporting it, rick >hello - i am having issues building CURRENT after this was applied: >--- vfs_mount.o --- >/usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:2360:27: error: use of >undeclared identifier 'AUTH_SYS' > exp->ex_secflavors[0] = AUTH_SYS; > ^ >1 error generated. >*** [vfs_mount.o] Error code 1 > > >was curious if others are seeing this? > >cheers, >-pete > >-- >Pete Wright >p...@nomadlogic.org >@nomadlogicLA ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
vfs_mouse.c breakage?
hello - i am having issues building CURRENT after this was applied: https://reviews.freebsd.org/D25045 https://svnweb.freebsd.org/base?view=revision=361699 --- vfs_mount.o --- /usr/home/pete/git/freebsd/sys/kern/vfs_mount.c:2360:27: error: use of undeclared identifier 'AUTH_SYS' exp->ex_secflavors[0] = AUTH_SYS; ^ 1 error generated. *** [vfs_mount.o] Error code 1 was curious if others are seeing this? cheers, -pete -- Pete Wright p...@nomadlogic.org @nomadlogicLA ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
