Re: Multiple hpet messages during boot

2010-09-17 Thread Joel Dahl
On 16-09-2010  8:28, John Baldwin wrote:
 On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
  I noticed this during boot (HEAD from yesterday):
  
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  hpet0: [FILTER]
  
  Is it really necessary to print this 8 times?
 
 I'd actually like to remove the interrupt messages that say '[FILTER]' or 
 '[GIANT]', etc.  I think in general they only add clutter.

Definitely agreed.  Go for it.

--
Joel
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-17 Thread M. Warner Losh
In message: 4c911214.7060...@freebsd.org
Alexander Motin m...@freebsd.org writes:
: Joel Dahl wrote:
:  I noticed this during boot (HEAD from yesterday):
:  
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  
:  Is it really necessary to print this 8 times?
: 
: HPET at present chipsets may use up to 8 IRQs. Driver registers filter
: interrupt handlers for them. Interrupt handling code prints this.
: 
: If you boot with verbose, you may see that some network cards prints
: alike things for the number of supported MSI/MSI-X interrupts.

Is there any reason not to toss all FILTER messages behind
bootverbose?

Warner
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-17 Thread M. Warner Losh
In message: 201009160828.35520@freebsd.org
John Baldwin j...@freebsd.org writes:
: On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
:  I noticed this during boot (HEAD from yesterday):
:  
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  hpet0: [FILTER]
:  
:  Is it really necessary to print this 8 times?
: 
: I'd actually like to remove the interrupt messages that say '[FILTER]' or 
: '[GIANT]', etc.  I think in general they only add clutter.

[GIANT] is just public shaming of drivers anyway.  It has worked to
get them all the major ones locked.  Well, except for atkbd and psm...

I'd be happy to toss them behind a bootverbose :)

Warner
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-17 Thread M. Warner Losh
In message: 20100917055953.gf1...@pluto.vnode.local
Joel Dahl j...@freebsd.org writes:
: On 16-09-2010  8:28, John Baldwin wrote:
:  On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
:   I noticed this during boot (HEAD from yesterday):
:   
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   hpet0: [FILTER]
:   
:   Is it really necessary to print this 8 times?
:  
:  I'd actually like to remove the interrupt messages that say '[FILTER]' or 
:  '[GIANT]', etc.  I think in general they only add clutter.
: 
: Definitely agreed.  Go for it.

so is there support for the following:

Index: subr_bus.c
===
--- subr_bus.c  (revision 212791)
+++ subr_bus.c  (working copy)
@@ -3996,9 +3996,11 @@
arg, cookiep);
if (error != 0)
return (error);
+   if (bootverbose == 0)
+   return (0);
if (handler != NULL  !(flags  INTR_MPSAFE))
device_printf(dev, [GIANT-LOCKED]\n);
-   if (bootverbose  (flags  INTR_MPSAFE))
+   if (flags  INTR_MPSAFE)
device_printf(dev, [MPSAFE]\n);
if (filter != NULL) {
if (handler == NULL)


Warner
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-17 Thread Andriy Gapon
on 17/09/2010 18:36 M. Warner Losh said the following:
 
 so is there support for the following:

Aye.

 Index: subr_bus.c
 ===
 --- subr_bus.c(revision 212791)
 +++ subr_bus.c(working copy)
 @@ -3996,9 +3996,11 @@
   arg, cookiep);
   if (error != 0)
   return (error);
 + if (bootverbose == 0)
 + return (0);
   if (handler != NULL  !(flags  INTR_MPSAFE))
   device_printf(dev, [GIANT-LOCKED]\n);
 - if (bootverbose  (flags  INTR_MPSAFE))
 + if (flags  INTR_MPSAFE)
   device_printf(dev, [MPSAFE]\n);
   if (filter != NULL) {
   if (handler == NULL)

-- 
Andriy Gapon
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-16 Thread John Baldwin
On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
 I noticed this during boot (HEAD from yesterday):
 
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 
 Is it really necessary to print this 8 times?

I'd actually like to remove the interrupt messages that say '[FILTER]' or 
'[GIANT]', etc.  I think in general they only add clutter.

-- 
John Baldwin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-16 Thread Doug Barton

On 9/16/2010 5:28 AM, John Baldwin wrote:

On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:

I noticed this during boot (HEAD from yesterday):

hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]
hpet0: [FILTER]

Is it really necessary to print this 8 times?


I'd actually like to remove the interrupt messages that say '[FILTER]' or
'[GIANT]', etc.  I think in general they only add clutter.


+1

--

... and that's just a little bit of history repeating.
-- Propellerheads

Improve the effectiveness of your Internet presence with
a domain name makeover!http://SupersetSolutions.com/

___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org


Re: Multiple hpet messages during boot

2010-09-15 Thread Alexander Motin
Joel Dahl wrote:
 I noticed this during boot (HEAD from yesterday):
 
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 hpet0: [FILTER]
 
 Is it really necessary to print this 8 times?

HPET at present chipsets may use up to 8 IRQs. Driver registers filter
interrupt handlers for them. Interrupt handling code prints this.

If you boot with verbose, you may see that some network cards prints
alike things for the number of supported MSI/MSI-X interrupts.

-- 
Alexander Motin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org