Re: Linux epoll(7) patch

2013-08-05 Thread Mateusz Guzik
to leave fd with badfdops in place so that epoll users get less surprised. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd

Re: How to best overload the fileops ?

2013-08-21 Thread Mateusz Guzik
of current code is unavoidable. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: How to best overload the fileops ?

2013-08-21 Thread Mateusz Guzik
On Wed, Aug 21, 2013 at 05:30:05PM -0700, Yuri wrote: On 08/21/2013 17:10, Mateusz Guzik wrote: Short answer is provide epollops with your own fo_close and the rest as it is currently in kqueueops. All function are static, but this is not a real problem since you have to modify kern_event.c

Re: exec on /usr/src?

2013-09-22 Thread Mateusz Guzik
such a way to bypass noexec for scripts seems obvious, I guess it makes sense to document it so that noone does 'sh/python/perl foo' and claims a vulnerability was discovered (it would be impossible to fix this anyway). -- Mateusz Guzik mjguzik gmail.com

Re: gnop panic with recent kernel (r256923)

2013-10-22 Thread Mateusz Guzik
= g_malloc(sizeof(*sc), M_WAITOK); + sc = g_malloc(sizeof(*sc), M_WAITOK | M_ZERO); sc-sc_offset = offset; sc-sc_explicitsize = explicitsize; sc-sc_error = ioerror; -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current

Re: make buildworld

2013-10-22 Thread Mateusz Guzik
:9: note: previous definition is here #define MALLOC_PRODUCTION 1 ^ 1 error generated. *** Error code 1 Presumably you have MALLOC_PRODUCTION set in src.conf or make.conf, remove it. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org

Re: gnop panic with recent kernel (r256923)

2013-10-22 Thread Mateusz Guzik
On Tue, Oct 22, 2013 at 09:15:45PM -0400, Keith White wrote: On Wed, 23 Oct 2013, Mateusz Guzik wrote: On Tue, Oct 22, 2013 at 07:59:29PM -0400, Keith White wrote: I get a gnop lock panic when trying to create a gnop device: # gnop create -S 4k ada3 panic: lock gnop lock

Re: can't open '/boot/menusets.4th'

2012-11-12 Thread Mateusz Guzik
while including /boot/menu.rc, in the line include /boot/menu-commands.4th Seems to be fixed by r242688. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current

compiler info in kernel identification string

2012-11-13 Thread Mateusz Guzik
10.0-CURRENT #1 r243006:243007M(gcc-4.2.1-20070831): Wed Nov 14 00:41:23 CET 2012 I have no strong opinions on format, I just want this information easly accessible. Comments? -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing

Re: compiler info in kernel identification string

2012-11-15 Thread Mateusz Guzik
to everything that newvers.sh was able to determine and to complete version string, and you are free to change it however you want using detected revision/compiler/whatever or completely new data. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current

Re: compiler info in kernel identification string

2012-11-15 Thread Mateusz Guzik
see only first line is captured and I go with assumption that --version works, I hope this is ok. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send

Re: pw keeps setting /etc/group to 0600

2012-11-17 Thread Mateusz Guzik
/testdir/ This is not a bug and I think it always was this way. The process you used to su/sudo/whatever to root was not in testing group and didn't magically enter it after you added rstone user to that group. You have to log in again or do stuff like exec su - rstone. -- Mateusz Guzik mjguzik

Re: prompt w/ uid 0 for cshrc

2012-11-18 Thread Mateusz Guzik
. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: prompt w/ uid 0 for cshrc

2012-11-19 Thread Mateusz Guzik
On Mon, Nov 19, 2012 at 10:45:35AM -0500, Eitan Adler wrote: On 18 November 2012 18:44, Mateusz Guzik mjgu...@gmail.com wrote: Just take user name from id -nu. While that does provide the $user value I want, id is in /usr/bin/ which may not be mounted. Is there a builtin which provides

Re: pw keeps setting /etc/group to 0600

2012-11-19 Thread Mateusz Guzik
be nice. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: pw keeps setting /etc/group to 0600

2012-11-21 Thread Mateusz Guzik
On Wed, Nov 21, 2012 at 05:45:43PM +0200, Jaakko Heinonen wrote: On 2012-11-19, Mateusz Guzik wrote: First, pw should not fail if other instance is running, it should wait instead (think of parallel batch scripts adding some users/groups). Second, current code has a race: lockfd = open

Re: after upgrade, can't restart apache via cron

2012-11-23 Thread Mateusz Guzik
' variables.) If this is a bug or not I cannot say. /etc/rc.subr contains lines like: SYSCTL=/sbin/sysctl ID=/usr/bin/id for few tools, rest is assumed to work with provided PATH. To sum up, use service(8) and you will be fine. -- Mateusz Guzik mjguzik gmail.com

Re: after upgrade, can't restart apache via cron

2012-11-26 Thread Mateusz Guzik
after reboot it stopped working). Also I doubt anyone relies on current environment and what not to start a service, but we can provide another target tha would start the service without sanitizing in case this is needed. -- Mateusz Guzik mjguzik gmail.com

Re: New jail does not understand nullfs

2012-12-02 Thread Mateusz Guzik
this config instead of copy-pasting it? -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: New jail does not understand nullfs

2012-12-03 Thread Mateusz Guzik
are updated? (or that world and kernel are in sync) -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: please add auditdistd user/group to -stable and the 9.1-release?

2012-12-10 Thread Mateusz Guzik
. This would be the useful behavior when using mtree files to verify files on disk. This is likely the most appropriate default behavior. I agree, except s/number/name from in-tree passwd file/ . :) -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current

Re: compiler info in kernel identification string

2012-12-23 Thread Mateusz Guzik
On Sun, Dec 23, 2012 at 03:18:14PM +0200, Andriy Gapon wrote: on 15/11/2012 22:43 Andriy Gapon said the following: on 14/11/2012 01:43 Mateusz Guzik said the following: Hello, avg@ suggested to include compiler version in the kernel so that it's present in uname (and one can easly tell

Re: panic, seems related to r234386

2012-05-07 Thread Mateusz Guzik
this fixes your problem. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: panic, seems related to r234386

2012-05-10 Thread Mateusz Guzik
On Tue, May 08, 2012 at 09:45:14PM +0200, Peter Holm wrote: On Mon, May 07, 2012 at 10:11:53PM +0200, Mateusz Guzik wrote: On Mon, May 07, 2012 at 12:28:41PM -0700, Doug Barton wrote: On 05/06/2012 15:19, Sergey Kandaurov wrote: On 7 May 2012 01:54, Doug Barton do...@freebsd.org wrote

Re: panic, seems related to r234386

2012-05-12 Thread Mateusz Guzik
On Thu, May 10, 2012 at 12:39:00PM +0200, Peter Holm wrote: On Thu, May 10, 2012 at 12:21:18PM +0200, Mateusz Guzik wrote: On Tue, May 08, 2012 at 09:45:14PM +0200, Peter Holm wrote: On Mon, May 07, 2012 at 10:11:53PM +0200, Mateusz Guzik wrote: On Mon, May 07, 2012 at 12:28:41PM -0700

Re: sockstat jid patch

2012-05-16 Thread Mateusz Guzik
get implementation mentioned earlier. I can try to write a patch in a couple of days (or this evening if I find the time). -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd

Re: Recent nandfs commits broke buildworld with clang

2012-05-21 Thread Mateusz Guzik
the following: CC=clang CXX=clang++ CPP=clang-cpp Which should fix your problem. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail

sysvshm: replace Giant with a local sx lock

2013-04-23 Thread Mateusz Guzik
(shmcalls[0])) return (EINVAL); - mtx_lock(Giant); + sx_xlock(shm_lock); error = (*shmcalls[uap-which])(td, uap-a2); - mtx_unlock(Giant); + sx_xunlock(shm_lock); return (error); } -- Mateusz Guzik mjguzik gmail.com

Re: sysvshm: replace Giant with a local sx lock

2013-04-23 Thread Mateusz Guzik
On Tue, Apr 23, 2013 at 11:55:32PM +0300, Konstantin Belousov wrote: On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: I would like to replace Giant with a local sx lock in sysvshm code. Looked really straightforward so maybe I missed something. At very least

Re: sysvshm: replace Giant with a local sx lock

2013-05-14 Thread Mateusz Guzik
On Tue, Apr 23, 2013 at 11:36:21PM +0200, Mateusz Guzik wrote: On Tue, Apr 23, 2013 at 11:55:32PM +0300, Konstantin Belousov wrote: On Tue, Apr 23, 2013 at 10:38:23PM +0200, Mateusz Guzik wrote: I would like to replace Giant with a local sx lock in sysvshm code. Looked really

acct: shared rlimit object for exiting processes

2013-05-22 Thread Mateusz Guzik
-p_limit = newlim; + lim_free(p-p_limit); + p-p_limit = lim_hold(acct_limit); PROC_UNLOCK(p); - lim_free(oldlim); /* * Write the accounting information to the file. -- Mateusz Guzik mjguzik gmail.com ___ freebsd

Re: NULL pointer crash in exit1() when running certain Linux binaries

2013-06-22 Thread Mateusz Guzik
a quick hack to get around it: http://people.freebsd.org/~mjg/patches/linux-emuldata-race-hack.diff I believe dchagin@ did a lot of reworking in this area in his linux branch, so I guess this hack will be sufficent for now. -- Mateusz Guzik mjguzik gmail.com

Re: panic: Lock filedesc structure not share locked

2013-06-30 Thread Mateusz Guzik
) + FILEDESC_SLOCK(efbuf-fdp); return (0); } efbuf-remainder -= kif-kf_structsize; -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo

Re: r248583 Kernel panic: negative refcount 0xfffffe0031b59168

2013-06-30 Thread Mateusz Guzik
) fde-fde_flags |= UF_EXCLOSE; -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: panic: Lock filedesc structure not share locked

2013-06-30 Thread Mateusz Guzik
On Mon, Jul 01, 2013 at 12:23:35AM +0300, Mikolaj Golub wrote: On Sun, Jun 30, 2013 at 10:27:57AM +0200, Mateusz Guzik wrote: On Sun, Jun 30, 2013 at 09:41:50AM +0200, Alexander Leidinger wrote: Hi, with head as of r252381 on amd64, I got the following panic after starting tmux

Re: r248583 Kernel panic: negative refcount 0xfffffe0031b59168

2013-07-15 Thread Mateusz Guzik
On Mon, Jul 15, 2013 at 03:16:37PM +0600, Eugene M. Zheganin wrote: Hi. On 02.07.2013 05:10, Pawel Jakub Dawidek wrote: On Sun, Jun 30, 2013 at 01:18:36PM +0200, Mateusz Guzik wrote: Turns out the bug is quite funny ;) Try this: diff --git a/sys/kern/uipc_usrreq.c b/sys/kern

Re: ldd runs linux programs

2013-07-28 Thread Mateusz Guzik
://people.freebsd.org/~mjg/patches/ldd-non-freebsd-ignore.diff If someone wants, go ahead and steal it. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail

Re: ldd runs linux programs

2013-07-29 Thread Mateusz Guzik
On Mon, Jul 29, 2013 at 10:33:53AM +0800, Julian Elischer wrote: On 7/29/13 4:49 AM, Mateusz Guzik wrote: On Sun, Jul 28, 2013 at 11:31:10PM +0400, Gennady Proskurin wrote: Hello. When linux binary is passed to FreeBSD's ldd as argument, this binary is executed. I'm sure this is bug

Re: ldd runs linux programs

2013-07-29 Thread Mateusz Guzik
something with this, I suggest cleaning up PRs and reviving discussion in http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/127276 -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo

Re: devd problem after recent upgrade

2014-03-25 Thread Mateusz Guzik
to run dhclient em0 to get the network started. I have not added to or changed any config files. Has anyone else seen strange behavior like this recently? Any help would be appreciated. That's my fault, I'll fix it shortly. -- Mateusz Guzik mjguzik gmail.com

Re: devd problem after recent upgrade

2014-03-25 Thread Mateusz Guzik
On Wed, Mar 26, 2014 at 02:53:25AM +0100, Mateusz Guzik wrote: On Tue, Mar 25, 2014 at 09:31:57PM -0400, AN wrote: I just upgraded to svn r263756 and have a major problem, the system has no mouse. When I reboot I see the following message on the console: devd:devctl sysctl missing from

Re: [head tinderbox] failure on mips/mips

2014-07-01 Thread Mateusz Guzik
: 'newsigacts' was declared here *** Error code 1 Should be fixed with r268136 -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail

SUJ panic on new directory rename

2010-07-03 Thread Mateusz Guzik
in ?? () This can be easly reproduced by running this program: http://student.agh.edu.pl/~mjguzik/rename.c Thanks, -- Mateusz Guzik mjgu...@gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current

namei: avoid needless relocking for absolute lookups

2014-09-01 Thread Mateusz Guzik
); + } + } } namei_cleanup_cnp(cnp); vput(ndp-ni_vp); -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current

Re: all processes have ppid 1

2014-09-03 Thread Mateusz Guzik
/qFg5FusN Please try r270993. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: _ftello() modification requires additional capsicum rights, breaking tcpdump and dhclient

2014-09-16 Thread Mateusz Guzik
. I'll try to ping people to move it forward. IIRC there was a report of unbound failing this way, apparently fixed with aforementioned patch. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman

libmap.conf vs packages and whatnot

2014-10-17 Thread Mateusz Guzik
, as long as there are more than 3 files (as with current approach one would have to parse them all). -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send

junior kernel tasks

2014-10-25 Thread Mateusz Guzik
are not interested, but know someone who does, please pass it down. [1] - not really, no [2] - well, I guess that's subjective, so that's not a no Cheers, -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http

Re: Jenkins build is unstable: FreeBSD_HEAD-tests2 #161

2014-10-31 Thread Mateusz Guzik
to /var. Looks like the test in question assumes it always gets /dev/md0. The test works for me not what the regression is fixed. I guess jenkins didn't catch up to it yet. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list

Re: junior kernel tasks

2014-11-02 Thread Mateusz Guzik
On Sat, Oct 25, 2014 at 10:45:36PM +0200, Mateusz Guzik wrote: Hello, In short, nice kernel tasks people with C language skills can do in few evenings. https://wiki.freebsd.org/JuniorJobs It is assumed you know how to obtain sources and build the kernel. What you can get in return

Re: Build failed in Jenkins: FreeBSD_HEAD #1835

2014-11-13 Thread Mateusz Guzik
://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD/ws/sys/sys/filedesc.h:161:1: note: 'fdinit' declared here struct filedesc *fdinit(struct filedesc *fdp); ^ That's my fault, fixed in https://svnweb.freebsd.org/changeset/base/274485 -- Mateusz Guzik mjguzik gmail.com

Re: Finding a rogue src/sys commit with bisection?

2014-11-15 Thread Mateusz Guzik
. In absolutely worst case yu can check out git tree and bisect that :- -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current

Re: [PATCH] Convert the VFS cache lock to an rmlock

2015-03-18 Thread Mateusz Guzik
On Wed, Mar 18, 2015 at 10:17:22AM -0400, John Baldwin wrote: On Friday, March 13, 2015 06:32:03 AM Mateusz Guzik wrote: On Thu, Mar 12, 2015 at 06:13:00PM -0500, Alan Cox wrote: Below is partial results from a profile of a parallel (-j7) buildworld on a 6-core machine that I did

Re: [PATCH] Convert the VFS cache lock to an rmlock

2015-03-17 Thread Mateusz Guzik
On Fri, Mar 13, 2015 at 11:23:06AM -0400, Ryan Stone wrote: On Thu, Mar 12, 2015 at 1:36 PM, Mateusz Guzik mjgu...@gmail.com wrote: Workloads like buildworld and the like (i.e. a lot of forks + execs) run into very severe contention in vm, which is orders of magnitude bigger than anything

Re: Build failed in Jenkins: FreeBSD_HEAD-tests2 #854

2015-03-19 Thread Mateusz Guzik
() at Xfast_syscall+0xfb/frame 0xfe009749abf0 --- syscall (0, FreeBSD ELF64, nosys), rip = 0x8019c216a, rsp = 0x7fffc2d8, rbp = 0x7fffc340 --- KDB: enter: panic [ thread pid 660 tid 100065 ] Stopped at kdb_enter+0x3e: movq$0,kdb_why Weird, I'll look at that. -- Mateusz Guzik mjguzik

[PATCH 2/3] cred: add proc_set_cred_init helper

2015-03-20 Thread Mateusz Guzik
From: Mateusz Guzik m...@freebsd.org proc_set_cred_init can be used to set first credentials of a new process. Update proc_set_cred assertions so that it only expects already used processes. This fixes panics where p_ucred of a new process happens to be non-NULL. --- sys/kern/init_main.c | 2

[PATCH 3/3] proc: use MTX_NEW flag in proc_init

2015-03-20 Thread Mateusz Guzik
From: Mateusz Guzik m...@freebsd.org This allows us to get rid of bzero which was added specifically to make mtx_init on p_mtx reliable. This also fixes a potential problem where mtx_init on other mutexes could trip over on unitialized memory and fire an assertion. --- sys/kern/kern_proc.c | 11

[PATCH 1/3] fork: assign refed credentials earlier

2015-03-20 Thread Mateusz Guzik
From: Mateusz Guzik m...@freebsd.org Prior to this change the kernel would take p1's credentials and assign them tempororarily to p2. But p1 could change credentials at that time and in effect give us a use-after-free. --- sys/kern/kern_fork.c | 15 +++ 1 file changed, 7 insertions

Re: [PATCH 1/3] fork: assign refed credentials earlier

2015-03-20 Thread Mateusz Guzik
On Sat, Mar 21, 2015 at 03:51:51AM +0200, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 02:00:38AM +0100, Mateusz Guzik wrote: From: Mateusz Guzik m...@freebsd.org Prior to this change the kernel would take p1's credentials and assign them tempororarily to p2. But p1 could change

[PATCH 0/3] fix up some recent proc fallout and more

2015-03-20 Thread Mateusz Guzik
From: Mateusz Guzik m...@freebsd.org Patches in this series fix a bug introduced in r280130 and deal with additional issues. I'm not happy with how sutff is being done at the moment. In particular we zero out various fields on process exit, which puts it into a state state which

Re: [PATCH 1/3] fork: assign refed credentials earlier

2015-03-21 Thread Mateusz Guzik
On Sat, Mar 21, 2015 at 09:29:04PM +0200, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 07:19:31PM +0100, Mateusz Guzik wrote: On Sat, Mar 21, 2015 at 04:18:32PM +0200, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 02:57:22AM +0100, Mateusz Guzik wrote: On Sat, Mar 21, 2015

Re: Build failed in Jenkins: FreeBSD_HEAD-tests2 #862

2015-03-21 Thread Mateusz Guzik
() at Xfast_syscall+0xfb/frame 0xfe0097440bf0 --- syscall (0, FreeBSD ELF64, nosys), rip = 0x8019c516a, rsp = 0x7fffc2d8, rbp = 0x7fffc340 --- Should be fixed starting with https://svnweb.freebsd.org/changeset/base/280331 -- Mateusz Guzik mjguzik gmail.com

Re: [PATCH 1/3] fork: assign refed credentials earlier

2015-03-21 Thread Mateusz Guzik
On Sat, Mar 21, 2015 at 04:18:32PM +0200, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 02:57:22AM +0100, Mateusz Guzik wrote: On Sat, Mar 21, 2015 at 03:51:51AM +0200, Konstantin Belousov wrote: On Sat, Mar 21, 2015 at 02:00:38AM +0100, Mateusz Guzik wrote: From: Mateusz Guzik m

Re: Build failed in Jenkins: FreeBSD_HEAD-tests2 #854

2015-03-20 Thread Mateusz Guzik
On Fri, Mar 20, 2015 at 11:34:51AM +0200, Konstantin Belousov wrote: On Fri, Mar 20, 2015 at 03:20:26AM +0100, Mateusz Guzik wrote: On Fri, Mar 20, 2015 at 02:08:23AM +, jenkins-ad...@freebsd.org wrote: lib/libc/sys/setrlimit_test:setrlimit_nproc - maxproc limit exceeded by uid 977

Re: [PATCH] Convert the VFS cache lock to an rmlock

2015-03-12 Thread Mateusz Guzik
, but as it is I do not expect namecache lock contention to have significant impact on buildworld/kernel. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send

Re: [PATCH] Convert the VFS cache lock to an rmlock

2015-03-12 Thread Mateusz Guzik
run? I suggest you grab a machine from zoo[1] and run some tests on bigger hardware. A perf improvement, even slight, is definitely welcome. [1] https://wiki.freebsd.org/TestClusterOneReservations -- Mateusz Guzik mjguzik gmail.com ___ freebsd

Re: xargs -P0 suport

2015-05-22 Thread Mateusz Guzik
On Fri, May 22, 2015 at 01:43:21PM -0400, Nikolai Lifanov wrote: On 05/22/15 13:27, Mateusz Guzik wrote: On Fri, May 22, 2015 at 12:32:52PM -0400, Allan Jude wrote: There is some question about if nargs is a sane value for maxprocs in the negative case. 5000 does seem a bit high

Re: xargs -P0 suport

2015-05-22 Thread Mateusz Guzik
suggestions? GNU xargs imposes no limit whatsoever, but it also supports reallocating its process table, while our xargs allocates one upfront and does not change it. I would say reading hard proc resource limit and using that as the limit would do the job just fine. -- Mateusz Guzik mjguzik

Re: panic in sysctl code in recent head

2015-08-03 Thread Mateusz Guzik
you are seeing. What you can do is show your panic (at least the backtrace) and preferably narrow the problem down to the exact revision which introduced it. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http

Re: panic in sysctl code in recent head

2015-07-30 Thread Mateusz Guzik
in r286094. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: Instant panic while trying run ports-mgmt/poudriere

2015-08-06 Thread Mateusz Guzik
or guessing. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: null pointer dereference panic in cap_rights_contains() on 11.0-CURRENT r285785 amd64

2015-07-23 Thread Mateusz Guzik
a semaphore. */ -error = ksem_get(td, uap-id, 0, fp); +error = ksem_get(td, uap-id, cap_rights_init(rights), fp); if (error) return (error); ks = fp-f_data; Correct, please commit. -- Mateusz Guzik mjguzik gmail.com

Re: Instant panic while trying run ports-mgmt/poudriere

2015-07-13 Thread Mateusz Guzik
, if the problem is really that reproducible it would be best if you narrowed it down to the exact commit. However, quick look suggests you may be a victim of r284861. Can you enter kgdb and: f 26 p *list ? -- Mateusz Guzik mjguzik gmail.com

[PATCH] microoptimize by trying to avoid locking a locked mutex

2015-11-04 Thread Mateusz Guzik
\ + else\ + _mtx_lock_sleep((mp), _tid, (opts), (file), (line));\ } while (0) /* -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.free

Re: [PATCH] microoptimize by trying to avoid locking a locked mutex

2015-11-05 Thread Mateusz Guzik
On Thu, Nov 05, 2015 at 11:04:13AM -0800, John Baldwin wrote: > On Thursday, November 05, 2015 04:26:28 PM Konstantin Belousov wrote: > > On Thu, Nov 05, 2015 at 12:32:18AM +0100, Mateusz Guzik wrote: > > > mtx_lock will unconditionally try to grab the lock and if that fail

Re: [PATCH] microoptimize by trying to avoid locking a locked mutex

2015-11-05 Thread Mateusz Guzik
On Thu, Nov 05, 2015 at 04:35:22PM -0700, Ian Lepore wrote: > On Thu, 2015-11-05 at 14:19 -0800, John Baldwin wrote: > > On Thursday, November 05, 2015 01:45:19 PM Adrian Chadd wrote: > > > On 5 November 2015 at 11:26, Mateusz Guzik <mjgu...@gmail.com> > > > wr

Re: unp gc vs socket close/shutdown race

2015-07-08 Thread Mateusz Guzik
and will likely want a detailed review/rewrite at some point. Hopefully the patch is a sufficient band aid until such time comes. -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo

unp gc vs socket close/shutdown race

2015-07-07 Thread Mateusz Guzik
it. */ /* * These flags are used to handle non-atomicity in connect() and bind() -- Mateusz Guzik mjguzik gmail.com ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail

Re: unp gc vs socket close/shutdown race

2015-07-09 Thread Mateusz Guzik
On Wed, Jul 08, 2015 at 02:15:38AM +0200, Mateusz Guzik wrote: First off note the patch below is a total hack with the easiest solution possible so that it can be MFCed for 10.2. The issue: Closing the socket involves: if (pr-pr_flags PR_RIGHTS pr-pr_domain-dom_dispose != NULL

Re: r291494 PANIC mtx_lock() of spin mutex @ /usr/src/sys/kern/vfs_subr.c:512

2015-12-02 Thread Mateusz Guzik
gt; I could not find a reference to this panic. > please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204949 -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: panic "ffs_checkblk: bad block" on recent -head kernels

2015-12-03 Thread Mateusz Guzik
_vdrop(struct vnode *vp, bool locked) vp->v_op = NULL; #endif bzero(>v_un, sizeof(vp->v_un)); + vp->v_lasta = vp->v_clen = vp->v_cstart = vp->v_lastw = 0; vp->v_iflag = 0; vp->v_vflag = 0; bo->bo_flag = 0; -- Mateusz Gu

Re: panic "ffs_checkblk: bad block" on recent -head kernels

2015-12-03 Thread Mateusz Guzik
On Thu, Dec 03, 2015 at 03:07:48PM -0800, Kirk McKusick wrote: > > Date: Thu, 3 Dec 2015 23:47:52 +0100 > > From: Mateusz Guzik <mjgu...@gmail.com> > > To: Rick Macklem <rmack...@uoguelph.ca> > > Cc: FreeBSD Current <freebsd-current@freebsd.org> >

Re: fork_findpid() - Fatal trap 12: page fault while in kernel mode

2015-12-16 Thread Mateusz Guzik
t is copied on creation. */ #definep_endcopy p_xsig + struct pgrp *p_pgrp;/* (c + e) Pointer to process group. */ struct knlist p_klist;/* (c) Knotes attached to this proc. */ int p_numthreads; /* (c) Number of threads. */

Re: fork_findpid() - Fatal trap 12: page fault while in kernel mode

2015-12-18 Thread Mateusz Guzik
er the systems remain stable. > Thanks, fix committed in https://svnweb.freebsd.org/base?view=revision=292440 -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: fork_findpid() - Fatal trap 12: page fault while in kernel mode

2015-12-18 Thread Mateusz Guzik
On Thu, Dec 17, 2015 at 02:33:46PM -0800, Don Lewis wrote: > On 17 Dec, Mateusz Guzik wrote: > > On Thu, Dec 17, 2015 at 11:48:08AM -0800, Don Lewis wrote: > >> On 17 Dec, Konstantin Belousov wrote: > >> > On Wed, Dec 16, 2015 at 11:08:02AM -0800, Don Lewis wrote:

Re: fork_findpid() - Fatal trap 12: page fault while in kernel mode

2015-12-18 Thread Mateusz Guzik
On Fri, Dec 18, 2015 at 09:44:10AM -0800, Don Lewis wrote: > On 18 Dec, Mateusz Guzik wrote: > > On Thu, Dec 17, 2015 at 02:33:46PM -0800, Don Lewis wrote: > >> On 17 Dec, Mateusz Guzik wrote: > >> > On Thu, Dec 17, 2015 at 11:48:08AM -0800, Don Lewis wrote: > >

Re: fork_findpid() - Fatal trap 12: page fault while in kernel mode

2015-12-17 Thread Mateusz Guzik
PRS_NEW state and poisoned pointers in debug kernels to help ensuring that all loops handle the case. Not signing up for any of this work though. -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

[PATCH] microoptimize locking primitives by avoiding unnecessary atomic ops

2016-05-27 Thread Mateusz Guzik
Hello there, quite some time ago I posted a trivial patch to locking primitives. What they do is the inline part tries an atomic op and if that fails the actual function is called, which immediately tries the same op. The obvious optimisation checks for the availability of the lock first. There

Re: [PATCH] microoptimize locking primitives by avoiding unnecessary atomic ops

2016-06-01 Thread Mateusz Guzik
On Fri, May 27, 2016 at 04:21:11PM -0700, John Baldwin wrote: > On Friday, May 27, 2016 09:17:01 PM Mateusz Guzik wrote: > > Hello there, > > > > quite some time ago I posted a trivial patch to locking primitives. What > > they do is the inline part tries an

Re: [PATCH] randomized delay in locking primitives, take 2

2016-08-01 Thread Mateusz Guzik
ere. > The patch is the simplest hack possible so that this has a chance of getting into 11.0 as it helps /a lot/ even in the simplest form. Revamping this stuff in a more "here to stay" manner is a much longer endeavor. -- Mateusz Guzik ___ free

Re: [PATCH] randomized delay in locking primitives, take 2

2016-08-01 Thread Mateusz Guzik
On Mon, Aug 01, 2016 at 09:38:09AM -0700, Maxim Sobolev wrote: > On Sun, Jul 31, 2016 at 1:36 PM, Mateusz Guzik <mjgu...@gmail.com> wrote: > > > On Sun, Jul 31, 2016 at 07:03:08AM -0700, Adrian Chadd wrote: > > > Hi, > > > > > > Did you tes

[PATCH] randomized delay in locking primitives, take 2

2016-07-31 Thread Mateusz Guzik
The patch can be found inline below and also here: https://people.freebsd.org/~mjg/lock_backoff_complete.diff The previous version of the patch was posted here: https://lists.freebsd.org/pipermail/freebsd-current/2016-July/062320.html This time around instead of a total hack I have something of

Re: [PATCH] randomized delay in locking primitives, take 2

2016-07-31 Thread Mateusz Guzik
On Sun, Jul 31, 2016 at 01:49:28PM +0300, Konstantin Belousov wrote: [snip] After an irc discussion, the following was produced (also available at: https://people.freebsd.org/~mjg/lock_backoff_complete4.diff): Differences: - uint64_t usage was converted to u_int (also see r303584) - currently

Re: [PATCH] randomized delay in locking primitives, take 2

2016-07-31 Thread Mateusz Guzik
% operation acts a randomizer. It is optional and I'm happy to ifdef it based on the architecture. It does seem to be useful at least on amd64. As a side note, exponential backoff is not used to keep things smaller (see above). It is definitely subject to ch

Re: [PATCH] randomized delay in locking primitives, take 2

2016-08-01 Thread Mateusz Guzik
On Mon, Aug 01, 2016 at 11:37:50AM -0700, John Baldwin wrote: > On Sunday, July 31, 2016 02:41:13 PM Mateusz Guzik wrote: > > On Sun, Jul 31, 2016 at 01:49:28PM +0300, Konstantin Belousov wrote: > > [snip] > > > > After an irc discussion, the following was produced (a

Re: [PATCH] microoptimize locking primitives by introducing randomized delay between atomic ops

2016-07-16 Thread Mateusz Guzik
On Sun, Jul 10, 2016 at 08:32:01AM -0600, Ian Lepore wrote: > On Sun, 2016-07-10 at 13:13 +0200, Mateusz Guzik wrote: > > If the lock is contended, primitives like __mtx_lock_sleep will spin > > checking if the owner is running or the lock was freed. The problem >

[PATCH] microoptimize locking primitives by introducing randomized delay between atomic ops

2016-07-10 Thread Mateusz Guzik
If the lock is contended, primitives like __mtx_lock_sleep will spin checking if the owner is running or the lock was freed. The problem is that once it is discovered that the lock is free, multiple CPUs are likely to try to do the atomic op which will make it more costly for everyone and

Re: [PATCH] microoptimize locking primitives by introducing randomized delay between atomic ops

2016-07-10 Thread Mateusz Guzik
On Sun, Jul 10, 2016 at 03:22:47PM +0300, Konstantin Belousov wrote: > On Sun, Jul 10, 2016 at 01:13:26PM +0200, Mateusz Guzik wrote: > > If the lock is contended, primitives like __mtx_lock_sleep will spin > > checking if the owner is running or the lock was freed. The problem i

Re: SVN r303643 breaks non-SMP compilation

2016-08-01 Thread Mateusz Guzik
or reporting. -- Mateusz Guzik ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: r312602: panic: Panic String: __lockmgr_args: unknown lockmgr request 0x0

2017-01-21 Thread Mateusz Guzik
On Sat, Jan 21, 2017 at 08:45:55PM +0100, O. Hartmann wrote: > The most recent CURRENT panics spontanously and crashes with the error > message: > > > Panic String: __lockmgr_args: unknown lockmgr request 0x0 > That's a braino in r312600, will be fixed shortly.

  1   2   >