Re: Bug in /usr/src/sys/sys/sf_buf.h?
On Fri, 19 Jan 2018 13:17:38 -0800 Nathan Whitehorn wrote: > This is my fault. Apologies. I will fix it immediately. > -Nathan > Revision 328179, fix confirmed. Thanks. Milan > On 01/19/18 13:16, Milan Obuch wrote: > > Hi, > > > > after updating to revision 328171, building 12-CURRENT kernel gives > > > > cc -target armv7-gnueabihf-freebsd12.0 > > --sysroot=/usr/obj/usr/src/arm.armv7/tmp > > -B/usr/obj/usr/src/arm.armv7/tmp/usr/bin -c -O -pipe -g -nostdinc > > -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt > > -I/usr/src/sys/gnu/dts/include -D_KERNEL > > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -march=armv7a > > -funwind-tables -MD -MF.depend.md.o -MTmd.o -ffreestanding -fwrapv > > -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs > > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > > -Wcast-qual -Wundef -Wno-pointer-sign > > -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs > > -fdiagnostics-show-option -Wno-unknown-pragmas > > -Wno-error-tautological-compare -Wno-error-empty-body > > -Wno-error-parentheses-equality -Wno-error-unused-function > > -Wno-error-pointer-sign -Wno-error-shift-negative-value > > -Wno-error-address-of-packed-member -mfpu=none -std=iso9899:1999 > > -Werror /usr/src/sys/dev/md/md.c > > > > In file included from /usr/src/sys/dev/md/md.c:90: > > > > /usr/src/sys/sys/sf_buf.h:120:11: error: implicit declaration of > > function 'PHYS_TO_DMAP' is invalid in C99 > > [-Werror,-Wimplicit-function-declaration] > > > > return (PHYS_TO_DMAP(VM_PAGE_TO_PHYS((vm_page_t)sf))); > > > > ^ > > > > /usr/src/sys/sys/sf_buf.h:120:11: error: this function declaration > > is not a prototype [-Werror,-Wstrict-prototypes] > > > > 2 errors generated. > > > > Did a bug slipped in or am I doing something wrong? With revision > > 328159 nothing like this happened, and I see in svn update output > > file /sys/sys/sf_buf.h being updated whne updating sources to > > revision 328171. > > > > Regards, > > Milan > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: Bug in /usr/src/sys/sys/sf_buf.h?
This is my fault. Apologies. I will fix it immediately. -Nathan On 01/19/18 13:16, Milan Obuch wrote: Hi, after updating to revision 328171, building 12-CURRENT kernel gives cc -target armv7-gnueabihf-freebsd12.0 --sysroot=/usr/obj/usr/src/arm.armv7/tmp -B/usr/obj/usr/src/arm.armv7/tmp/usr/bin -c -O -pipe -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -I/usr/src/sys/gnu/dts/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -march=armv7a -funwind-tables -MD -MF.depend.md.o -MTmd.o -ffreestanding -fwrapv -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mfpu=none -std=iso9899:1999 -Werror /usr/src/sys/dev/md/md.c In file included from /usr/src/sys/dev/md/md.c:90: /usr/src/sys/sys/sf_buf.h:120:11: error: implicit declaration of function 'PHYS_TO_DMAP' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return (PHYS_TO_DMAP(VM_PAGE_TO_PHYS((vm_page_t)sf))); ^ /usr/src/sys/sys/sf_buf.h:120:11: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 2 errors generated. Did a bug slipped in or am I doing something wrong? With revision 328159 nothing like this happened, and I see in svn update output file /sys/sys/sf_buf.h being updated whne updating sources to revision 328171. Regards, Milan ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Bug in /usr/src/sys/sys/sf_buf.h?
Hi, after updating to revision 328171, building 12-CURRENT kernel gives cc -target armv7-gnueabihf-freebsd12.0 --sysroot=/usr/obj/usr/src/arm.armv7/tmp -B/usr/obj/usr/src/arm.armv7/tmp/usr/bin -c -O -pipe -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -I/usr/src/sys/gnu/dts/include -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -march=armv7a -funwind-tables -MD -MF.depend.md.o -MTmd.o -ffreestanding -fwrapv -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mfpu=none -std=iso9899:1999 -Werror /usr/src/sys/dev/md/md.c In file included from /usr/src/sys/dev/md/md.c:90: /usr/src/sys/sys/sf_buf.h:120:11: error: implicit declaration of function 'PHYS_TO_DMAP' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return (PHYS_TO_DMAP(VM_PAGE_TO_PHYS((vm_page_t)sf))); ^ /usr/src/sys/sys/sf_buf.h:120:11: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 2 errors generated. Did a bug slipped in or am I doing something wrong? With revision 328159 nothing like this happened, and I see in svn update output file /sys/sys/sf_buf.h being updated whne updating sources to revision 328171. Regards, Milan ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
