Re: Failing buildword due to execution permission (with fix)

[NGie Cooper]

> On Nov 9, 2015, at 13:35, José Pérez  wrote:
> 
> Hello,
> I have this buildwordl failure:
> 
> ===> libexec/rbootd (depend)
> --- depend_subdir_lib ---
> --- aton_ether_subr.c ---
> /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr 
> /usr/src/sys/net/if_ethersubr.c ato
> n_ether_subr.c
> sh: /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr: Permission 
> denied
> *** [aton_ether_subr.c] Error code 126
> 
> 
> I fixed with:
> chmod +x /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr
> 
> 
> This was from a fresh checkout of current on a new machine.
> 
> Is it me or shall I report a bug?

Hi José,
I’ve fixed the issue in r291172 (and no it wasn’t just you — I ran into 
the same problem from my git checkout later on, which was kind of interesting).
Thanks!
-NGie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Failing buildword due to execution permission (with fix)

[José Pérez]

Hello,
I have this buildwordl failure:

===> libexec/rbootd (depend)
--- depend_subdir_lib ---
--- aton_ether_subr.c ---
/usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr 
/usr/src/sys/net/if_ethersubr.c ato

n_ether_subr.c
sh: /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr: 
Permission denied

*** [aton_ether_subr.c] Error code 126


I fixed with:
chmod +x /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr


This was from a fresh checkout of current on a new machine.

Is it me or shall I report a bug?

Regards,

--
José Pérez
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Failing buildword due to execution permission (with fix)

[Bryan Drewery]

On 11/9/2015 6:01 PM, Garrett Cooper wrote:
> 
>> On Nov 9, 2015, at 17:27, Bryan Drewery  wrote:
>>
>>> On 11/9/2015 5:17 PM, Garrett Cooper wrote:
>>>
 On Nov 9, 2015, at 16:13, Bryan Drewery  wrote:
>>>
>>>
>>> ...
>>>
 If this is a shell file then it is best to invoke it with 'sh' rather
 than a chmod/#!. The src checkout should be noexec-safe.
>>>
>>> Right. I think it'd be a good idea for me to hunt down other issues though 
>>> in the build by setting -o noexec.
>>>
>>>
>>> The only thing that concerns me with doing that is that it could result in 
>>> weirdness, e.g. The osreldate.h generation script in include/ .
>>
>> It prepends 'sh'.
>>
>> include/Makefile:MK_OSRELDATE_SH=   ${.CURDIR}/mk-osreldate.sh
>> include/Makefile:   sh ${MK_OSRELDATE_SH}
> 
> Yeah... I forgot.
> 
> I wrote up that patch at iX, and it was iterated over a bit. I was just 
> remembering what happens when you use ${SHELL} (hint: no bueno if your build 
> is kicked off with a csh/non-POSIX sh..).
> 

I actually wrote up a patch recently to use ${SH} in all places of 'sh'
and '/bin/sh', and noted on SHELL?= that was not useful to use, but did
not commit it (yet).


-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: Failing buildword due to execution permission (with fix)

[Garrett Cooper]

> On Nov 9, 2015, at 17:27, Bryan Drewery  wrote:
> 
>> On 11/9/2015 5:17 PM, Garrett Cooper wrote:
>> 
>>> On Nov 9, 2015, at 16:13, Bryan Drewery  wrote:
>> 
>> 
>> ...
>> 
>>> If this is a shell file then it is best to invoke it with 'sh' rather
>>> than a chmod/#!. The src checkout should be noexec-safe.
>> 
>> Right. I think it'd be a good idea for me to hunt down other issues though 
>> in the build by setting -o noexec.
>> 
>> 
>> The only thing that concerns me with doing that is that it could result in 
>> weirdness, e.g. The osreldate.h generation script in include/ .
> 
> It prepends 'sh'.
> 
> include/Makefile:MK_OSRELDATE_SH=   ${.CURDIR}/mk-osreldate.sh
> include/Makefile:   sh ${MK_OSRELDATE_SH}

Yeah... I forgot.

I wrote up that patch at iX, and it was iterated over a bit. I was just 
remembering what happens when you use ${SHELL} (hint: no bueno if your build is 
kicked off with a csh/non-POSIX sh..).

I'll do that soon-ish.

Thanks!
-NGie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Failing buildword due to execution permission (with fix)

[Simon J. Gerraty]

> >> include/Makefile:MK_OSRELDATE_SH=   ${.CURDIR}/mk-osreldate.sh
> >> include/Makefile:   sh ${MK_OSRELDATE_SH}
> 
> I actually wrote up a patch recently to use ${SH} in all places of 'sh'
> and '/bin/sh', and noted on SHELL?= that was not useful to use, but did
> not commit it (yet).

We (junos) use HOST_SH I think for this, since if building on a non-native
host, /bin/sh cannot be relied on.
FreeBSD sys.mk already has

__MAKE_SHELL?=/bin/sh

so I guess you could use that.
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Failing buildword due to execution permission (with fix)

[Garrett Cooper]

> On Nov 9, 2015, at 13:35, José Pérez  wrote:
> 
> Hello,
> I have this buildwordl failure:
> 
> ===> libexec/rbootd (depend)
> --- depend_subdir_lib ---
> --- aton_ether_subr.c ---
> /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr 
> /usr/src/sys/net/if_ethersubr.c ato
> n_ether_subr.c
> sh: /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr: Permission 
> denied
> *** [aton_ether_subr.c] Error code 126
> 
> 
> I fixed with:
> chmod +x /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr
> 
> 
> This was from a fresh checkout of current on a new machine.
> 
> Is it me or shall I report a bug?

Please file a bug and assign it to me (ngie). Is the file system mounted with 
noexec?
Thanks,
-NGie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Failing buildword due to execution permission (with fix)

[Bryan Drewery]

On 11/9/2015 2:42 PM, Garrett Cooper wrote:
> 
>> On Nov 9, 2015, at 13:35, José Pérez  wrote:
>>
>> Hello,
>> I have this buildwordl failure:
>>
>> ===> libexec/rbootd (depend)
>> --- depend_subdir_lib ---
>> --- aton_ether_subr.c ---
>> /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr 
>> /usr/src/sys/net/if_ethersubr.c ato
>> n_ether_subr.c
>> sh: /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr: Permission 
>> denied
>> *** [aton_ether_subr.c] Error code 126
>>
>>
>> I fixed with:
>> chmod +x /usr/src/contrib/netbsd-tests/lib/libc/net/gen_ether_subr
>>
>>
>> This was from a fresh checkout of current on a new machine.
>>
>> Is it me or shall I report a bug?
> 
> Please file a bug and assign it to me (ngie). Is the file system mounted with 
> noexec?
> Thanks,
> -NGie

If this is a shell file then it is best to invoke it with 'sh' rather
than a chmod/#!. The src checkout should be noexec-safe.


-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature

Re: Failing buildword due to execution permission (with fix)

[Garrett Cooper]

> On Nov 9, 2015, at 16:13, Bryan Drewery  wrote:


...

> If this is a shell file then it is best to invoke it with 'sh' rather
> than a chmod/#!. The src checkout should be noexec-safe.

Right. I think it'd be a good idea for me to hunt down other issues though in 
the build by setting -o noexec.


The only thing that concerns me with doing that is that it could result in 
weirdness, e.g. The osreldate.h generation script in include/ .

Thanks!
-NGie
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Failing buildword due to execution permission (with fix)

[Bryan Drewery]

On 11/9/2015 5:17 PM, Garrett Cooper wrote:
> 
>> On Nov 9, 2015, at 16:13, Bryan Drewery  wrote:
> 
> 
> ...
> 
>> If this is a shell file then it is best to invoke it with 'sh' rather
>> than a chmod/#!. The src checkout should be noexec-safe.
> 
> Right. I think it'd be a good idea for me to hunt down other issues though in 
> the build by setting -o noexec.
> 
> 
> The only thing that concerns me with doing that is that it could result in 
> weirdness, e.g. The osreldate.h generation script in include/ .
> 

It prepends 'sh'.

include/Makefile:MK_OSRELDATE_SH=   ${.CURDIR}/mk-osreldate.sh
include/Makefile:   sh ${MK_OSRELDATE_SH}

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature