Re: Feature test for OpenSSL + RSA

2000-01-18 Thread Kris Kennaway

On Tue, 18 Jan 2000, Peter Wemm wrote:

> Yes, This should most definately have ${DESTDIR} for this sort of thing, but
> even then I'm not sure this is a good change..  We have got to find a better
> way than this.

I've said this a couple of times in private, but will repeat it again for
the list: we could do something like `nm /usr/lib/libcrypto.so | grep
RSA_free`, but this seemed ugly and non-obvious to me (e.g. if someone who
is not bsd.port.mk wanted to check whether their openssl port was
RSA-enabled). It also seems to get invoked about 20 times during the
course of making an openssl-using port (at least, that's how many times
my debugging echos get run :)

Kris


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-18 Thread Kris Kennaway

On Tue, 18 Jan 2000, Sheldon Hearn wrote:

> On Mon, 17 Jan 2000 21:53:10 PST, Kris Kennaway wrote:
> 
> > +.if defined(WITH_RSA) && ${WITH_RSA} == YES
> > +   /usr/bin/touch /etc/ssl/openssl_hasrsa
> 
> Um, are you sure you want that hard path, /etc/ssl ?  Shouldn't there be
> a ${DESTDIR} in there?  What do you need this for?

Yep, I realised this when I was falling asleep last night. Thanks :)

Kris


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-18 Thread Peter Wemm

Sheldon Hearn wrote:
> 
> 
> On Mon, 17 Jan 2000 21:53:10 PST, Kris Kennaway wrote:
> 
> > +.if defined(WITH_RSA) && ${WITH_RSA} == YES
> > +   /usr/bin/touch /etc/ssl/openssl_hasrsa
> 
> Um, are you sure you want that hard path, /etc/ssl ?  Shouldn't there be
> a ${DESTDIR} in there?  What do you need this for?

Yes, This should most definately have ${DESTDIR} for this sort of thing, but
even then I'm not sure this is a good change..  We have got to find a better
way than this.

Cheers,
-Peter



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-18 Thread Sheldon Hearn



On Mon, 17 Jan 2000 21:53:10 PST, Kris Kennaway wrote:

> +.if defined(WITH_RSA) && ${WITH_RSA} == YES
> + /usr/bin/touch /etc/ssl/openssl_hasrsa

Um, are you sure you want that hard path, /etc/ssl ?  Shouldn't there be
a ${DESTDIR} in there?  What do you need this for?

Ciao,
Sheldon.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-18 Thread jack

On Jan 17 Kris Kennaway wrote:

> On Tue, 18 Jan 2000, jack wrote:
> 
> > On Jan 17 Kris Kennaway wrote:
> > 
> > > > +   rm -f /etc/ssl/openssl_hasrsa
> > > 
> > > Doh, I meant /bin/rm
> > 
> > No, you meant ${RM}
> 
> I couldn't find this defined in /usr/share/mk/* - it's only in
> bsd.port.mk, AFAICT.

Ummm, yeah.  Sorry, I had ports on the brain since that's where
I keep getting bit by all this lately.

--
Jack O'NeillSystems Administrator / Systems Analyst
[EMAIL PROTECTED] Crystal Wind Communications, Inc.
  Finger [EMAIL PROTECTED] for my PGP key.
   PGP Key fingerprint = F6 C4 E6 D4 2F 15 A7 67   FD 09 E9 3C 5F CC EB CD
   enriched, vcard, HTML messages > /dev/null
--




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread Chuck Robey

On Mon, 17 Jan 2000, Kris Kennaway wrote:

> On Tue, 18 Jan 2000, Chuck Robey wrote:
> 
> > > > No, you meant ${RM}
> > > 
> > > I couldn't find this defined in /usr/share/mk/* - it's only in
> > > bsd.port.mk, AFAICT.
> > 
> > I'm note sure mine's up to date, where the definition is on line 876 of
> > bsd.port.mk ... but I'm *sure* it's in there, it has been for ages!
> 
> Reread the above. I know it's in bsd.port.mk, but that doesn't help me
> when I'm building in /usr/src/secure/lib/libcrypto ;-)

Oops.  Damn.

> 
> Kris
> 
> 
> "How many roads must a man walk down, before you call him a man?"
> "Eight!"
> "That was a rhetorical question!"
> "Oh..then, seven!" -- Homer Simpson
> 
> 


Chuck Robey| Interests include C & Java programming,
New Year's Resolution:  I  | electronics, communications, and
will not sphroxify gullible| signal processing.
people into looking up | I run picnic.mat.net: FreeBSD-current(i386) and
fictitious words in the|  jaunt.mat.net : FreeBSD-current(Alpha)|
dictionary.|




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread Kris Kennaway

On Tue, 18 Jan 2000, Chuck Robey wrote:

> > > No, you meant ${RM}
> > 
> > I couldn't find this defined in /usr/share/mk/* - it's only in
> > bsd.port.mk, AFAICT.
> 
> I'm note sure mine's up to date, where the definition is on line 876 of
> bsd.port.mk ... but I'm *sure* it's in there, it has been for ages!

Reread the above. I know it's in bsd.port.mk, but that doesn't help me
when I'm building in /usr/src/secure/lib/libcrypto ;-)

Kris


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread Chuck Robey

On Mon, 17 Jan 2000, Kris Kennaway wrote:

> > No, you meant ${RM}
> 
> I couldn't find this defined in /usr/share/mk/* - it's only in
> bsd.port.mk, AFAICT.

I'm note sure mine's up to date, where the definition is on line 876 of
bsd.port.mk ... but I'm *sure* it's in there, it has been for ages!

> 
> Kris
> 
> 
> "How many roads must a man walk down, before you call him a man?"
> "Eight!"
> "That was a rhetorical question!"
> "Oh..then, seven!" -- Homer Simpson
> 
> 
> 
> To Unsubscribe: send mail to [EMAIL PROTECTED]
> with "unsubscribe freebsd-current" in the body of the message
> 


Chuck Robey| Interests include C & Java programming,
New Year's Resolution:  I  | electronics, communications, and
will not sphroxify gullible| signal processing.
people into looking up | I run picnic.mat.net: FreeBSD-current(i386) and
fictitious words in the|  jaunt.mat.net : FreeBSD-current(Alpha)|
dictionary.|




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread Kris Kennaway

On Tue, 18 Jan 2000, jack wrote:

> On Jan 17 Kris Kennaway wrote:
> 
> > > + rm -f /etc/ssl/openssl_hasrsa
> > 
> > Doh, I meant /bin/rm
> 
> No, you meant ${RM}

I couldn't find this defined in /usr/share/mk/* - it's only in
bsd.port.mk, AFAICT.

Kris


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread jack

On Jan 17 Kris Kennaway wrote:

> > +   rm -f /etc/ssl/openssl_hasrsa
> 
> Doh, I meant /bin/rm

No, you meant ${RM}

--
Jack O'NeillSystems Administrator / Systems Analyst
[EMAIL PROTECTED] Crystal Wind Communications, Inc.
  Finger [EMAIL PROTECTED] for my PGP key.
   PGP Key fingerprint = F6 C4 E6 D4 2F 15 A7 67   FD 09 E9 3C 5F CC EB CD
   enriched, vcard, HTML messages > /dev/null
--





To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: Feature test for OpenSSL + RSA

2000-01-17 Thread Kris Kennaway

On Mon, 17 Jan 2000, Kris Kennaway wrote:

> + rm -f /etc/ssl/openssl_hasrsa

Doh, I meant /bin/rm

Kris


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Feature test for OpenSSL + RSA

2000-01-17 Thread Kris Kennaway

The simplest way to test whether OpenSSL can do RSA is to write a file at
install-time, like the following patch. Any objections?

Kris

Index: Makefile
===
RCS file: /home/ncvs/src/secure/lib/libcrypto/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile2000/01/16 05:23:21 1.5
+++ Makefile2000/01/18 05:50:34
@@ -206,7 +206,13 @@
${LCRYPTO_SRC}/$$i ${DESTDIR}/usr/include/openssl; \
done; \
${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m 444 \
-   ${.OBJDIR}/openssl/opensslconf.h ${DESTDIR}/usr/include/openssl
+   ${.OBJDIR}/openssl/opensslconf.h \
+   ${DESTDIR}/usr/include/openssl
+.if defined(WITH_RSA) && ${WITH_RSA} == YES
+   /usr/bin/touch /etc/ssl/openssl_hasrsa
+.else
+   rm -f /etc/ssl/openssl_hasrsa
+.endif
 
 .PATH: ${LCRYPTO_SRC} ${LCRYPTO_SRC}/asn1 ${LCRYPTO_SRC}/bf \
${LCRYPTO_SRC}/bio ${LCRYPTO_SRC}/bn ${LCRYPTO_SRC}/buffer \


"How many roads must a man walk down, before you call him a man?"
"Eight!"
"That was a rhetorical question!"
"Oh..then, seven!" -- Homer Simpson



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message