Re: Labeling Vinum partitions in the sysinstall(8) [patch]
Maxim Sobolev wrote: John Baldwin wrote: On 02-Mar-01 Maxim Sobolev wrote: Hi folks, I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which would simplify Vinum configuration procedure for the vinum newbies. So far I finished a patch that allows create vinum partitions using sysinstall's disklabel editor and would like to commit it. Please review attached patches. Heh, I wrote http://www.FreeBSD.org/~jhb/patches/sysinstall.vinum.patch probably a year ago now, but because it only changes the disklabel editor and doesn't add a full vinum configurator the patch was rejected. :-/ Hopefully you will have better luck than I did... I hope so, because it greatly simplifies the task even without a full vinum configurator (as I said I'm working on it as well). Yeah, I know that disklabel(8) is cool, but it is not very intuitive and easy to use tool, especially for GUI-pampered win32 converts. So, we're impatiently awaiting your nice GUI-ish vinum configurator in Tcl/Tk, Python, Ruby, Perl, Java, or whatever. ;^) -- "Where am I, and what am I doing in this handbasket?" Wes Peters Softweyr LLC [EMAIL PROTECTED] http://softweyr.com/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Labeling Vinum partitions in the sysinstall(8) [patch]
ccd anybody? AFAIK, unlike vinum, ccd doesn't require any special disk labeling. Sorry, I should have been clearer. If I got it right, you're working not only on disk labeling for vinum, but on a complete frontend. If that is true, I think we (yes I am volunteering, in case nobody else will - but I might need help) should look into it and see how hard it might be to turn the non-disklabel part into also a ccdconfig frontend. I think what I'm trying to achieve is quite clear. It's currently very hard to install a system with say a mirrored /usr; you need to do a lot of post-install games. Having done that a lot of times in last year, I would love to have the option to ccdconfig partitions in sysinstall, and install on them. Bye, Andrea -- ...and that is how we know the Earth to be banana-shaped. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Labeling Vinum partitions in the sysinstall(8) [patch]
Hi folks,
I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which
would simplify Vinum configuration procedure for the vinum newbies. So far I
finished a patch that allows create vinum partitions using sysinstall's
disklabel editor and would like to commit it. Please review attached patches.
Thanks!
-Maxim
Index: label.c
===
RCS file: /home/ncvs/src/usr.sbin/sysinstall/label.c,v
retrieving revision 1.102
diff -d -u -r1.102 label.c
--- label.c 2001/02/07 11:26:41 1.102
+++ label.c 2001/03/02 14:12:59
@@ -277,6 +277,8 @@
if (c2-type == part) {
if (c2-subtype == FS_SWAP)
label_chunk_info[j].type = PART_SWAP;
+ else if (c2-subtype == FS_VINUM)
+ label_chunk_info[j].type = PART_VINUM;
else
label_chunk_info[j].type = PART_FILESYSTEM;
label_chunk_info[j].c = c2;
@@ -383,19 +385,24 @@
"A file system",
"Swap",
"A swap partition.",
+ "Vinum",
+ "A vinum subdisk."
};
WINDOW *w = savescr();
i = dialog_menu("Please choose a partition type",
"If you want to use this partition for swap space, select Swap.\n"
- "If you want to put a filesystem on it, choose FS.",
- -1, -1, 2, 2, fs_types, selection, NULL, NULL);
+ "If you want to put a filesystem on it, choose FS.\n"
+ "If you want to use it as a subdisk in a Vinum plex, choose
+Vinum.",
+ -1, -1, 3, 3, fs_types, selection, NULL, NULL);
restorescr(w);
if (!i) {
if (!strcmp(selection, "FS"))
return PART_FILESYSTEM;
else if (!strcmp(selection, "Swap"))
return PART_SWAP;
+ else if (!strcmp(selection, "Vinum"))
+ return PART_VINUM;
}
return PART_NONE;
}
@@ -571,6 +578,8 @@
mountpoint = ((PartInfo
*)label_chunk_info[i].c-private_data)-mountpoint;
else if (label_chunk_info[i].type == PART_SWAP)
mountpoint = "swap";
+ else if (label_chunk_info[i].type == PART_VINUM)
+ mountpoint = "vinum";
else
mountpoint = "none";
@@ -581,6 +590,8 @@
newfs = ((PartInfo *)label_chunk_info[i].c-private_data)-newfs ?
"UFS Y" : "UFS N";
else if (label_chunk_info[i].type == PART_SWAP)
newfs = "SWAP";
+ else if (label_chunk_info[i].type == PART_VINUM)
+ newfs = "VINUM";
else
newfs = "*";
for (j = 0; j MAX_MOUNT_NAME mountpoint[j]; j++)
@@ -895,6 +906,7 @@
else {
char *val;
int size;
+ int subtype;
struct chunk *tmp;
char osize[80];
u_long flags = 0;
@@ -959,17 +971,26 @@
"partitions should usually be at least %dMB in
size", ROOT_MIN_SIZE);
}
}
+ switch (type) {
+ case PART_SWAP:
+ subtype = FS_SWAP;
+ break;
+ case PART_VINUM:
+ subtype = FS_VINUM;
+ break;
+ default:
+ subtype = FS_BSDFFS;
+ break;
+ }
tmp = Create_Chunk_DWIM(label_chunk_info[here].c-disk,
label_chunk_info[here].c,
- size, part,
- (type == PART_SWAP) ? FS_SWAP : FS_BSDFFS,
- flags);
+ size, part, subtype, flags);
if (!tmp) {
msgConfirm("Unable to create the partition. Too big?");
clear_wins();
break;
}
- if (type != PART_SWAP) {
+ if (type != PART_SWAP type != PART_VINUM) {
/* This is needed to tell the newfs -u about the size */
tmp-private_data = new_part(p-mountpoint, p-newfs, tmp-size);
safe_free(p);
@@ -1021,6 +1042,10 @@
case PART_SWAP:
msg = "You don't need to specify a mountpoint for a swap partition.";
+ break;
+
+ case PART_VINUM:
+ msg = "You don't need to specify a mountpoint for a vinum subdisk.";
break;
case PART_FAT:
Index: sysinstall.h
===
RCS file: /home/ncvs/src/usr.sbin/sysinstall/sysinstall.h,v
retrieving revision 1.202
diff -d -u -r1.202 sysinstall.h
--- sysinstall.h
Re: Labeling Vinum partitions in the sysinstall(8) [patch]
I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which would simplify Vinum configuration procedure for the vinum newbies. So far I finished a patch that allows create vinum partitions using sysinstall's disklabel editor and would like to commit it. Please review attached patches. ccd anybody? Bye, Andrea -- Where do you think you're going today? To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Labeling Vinum partitions in the sysinstall(8) [patch]
Andrea Campi wrote: I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which would simplify Vinum configuration procedure for the vinum newbies. So far I finished a patch that allows create vinum partitions using sysinstall's disklabel editor and would like to commit it. Please review attached patches. ccd anybody? AFAIK, unlike vinum, ccd doesn't require any special disk labeling. -Maxim To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
RE: Labeling Vinum partitions in the sysinstall(8) [patch]
On 02-Mar-01 Maxim Sobolev wrote: Hi folks, I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which would simplify Vinum configuration procedure for the vinum newbies. So far I finished a patch that allows create vinum partitions using sysinstall's disklabel editor and would like to commit it. Please review attached patches. Heh, I wrote http://www.FreeBSD.org/~jhb/patches/sysinstall.vinum.patch probably a year ago now, but because it only changes the disklabel editor and doesn't add a full vinum configurator the patch was rejected. :-/ Hopefully you will have better luck than I did... Thanks! -Maxim -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Labeling Vinum partitions in the sysinstall(8) [patch]
John Baldwin wrote: On 02-Mar-01 Maxim Sobolev wrote: Hi folks, I'm currently creating a Vinum(4) configuration wizard for sysinstall(8), which would simplify Vinum configuration procedure for the vinum newbies. So far I finished a patch that allows create vinum partitions using sysinstall's disklabel editor and would like to commit it. Please review attached patches. Heh, I wrote http://www.FreeBSD.org/~jhb/patches/sysinstall.vinum.patch probably a year ago now, but because it only changes the disklabel editor and doesn't add a full vinum configurator the patch was rejected. :-/ Hopefully you will have better luck than I did... I hope so, because it greatly simplifies the task even without a full vinum configurator (as I said I'm working on it as well). Yeah, I know that disklabel(8) is cool, but it is not very intuitive and easy to use tool, especially for GUI-pampered win32 converts. -Maxim To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
RE: Labeling Vinum partitions in the sysinstall(8) [patch]
From: John Baldwin [EMAIL PROTECTED] Subject: RE: Labeling Vinum partitions in the sysinstall(8) [patch] Date: Fri, 02 Mar 2001 09:28:31 -0800 (PST) Heh, I wrote http://www.FreeBSD.org/~jhb/patches/sysinstall.vinum.patch probably a year ago now, but because it only changes the disklabel editor and doesn't add a full vinum configurator the patch was rejected. :-/ Hopefully you will have better luck than I did... Well, I'm not sure it was "rejected" so much as "sent back with a set of requests attached." The problem here is that vinum is currently a feature which isn't "exposed" to the general public - you need to be someone who's interested in tracking down the details and doing some reading before you can create a vinum-based filesystem. That's good in this particular case because vinum is hardly a trivial piece of work and you'd better read up on it before using it or you're probably going to end up doing nasty things to your system. This is not to say that vinum wouldn't substantially benefit from a lot of front-end work which removes a lot of the confusion and hair from the process, indeed I think that would make vinum a lot more popular and useful, but all the Baldwin/Sobolev patches do is essentially draw an arrow which leads over the cliff. :-) They don't front-end the process enough that someone completely unfamiliar with vinum will be able to do the right things. For the person who *already* knows what vinum does, these patches make initial setup a bit easier, I don't dispute that at all. There are a lot more people than the vinum masters who use sysinstall, however, and those folks are going to be going "what's this? Should I select it? What do I do after that?" In short, it only opens a big can of worms for them. In short, I think these patches are a good start but only about 1/10th of the work necessary to truly bring vinum support into sysinstall. As a 1/10th effort, I also consider them to be something to be passed around amongst various hackers interested in providing the other 9/10 but nothing to actually expose end-users to right now. That's why your (John's) patches went back with comments attached and I've merely been waiting for you to finish them. ;) - Jordan To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
