Re: MFC question

2016-01-13 Thread Adrian Chadd
why can't you provide both in stable/10 ?


-a


On 13 January 2016 at 16:03, Allan Jude  wrote:
> I was considering MFC'ing this commit to stable/10:
>
> https://svnweb.freebsd.org/base?view=revision&revision=292782
>
> It replaces the kernel implementation of SHA512 (sys/crypto/sha2/sha2.c)
> with cperciva@'s version from libmd. In benchmarks it was 5-30% faster,
> on x86_64 and arm/mips.
>
> But, in head I ended up being asked to bump __FreeBSD_version because it
> removes sys/crypto/sha2.h which was apparently used by a 3rd party
> driver, and replaces it with sys/crypto/sha512.h
>
> Does this kind of change mean it cannot be MFCd to stable/10? Or is it
> ok to MFC it?
>
> --
> Allan Jude
>
>
>
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


MFC question

2016-01-13 Thread Allan Jude
I was considering MFC'ing this commit to stable/10:

https://svnweb.freebsd.org/base?view=revision&revision=292782

It replaces the kernel implementation of SHA512 (sys/crypto/sha2/sha2.c)
with cperciva@'s version from libmd. In benchmarks it was 5-30% faster,
on x86_64 and arm/mips.

But, in head I ended up being asked to bump __FreeBSD_version because it
removes sys/crypto/sha2.h which was apparently used by a 3rd party
driver, and replaces it with sys/crypto/sha512.h

Does this kind of change mean it cannot be MFCd to stable/10? Or is it
ok to MFC it?

-- 
Allan Jude





signature.asc
Description: OpenPGP digital signature