Re: Make world hosed ?
On Tue, Jul 17, 2001 at 07:55:18PM +0100, David Malone wrote: I suspect that this is my fault for not doing a buildworld after turning on WARNS stuff in inetd. YES! Why are you committing these very easy to break the build, as we've seen changes w/o full `make buildworld' testing?!? I should have been more careful, but I actually tested the change on the i386 and alpha and checked that it didn't produce any code changes. Unfortunately, gcc has an undocumented feature of ignoring some warnings in system C header files. (Maybe this feature has been there for years, but the fact that gcc gives out about system header files is something that's caused problems for me before.) I would have thought that any file included with #include ... would count as a system header file, but it seems gcc has some other criteron for deciding. I've managed to trace it back to cpp writing out lines like: # 1 /usr/include/tcpd.h 1 3 where the 3 at the end seems to mean a system header file. And in tradcpp.c it seems to set a varible system_header_p if the include is a ... as opposed to a ..., but I haven't found out where the 3 comes from yet. Ahh - I'm looking at the wrong gcc sources. The 2.95.3 sources (which uses the old gcc cpp) decides if something is a system include based on examining a list which doesn't seem to get initialised if you say -nostdinc. The newer gcc sources (2.96.2711 with the new cpp) seem to do the ... vs. ... thing. David. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Make world hosed ?
On Wed, 18 Jul 2001, David Malone wrote: I would have thought that any file included with #include ... would count as a system header file, but it seems gcc has some other criteron for deciding. I've managed to trace it back to cpp writing out lines like: # 1 /usr/include/tcpd.h 1 3 where the 3 at the end seems to mean a system header file. And in tradcpp.c it seems to set a varible system_header_p if the include is a ... as opposed to a ..., but I haven't found out where the 3 comes from yet. Ahh - I'm looking at the wrong gcc sources. The 2.95.3 sources (which uses the old gcc cpp) decides if something is a system include based on examining a list which doesn't seem to get initialised if you say -nostdinc. The newer gcc sources (2.96.2711 with the new cpp) seem to do the ... vs. ... thing. I thought that it just looks at the path prefix and knows that /usr/include is special. It seems to used -nostdinc too. I don't see how looking at ... could be right, since double-quoted includes are not wrong for standard headers. In practice, ``#include tcpd.h'' gives the same lack of warnings as ``#include tcpd.h''. Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Make world hosed ?
Am I the only one who sees this ? === usr.sbin/inetd cc -nostdinc -O -pipe -DINET6 -DIPSEC -DLOGIN_CAP -I/usr/obj/flat/src/i386/usr/include -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpoin ter-arith -Wno-uninitialized -Werror -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -c /flat/src/usr.sbin/inetd/inetd.c gzip -cn /flat/src/usr.sbin/inetd/inetd.8 inetd.8.gz cc -nostdinc -O -pipe -DINET6 -DIPSEC -DLOGIN_CAP -I/usr/obj/flat/src/i386/usr/include -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpoin ter-arith -Wno-uninitialized -Werror -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -c /flat/src/usr.sbin/inetd/builtins.c cc1: warnings being treated as errors In file included from /usr/obj/flat/src/i386/usr/include/rpc/rpc.h:50, from /flat/src/usr.sbin/inetd/inetd.c:125: /usr/obj/flat/src/i386/usr/include/rpc/xdr.h:141: warning: function declaration isn't a prototype In file included from /flat/src/usr.sbin/inetd/inetd.c:139: /usr/obj/flat/src/i386/usr/include/tcpd.h:34: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:35: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:36: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:37: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:75: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:76: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:77: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:78: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:79: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:80: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:81: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:82: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:83: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:126: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:127: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:128: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:129: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:130: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:131: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:137: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:138: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:139: warning: function declaration isn't a prototype /usr/obj/flat/src/i386/usr/include/tcpd.h:187: warning: function declaration isn't a prototype -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Make world hosed ?
On Tue, Jul 17, 2001 at 08:38:13PM +0200, Poul-Henning Kamp wrote: Am I the only one who sees this ? I suspect that this is my fault for not doing a buildworld after turning on WARNS stuff in inetd. I think the problem must be that -nostdinc must cause errors to be issued for files which wouldn't usually be. I'll back out the WARNS stuff and find out what's going on. David. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Make world hosed ?
On Tue, Jul 17, 2001 at 07:55:18PM +0100, David Malone wrote: I suspect that this is my fault for not doing a buildworld after turning on WARNS stuff in inetd. YES! Why are you committing these very easy to break the build, as we've seen changes w/o full `make buildworld' testing?!? I'll back out the WARNS stuff and find out what's going on. Yes, please. If you guys doing the WARNS stuff cannot slow down a little and do proper build testing, I personally (and I know at least one will disagree with me here) wish you guys would stop the effort. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message