Re: PPPoE not working

2000-07-05 Thread Brian Somers

 Brian Somers writes:
  Archie, it seems people are having problems using PPPoE since your 
  ng_ether changes.  Any suggestions ?
 
 Unfortunately I have limited email contact righ tnow.. but a couple
 of things come to mind..
 
 - Is is possible to get a tcpdump of before and after? One thing I
   could imagine is that the new ng_ether may behave differently than
   the old code with respect to overwriting the source Ethernet address
   (the new code shouldn't unless the driver does). But I don't think
   there should be any difference. 'tcpdump not ip' should tell.
 
 - Regarding the libnetgraph change, this supposedly fixed a bug,
   so possibly the code in ppp(8) is relying on broken behavior?
   Where is this code anyway, I don't see a pppoe.c in usr.sbin/ppp..
   I can take a look.

The code's in ppp/ether.c.

I'll see if I can get time to figure out what's wrong, but I can't 
promise anything this week.  I'm too busy (we're having a FreeBSD 
mini-conference here in the UK at which I'm speaking...).

 -Archie
 
 ___
 Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com

-- 
Brian [EMAIL PROTECTED]brian@[uk.]FreeBSD.org
  http://www.Awfulhak.org   brian@[uk.]OpenBSD.org
Don't _EVER_ lose your sense of humour !




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-05 Thread Daniel Berlin

Brian Somers [EMAIL PROTECTED] writes:


 
 The code's in ppp/ether.c.
 
 I'll see if I can get time to figure out what's wrong, but I can't 
 promise anything this week.  I'm too busy (we're having a FreeBSD 
 mini-conference here in the UK at which I'm speaking...).
 
I already solved this one, the problem is that the source address is being overwritten 
with 0's.
As a temporary hack, if you go into ng_pppoe.c, and replace the 0's with your ethernet 
address, you'll be golden.
--Dan



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-04 Thread Daniel Berlin

Brian Somers [EMAIL PROTECTED] writes:

If it helps, the only change i haven't tested (IE i've gone through the 
ppp/netgraph/libnetgraph revisions since 06-09) to see  if it's the cause is this one:

archie  2000/06/21 16:01:07 PDT

  Modified files:
lib/libnetgraph  Makefile msg.c netgraph.3 
  Log:
  - Make sure the message token returned by NgSendMsg() is non-negative
  - Have NgSendAsciiMsg() return the same token as NgSendMsg()
  - Document that NgSendMsg() and NgSendAsciiMsg() return the token
  - Add MLINKS for the functions defined in netgraph(3)

every other change to PPP/netgraph/libnetgraph since 06-09 i've tested, and it makes 
no difference.


 It's worth cc'ing Archie on this
 
 Archie, it seems people are having problems using PPPoE since your 
 ng_ether changes.  Any suggestions ?
 
  Brian Somers [EMAIL PROTECTED] writes:
  
I see literally the exact same thing.
I thought it was just my screwup, as i had installed 0609-CURRENT (the
latest installs don't work, at least, on my desktop, so i picked the one
from my birthday :P), which worked fine, then cvsup'd, installed the new
kernel, did a make world, rebooted, and pppoe no longer worked.
tcpdump shows the same thing you are seeing.
   
   Please try the latest version of ppp.  It *should* try to load the 
   ng_ether node now.  This is a requirement for new kernels.
   
   Alternatively, kldload ng_ether before starting ppp.
   
  
  Doesn't help.
  I've just about narrowed the problem down to a kernel change.
  I can use an old kernel, with the new modules (including ng_ether, which is only 
compiled into my new kernel, not my old one), and it works fine.
  I can use either version of ppp (06-09, or one from today), and it doesn't change 
anything (IE it either works or doesn't, depending on which kernel i use).
  I can't use a new kernel, with netgraph compiled into it (all the ones i use), 
with or without older modules.
  I'm about to test a new kernel, without netgraph compiled into it, with older 
netgraph modules.
  I'll email back how it goes.
  
  --Dan
  
 
 -- 
 Brian [EMAIL PROTECTED]brian@[uk.]FreeBSD.org
   http://www.Awfulhak.org   brian@[uk.]OpenBSD.org
 Don't _EVER_ lose your sense of humour !
 
 
 
 
 To Unsubscribe: send mail to [EMAIL PROTECTED]
 with "unsubscribe freebsd-current" in the body of the message



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-04 Thread Gary Jennejohn

Julian Elischer writes:
 Gary Jennejohn wrote:
  
  
  
  Doesn't help. ng_ether.ko was being automatically loaded before your
  change. Loading it before starting ppp also doesn't help.
  
  I'm beginning to think that the bug is in NETGRAPH.
 
 I agree. to be more precise, between the new ng_ether code,
 and the ng_pppoe code.
 
 running the pppoe node with the AAA code enabled (check the file)
 might lead to some clues.

OK, I took your advice. Here's waht comes out:

Jul  4 22:36:42 peedub /kernel: pppoe: ng_pppoe_constructor
Jul  4 22:36:42 peedub /kernel: pppoe: ng_pppoe_newhook
Jul  4 22:36:42 peedub /kernel: pppoe: ng_pppoe_newhook
Jul  4 22:36:42 peedub /kernel: pppoe: ng_pppoe_rcvmsg
Jul  4 22:36:42 peedub /kernel: pppoe: pppoe_start
Jul  4 22:36:42 peedub /kernel: pppoe: init_tags
Jul  4 22:36:42 peedub /kernel: pppoe: insert_tag
Jul  4 22:36:42 peedub /kernel: pppoe: insert_tag
Jul  4 22:36:42 peedub /kernel: pppoe: make_packet
Jul  4 22:36:42 peedub /kernel: pppoe: sendpacket
Jul  4 22:36:44 peedub /kernel: pppoe: pppoe_ticker
Jul  4 22:36:47 peedub /kernel: pppoe: ng_pppoe_disconnect

The timer which is set in sendpacket triggers. It looks like the
packets which come in on my ed0 aren't being sent to ng_pppoe.
The funny thing is that the packets are going _out_ on ed0.

I spent an hour or so looking at the code, but I can't wrap my mind
around it in such a short time.

---
Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-04 Thread Archie Cobbs

Brian Somers writes:
 Archie, it seems people are having problems using PPPoE since your 
 ng_ether changes.  Any suggestions ?

Unfortunately I have limited email contact righ tnow.. but a couple
of things come to mind..

- Is is possible to get a tcpdump of before and after? One thing I
  could imagine is that the new ng_ether may behave differently than
  the old code with respect to overwriting the source Ethernet address
  (the new code shouldn't unless the driver does). But I don't think
  there should be any difference. 'tcpdump not ip' should tell.

- Regarding the libnetgraph change, this supposedly fixed a bug,
  so possibly the code in ppp(8) is relying on broken behavior?
  Where is this code anyway, I don't see a pppoe.c in usr.sbin/ppp..
  I can take a look.

-Archie

___
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-03 Thread Brian Somers

 I see literally the exact same thing.
 I thought it was just my screwup, as i had installed 0609-CURRENT (the
 latest installs don't work, at least, on my desktop, so i picked the one
 from my birthday :P), which worked fine, then cvsup'd, installed the new
 kernel, did a make world, rebooted, and pppoe no longer worked.
 tcpdump shows the same thing you are seeing.

Please try the latest version of ppp.  It *should* try to load the 
ng_ether node now.  This is a requirement for new kernels.

Alternatively, kldload ng_ether before starting ppp.

 --Dan

-- 
Brian [EMAIL PROTECTED]brian@[uk.]FreeBSD.org
  http://www.Awfulhak.org   brian@[uk.]OpenBSD.org
Don't _EVER_ lose your sense of humour !




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-03 Thread Gary Jennejohn

Brian Somers writes:
  I see literally the exact same thing.
  I thought it was just my screwup, as i had installed 0609-CURRENT (the
  latest installs don't work, at least, on my desktop, so i picked the 
one
  from my birthday :P), which worked fine, then cvsup'd, installed the 
new
  kernel, did a make world, rebooted, and pppoe no longer worked.
  tcpdump shows the same thing you are seeing.
 
 Please try the latest version of ppp.  It *should* try to load the 
 ng_ether node now.  This is a requirement for new kernels.
 
 Alternatively, kldload ng_ether before starting ppp.
 

Doesn't help. ng_ether.ko was being automatically loaded before your
change. Loading it before starting ppp also doesn't help.

I'm beginning to think that the bug is in NETGRAPH.

---
Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



PPPoE not working ?

2000-07-02 Thread Gary Jennejohn

PPPoE has stopped working since I made a new kernel today. Luckily, I still
have kernel.old, which works.

I don't know whether the problem is related to the randomdev changes, or
the stuff Archie has been doing with NETGRAPH.

I did notice that, using the old kernel and modules, I don't need a
ng_ether.ko for PPPoE to work, although I do see a complaint that it
can't be found. With the new kernel and modules PPPoE fails if the
ng_ether.ko isn't found (I moved it away to see if it was perhaps the
source of the problem).

Looking at tcpdump trace with the new kernel it almost looks like the
initial connect packets are not being sent to tun0, but I haven't
spent any time looking at it in detail.

Here's tcpdump output from a working connect and one that fails. Maybe
someone can see something obvious.

working connect (partial):

tcpdump: listening on ed0
22:05:08.252387 PPPoE PADI [Service-Name] [Host-Uniq UTF8]
0x   1109  000c 0101  0103 0004 0067...g
0x0010   01c1   ..
22:05:08.297194 PPPoE PADO [Service-Name] [Host-Uniq UTF8] [AC-Name 
"MUNC31-nrp1
"] [AC-Cookie UTF8]
0x   1107  002f 0101  0103 0004 0067./.g
0x0010   01c1 0102 000b 4d55 4e43 3331 2d6e 7270..MUNC31-nrp
0x0020   3101 0400 1019 befa ff47 3ecf 52f3 7b7b1G.R.{{
0x0030   5b63 db31 75   [c.1u
22:05:08.297288 PPPoE PADR [Service-Name] [AC-Cookie UTF8] [AC-Name 
"MUNC31-nrp1
"] [Host-Uniq UTF8]
0x   1119  002f 0101  0104 0010 19be./..
0x0010   faff 473e cf52 f37b 7b5b 63db 3175 0102..G.R.{{[c.1u..
0x0020   000b 4d55 4e43 3331 2d6e 7270 3101 0300..MUNC31-nrp1...
0x0030   0400 6701 c1   ..g..
22:05:08.342130 PPPoE PADS [ses 0x4cc] [Service-Name] [AC-Cookie UTF8] 
[AC-Name
"MUNC31-nrp1"] [Host-Uniq UTF8]
0x   1165 04cc 002f 0101  0104 0010 19be.e.../..
0x0010   faff 473e cf52 f37b 7b5b 63db 3175 0102..G.R.{{[c.1u..
0x0020   000b 4d55 4e43 3331 2d6e 7270 3101 0300..MUNC31-nrp1...
0x0030   0400 6701 c1   ..g..
22:05:08.343051 PPPoE  [ses 0x4cc] LCP ConfReq id=0x8f auth PAP magic 
0xb4676
d72
0x   1100 04cc 0010 c021 018f 000e 0304 c023...!...#
0x0010   0506 b467 6d72 19be faff 473e cf52 f37b...gmrG.R.{
0x0020   7b5b 63db 3175 0102 000b 4d55 4e43 {[c.1uMUNC

failed connect:

tcpdump: listening on ed0
11:55:10.628019 PPPoE PADI [Service-Name] [Host-Uniq UTF8]
0x   1109  000c 0101  0103 0004 c090
0x0010   e1c0   ..
11:55:10.674248 PPPoE PADO [Service-Name] [Host-Uniq UTF8] [AC-Name 
"MUNC31-nrp1"] [AC-Cookie UTF8]
0x   1107  002f 0101  0103 0004 c090./..
0x0010   e1c0 0102 000b 4d55 4e43 3331 2d6e 7270..MUNC31-nrp
0x0020   3101 0400 105b 0382 ce6b 426d 4ea3 884c1[...kBmN..L
0x0030   10da 4907 7c   ..I.|
11:55:12.620895 PPPoE PADI [Service-Name] [Host-Uniq UTF8]
0x   1109  000c 0101  0103 0004 c090
0x0010   e1c0   ..
11:55:12.666009 PPPoE PADO [Service-Name] [Host-Uniq UTF8] [AC-Name 
"MUNC31-nrp1"] [AC-Cookie UTF8]
0x   1107  002f 0101  0103 0004 c090./..
0x0010   e1c0 0102 000b 4d55 4e43 3331 2d6e 7270..MUNC31-nrp
0x0020   3101 0400 105b 0382 ce6b 426d 4ea3 884c1[...kBmN..L
0x0030   10da 4907 7c   ..I.|


Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED]




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: PPPoE not working

2000-07-02 Thread Daniel Berlin

I see literally the exact same thing.
I thought it was just my screwup, as i had installed 0609-CURRENT (the
latest installs don't work, at least, on my desktop, so i picked the one
from my birthday :P), which worked fine, then cvsup'd, installed the new
kernel, did a make world, rebooted, and pppoe no longer worked.
tcpdump shows the same thing you are seeing.

--Dan



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message