On 14-Dec-01 David Xu wrote:
> I persist with adding "cc", because it does not hurt anything.
It doesn't do anything either except add repo bloat and obfuscate the code a
bit more.
--
John Baldwin <[EMAIL PROTECTED]> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" -
I persist with adding "cc", because it does not hurt anything.
--
David Xu
John Baldwin wrote:
>On 13-Dec-01 Bruce Evans wrote:
>
>>>--- i386/i386/identcpu.c 30 Nov 2001 11:57:23 - 1.96
>>>+++ i386/i386/identcpu.c 6 Dec 2001 07:58:25 -
>>>@@ -115,10 +115,11 @@
>>> static vo
On 13-Dec-01 John Baldwin wrote:
>>> static void
>>> do_cpuid(u_int ax, u_int *p)
>>> {
>>> +
>>> +p[0] = ax;
>>> __asm __volatile(
>>> "cpuid"
>>> -: "=a" (p[0]), "=b" (p[1]), "=c" (p[2]), "=d" (p[3])
>>> -: "0" (ax)
>>> +: "+a" (p[0]), "=b" (p[1]), "=c" (p[2]), "=d
On Thu, Dec 06, 2001 at 08:40:29PM +1100, Bruce Evans wrote:
>On Wed, 5 Dec 2001, John Baldwin wrote:
>
>> On 05-Dec-01 Bruce Evans wrote:
>> >> - Add missing "cc" clobbers in constraints
>> >
>> > Does this have any effect (for i386's) except to create a lot of clutter
>> > Even i386.md doesn't u
On 13-Dec-01 Bruce Evans wrote:
>> --- i386/i386/identcpu.c 30 Nov 2001 11:57:23 - 1.96
>> +++ i386/i386/identcpu.c 6 Dec 2001 07:58:25 -
>> @@ -115,10 +115,11 @@
>> static void
>> do_cpuid(u_int ax, u_int *p)
>> {
>> +
>> +p[0] = ax;
>> __asm __volatile(
>>
On Tue, 11 Dec 2001, John Baldwin wrote:
> Ok, I've axed all the "cc" clobbers from the patch now. Any objections to it
> now? It's still at ~jhb/patches/i386_asm.patch.
Review of what I can see: the URL still appears to be well formed ;-). But
it didn't seem to work, so I scp'ed the file.
>
On 06-Dec-01 Bruce Evans wrote:
> That gives a hint about where to look for the clobbering conventions. From
> gcc/config/i386/i386.c:
>
> ! /* Set the cc_status for the results of an insn whose pattern is EXP.
> !On the 80386, we assume that only test and compare insns, as well
> !as S
On Wed, 5 Dec 2001, John Baldwin wrote:
> On 05-Dec-01 Bruce Evans wrote:
> >> - Add missing "cc" clobbers in constraints
> >
> > Does this have any effect (for i386's) except to create a lot of clutter
> > Even i386.md doesn't use it. gcc.info says:
> > ...
> > None of i386.md, alpha.md or spar
On Wed, Dec 05, 2001 at 02:36:49PM -0800, John Baldwin wrote:
> The patch is at http://www.FreeBSD.org/~jhb/patches/i386_asm.patch. Mostly it
> does the following:
Can you compile some files with gcc30 and see if you get any
new/different warnings about this. Also look at the i386.md file for
b
On 05-Dec-01 Bruce Evans wrote:
>> - Add missing "cc" clobbers in constraints
>
> Does this have any effect (for i386's) except to create a lot of clutter
> Even i386.md doesn't use it. gcc.info says:
>
> !If your assembler instruction can alter the condition code register,
> ! add `cc' to
On Wed, 5 Dec 2001, John Baldwin wrote:
Review of what I can see and quote easily.
> The patch is at http://www.FreeBSD.org/~jhb/patches/i386_asm.patch. Mostly it
> does the following:
This URL appears to be well formed ;-).
> - Add missing "cc" clobbers in constraints
Does this have any eff
The patch is at http://www.FreeBSD.org/~jhb/patches/i386_asm.patch. Mostly it
does the following:
- Add missing "cc" clobbers in constraints
- Use the "+" modifier for output operands rather than using "0", "1", etc.
to list operands in both input and output sections.
- Fix the atomic operatio
12 matches
Mail list logo
