Re: [HEADS-UP]: Mbuf allocator changes
* Bosko Milekic [EMAIL PROTECTED] [010622 01:47] wrote: Hi -current people, I have recently made some significant changes to the mbuf allocator. Although I have invested, along with several other developers, very significant time in testing the newly introduced code, should any problems arise, please let me know ASAP. One noticeable difference that I am aware of is that mbtypes statistics have been TEMPORARILY disabled. Please be patient. :-) If you want accurate stats you should be able to lock the per-cpu stats areas all at once as long as you always do it in a certain order, basically, lock CPU 0, then 1, then 2, then 3, sum then unlock. If correctness doesn't matter you can just walk the per cpu stats locking each (or not) and assumulating the info. -Alfred To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
RE: [HEADS-UP]: Mbuf allocator changes
UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? On 22-Jun-2001 Bosko Milekic wrote: Hi -current people, I have recently made some significant changes to the mbuf allocator. Although I have invested, along with several other developers, very significant time in testing the newly introduced code, should any problems arise, please let me know ASAP. One noticeable difference that I am aware of is that mbtypes statistics have been TEMPORARILY disabled. Please be patient. :-) Thank you for flying -CURRENT, -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message E-Mail: Alexander N. Kabaev [EMAIL PROTECTED] Date: 22-Jun-2001 Time: 11:41:47 To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
RE: [HEADS-UP]: Mbuf allocator changes
I would think not. Bosko might be gone now. I'll look at this as soon as a CVS update continues. It's odd, though. A GENERIC kernel built for me yesterday w/o problems. On Fri, 22 Jun 2001, Alexander N. Kabaev wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? On 22-Jun-2001 Bosko Milekic wrote: Hi -current people, I have recently made some significant changes to the mbuf allocator. Although I have invested, along with several other developers, very significant time in testing the newly introduced code, should any problems arise, please let me know ASAP. One noticeable difference that I am aware of is that mbtypes statistics have been TEMPORARILY disabled. Please be patient. :-) Thank you for flying -CURRENT, -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message E-Mail: Alexander N. Kabaev [EMAIL PROTECTED] Date: 22-Jun-2001 Time: 11:41:47 To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On Fri, Jun 22, 2001 at 11:45:50AM -0400, Alexander N. Kabaev wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? It turns out that it should stay under SMP ifdef. I'll fix this another way immediately. Please allow an hour or so for testing. Thanks! Oh, would somebody please pass the Pointy Hat this way? E-Mail: Alexander N. Kabaev [EMAIL PROTECTED] Date: 22-Jun-2001 Time: 11:41:47 Regards, -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On Fri, Jun 22, 2001 at 08:51:55AM -0700, Matthew Jacob wrote: I would think not. Bosko might be gone now. I'll look at this as soon as a CVS update continues. It's odd, though. A GENERIC kernel built for me yesterday w/o problems. Nah, don't worry. I'm still here (and plan to remain until I'm sure to have knocked out the initial problems). When I leave (tomorrow night) and once I get settled in, I will get a dialup and be in the vincinity to commit emergency changes (such as this) if necessary. As for this, I'm in the process of fixing it immediately. Sorry! Cheers, -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On Fri, Jun 22, 2001 at 01:52:01AM -0500, Alfred Perlstein wrote: If you want accurate stats you should be able to lock the per-cpu stats areas all at once as long as you always do it in a certain order, basically, lock CPU 0, then 1, then 2, then 3, sum then unlock. If correctness doesn't matter you can just walk the per cpu stats locking each (or not) and assumulating the info. I don't need to lock the per-CPU locks to merely read the stats (unless I'm reall obsessed with getting consistent stats at the cost of performance every time a person issues `netstat -m' or, even worse, runs `systat -mbufs'). The main issue with the mbtypes stats, as I've previously mentionned, was that it is difficult to *update* them consistently. However, I think I have devised a way. I'll keep you posted if you're interested in reviewing it. -Alfred Cheers, -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
* Alexander N. Kabaev [EMAIL PROTECTED] [010622 10:46] wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? Yes, I asked for this months ago, I thought it was already done. -Alfred To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On 22-Jun-01 Alfred Perlstein wrote: * Alexander N. Kabaev [EMAIL PROTECTED] [010622 10:46] wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? Yes, I asked for this months ago, I thought it was already done. mp_npcus is not initialized, etc. in the UP case. I suppose it could be statically initialized to 1 and moved, but in that case it needs renaming, as mp_ncpus implies SMP (mp_ prefix). If you want to make it ncpus and move it to sys/systm.h and stick it somewhere MI initialized to 1 that is fine. Then hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it should be renamed to match the variable *shrug*) and kern.smp.cpus can die as it won't be needed any longer. -Alfred -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc Power Users Use the Power to Serve! - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On Fri, Jun 22, 2001 at 10:35:32AM -0700, John Baldwin wrote: On 22-Jun-01 Alfred Perlstein wrote: * Alexander N. Kabaev [EMAIL PROTECTED] [010622 10:46] wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? Yes, I asked for this months ago, I thought it was already done. mp_npcus is not initialized, etc. in the UP case. I suppose it could be statically initialized to 1 and moved, but in that case it needs renaming, as mp_ncpus implies SMP (mp_ prefix). If you want to make it ncpus and move it to sys/systm.h and stick it somewhere MI initialized to 1 that is fine. Then hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it should be renamed to match the variable *shrug*) and kern.smp.cpus can die as it won't be needed any longer. Note that we already have a (machdep, I think) sysctl exported ncpu variable. -Alfred -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc Power Users Use the Power to Serve! - http://www.FreeBSD.org/ -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On Fri, Jun 22, 2001 at 01:32:21PM -0400, Bosko Milekic wrote: mp_ncpus implies SMP (mp_ prefix). If you want to make it ncpus and move it to sys/systm.h and stick it somewhere MI initialized to 1 that is fine. Then hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it should be renamed to match the variable *shrug*) and kern.smp.cpus can die as it won't be needed any longer. Note that we already have a (machdep, I think) sysctl exported ncpu variable. Doh, I missed the fact that you mentionned this. :-) -Alfred -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc Power Users Use the Power to Serve! - http://www.FreeBSD.org/ -- Bosko Milekic [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: [HEADS-UP]: Mbuf allocator changes
On 22-Jun-01 Bosko Milekic wrote: On Fri, Jun 22, 2001 at 10:35:32AM -0700, John Baldwin wrote: On 22-Jun-01 Alfred Perlstein wrote: * Alexander N. Kabaev [EMAIL PROTECTED] [010622 10:46] wrote: UP kernel can not be compiled in -CURRENT after your changes because kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP case. Should this variable be moved out of #ifdef SMP? Yes, I asked for this months ago, I thought it was already done. mp_npcus is not initialized, etc. in the UP case. I suppose it could be statically initialized to 1 and moved, but in that case it needs renaming, as mp_ncpus implies SMP (mp_ prefix). If you want to make it ncpus and move it to sys/systm.h and stick it somewhere MI initialized to 1 that is fine. Then hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it should be renamed to match the variable *shrug*) and kern.smp.cpus can die as it won't be needed any longer. Note that we already have a (machdep, I think) sysctl exported ncpu variable. We already have a hw.ncpu. machdep.* should not be used by anything that is supposed to be MI. Offline it seems you missed part of the point of my post though. :) -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc Power Users Use the Power to Serve! - http://www.FreeBSD.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
