Re: [PATCH] sed is broken in -CURRENT

2002-06-15 Thread Tim Robbins

On Sat, Jun 15, 2002 at 11:31:38PM -0700, Doug Barton wrote:

> Joe Marcus Clarke wrote:
> > 
> > After the recent round of -i fixes to sed, certain ports will no longer
> > make configure (gaim being a prime example).  The problem is that
> > mf_fgets() is unnecessarily overwriting sp->len.  The attached patch
> > corrects the problem while still allowing -i to work on multiple files.
> > 
> > As a ports committer, I can't do anything but let you guys (and gals)
> > know. 
> 
> Just like any other user, you can file a PR. And given that you're a
> committer, you can then assign it to whoever broke the things your patch
> fixes.

There is already a PR open for this issue: bin/39310 . It is assigned
to sobomax becauses his streamlining of the file processing code
inadvertently caused the incorrect behaviour.

Such are the perils of using -CURRENT for anything but development and
testing :)


Tim

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: [PATCH] sed is broken in -CURRENT

2002-06-15 Thread Doug Barton

Joe Marcus Clarke wrote:
> 
> After the recent round of -i fixes to sed, certain ports will no longer
> make configure (gaim being a prime example).  The problem is that
> mf_fgets() is unnecessarily overwriting sp->len.  The attached patch
> corrects the problem while still allowing -i to work on multiple files.
> 
> As a ports committer, I can't do anything but let you guys (and gals)
> know. 

Just like any other user, you can file a PR. And given that you're a
committer, you can then assign it to whoever broke the things your patch
fixes.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message