Hi,
Please find attached an updated TSO patch based on comments from Andrew,
Rick and John-Mark Gurney. Review is appreciated.
--HPS
=== sys/dev/oce/oce_if.c
==
--- sys/dev/oce/oce_if.c (revision 271555)
+++ sys/dev/oce/oce_if.c (
Hi Rick,
I've collected all input from this discussion and committed the
following patch to -current. I would like to MFC this to 10-stable
before the coming 10-branchout. Sorry I'm rushing this a bit, hence
there is only 2 weeks left until the branching happens.
http://svnweb.freebsd.org/ch
Hans Petter Selasky wrote:
> Hi Rick,
>
> Did you get a chance to look further at my patch?
>
Ok, I just took a quick look. (I didn't try and figure out
if the code in tcp_output() looked correct.)
> Is this something we can commit?
>
Well, I'd like to sound more positive, but here are a number
Hi Rick,
Did you get a chance to look further at my patch?
Is this something we can commit?
--HPS
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-
Let me remove my concerns earlier in the thread -- this patch won't
negatively affect any of our drivers; and the problem I mentioned with ixl
would require a change somewhere further up the stack.
---
- Eric Joyner
On Mon, Sep 8, 2014 at 5:05 AM, Rick Macklem wrote:
> Hans Petter Selasky wrote
Hans Petter Selasky wrote:
> On 09/06/14 00:09, Rick Macklem wrote:
> > Hans Petter Selesky wrote:
> >> On 09/05/14 23:19, Eric Joyner wrote:
> >>> There are some concerns if we use this with devices that ixl
> >>> supports:
> >>>
> >>> - The maximum fragment size is 16KB-1, which isn't a power of
On 09/06/14 00:09, Rick Macklem wrote:
Hans Petter Selesky wrote:
On 09/05/14 23:19, Eric Joyner wrote:
There are some concerns if we use this with devices that ixl
supports:
- The maximum fragment size is 16KB-1, which isn't a power of 2.
Hi Eric,
Multiplying by powers of two are more fas
Hans Petter Selasky wrote this message on Fri, Sep 05, 2014 at 20:37 +0200:
> I've tested the attached patch with success and would like to have some
> feedback from other FreeBSD network developers. The problem is that the
> current TSO limitation only limits the number of bytes that can be
> t
Hans Petter Selasky wrote:
> On 09/06/14 00:09, Rick Macklem wrote:
> > Hans Petter Selesky wrote:
> >> On 09/05/14 23:19, Eric Joyner wrote:
> >>> There are some concerns if we use this with devices that ixl
> >>> supports:
> >>>
> >>> - The maximum fragment size is 16KB-1, which isn't a power of
On 09/06/14 00:09, Rick Macklem wrote:
Hans Petter Selesky wrote:
On 09/05/14 23:19, Eric Joyner wrote:
There are some concerns if we use this with devices that ixl
supports:
- The maximum fragment size is 16KB-1, which isn't a power of 2.
Hi Eric,
Multiplying by powers of two are more fas
Hans Petter Selasky wrote:
> Hi,
>
> I've tested the attached patch with success and would like to have
> some
> feedback from other FreeBSD network developers. The problem is that
> the
> current TSO limitation only limits the number of bytes that can be
> transferred in a TSO packet and not the
Hans Petter Selesky wrote:
> On 09/05/14 23:19, Eric Joyner wrote:
> > There are some concerns if we use this with devices that ixl
> > supports:
> >
> > - The maximum fragment size is 16KB-1, which isn't a power of 2.
> >
>
> Hi Eric,
>
> Multiplying by powers of two are more fast, than non-powe
On 09/05/14 23:19, Eric Joyner wrote:
There are some concerns if we use this with devices that ixl supports:
- The maximum fragment size is 16KB-1, which isn't a power of 2.
Hi Eric,
Multiplying by powers of two are more fast, than non-powers of two. So
in this case you would have to use 8K
There are some concerns if we use this with devices that ixl supports:
- The maximum fragment size is 16KB-1, which isn't a power of 2.
- You can't get the maximum TSO size for ixl devices by multiplying the
maximum number of fragments by the maximum size.
Instead the number of fragments is AFAIK
14 matches
Mail list logo
