Re: -CURRENT b0rked?
John Hay wrote:
It seems that sysinstall(8) was not fully integrated into
buildworld - it depends on content of /usr/share/syscons/keymaps,
while it shouldn't.
I've just committed a patch that should fix this problem.
You should look a little earlier in the logs to where the damage was really
done:
rm -f keymap.tmp
for map in be.iso br275.iso danish.iso finnish.iso fr.iso german.iso hr.iso hu.
iso2.101keys it.iso icelandic.iso jp.106 norwegian.iso pl_PL.ISO_8859-2 pt.iso
ru.koi8-r si.iso spanish.iso swedish.iso swissfrench.iso swissgerman.iso ua.koi
8-u ua.koi8-u.shift.alt uk.iso us.dvorak us.iso us.pc-ctrl us.unix ; do env KE
YMAP_PATH=/usr/src/usr.sbin/sysinstall/../../share/syscons/keymaps kbdcontrol -
L $map | sed -e '/^static accentmap_t/,$d' keymap.tmp ; done
Segmentation fault - core dumped
...
It looks like kbdcontrol is not very happy.
Ok, here is a patch that fix the problem for me. The problem is that
a second call to mkfullname() will reuse the memory at the pointer that
it returns, so you have to preserve it before then.
John
--
John Hay -- [EMAIL PROTECTED]
Index: usr.sbin/kbdcontrol/kbdcontrol.c
===
RCS file: /home/ncvs/src/usr.sbin/kbdcontrol/kbdcontrol.c,v
retrieving revision 1.34
diff -u -r1.34 kbdcontrol.c
--- usr.sbin/kbdcontrol/kbdcontrol.c2001/05/12 09:16:09 1.34
+++ usr.sbin/kbdcontrol/kbdcontrol.c2001/05/13 15:02:14
@@ -751,8 +751,11 @@
char*prefix[] = {, , KEYMAP_PATH, NULL};
char*postfix[] = {, .kbd, NULL};
- if (cp = getenv(KEYMAP_PATH))
- prefix[0] = mkfullname(cp, /, );
+ if (cp = getenv(KEYMAP_PATH)) {
+ cp = mkfullname(cp, /, );
+ prefix[0] = malloc(strlen(cp) + 1);
+ strcpy(prefix[0], cp);
Alternately:
prefix[0] = strdup(mkfullname(cp, /, ));
Probably you should check for failures, though...
-- Terry
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
On Sat, May 12, 2001 at 10:11:25PM -0500, Matthew D. Fuller wrote:
On Sat, May 12, 2001 at 10:07:20PM -0500 I heard the voice of
Ken Wills, and lo! it spake thus:
Deleting keymap.h (autogenerated, in obj/* somewhere, I forget), and restarting
the build got me past this.
I start all my builds with an empty /usr/obj and a freshly co'd /usr/src.
Re-newfs'ing everything here and trying again, just to make doubly sure
now, but I'm pretty sure I cleaned up as always.
Sounds like a problem I had today trying to do a buildworld.
I suspect that the following change messed things up:
src/usr.sbin/sysinstall/Makefile:
revision 1.110
date: 2001/05/12 09:19:36; author: sobomax; state: Exp; lines: +2 -1
Take keyboard map files from ${.CURDIR}/../../share/syscons/keymaps, not from
/usr/share/syscons/keymaps. This should prevent word breakage when new keymaps
have been added.
To get around it, I just commented out the file that was causing problems
in the makefile (ua..alt.kbd or something like that), but before that I
had nuked /usr/obj twice, and did fresh checkouts of /usr/src just to be
sure I hadn't messed up.
-Mike
-
Mike Pritchard
[EMAIL PROTECTED] or [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
It seems that sysinstall(8) was not fully integrated into buildworld - it depends on content of /usr/share/syscons/keymaps, while it shouldn't. I've just committed a patch that should fix this problem. Hoo, here I come to make your life a living hell once more... In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:2: `keymap_be_iso' undeclared here (not in a function) keymap.h:2: initializer element is not constant keymap.h:2: (near initialization for `keymapInfos[0].map') keymap.h:3: `keymap_br275_iso' undeclared here (not in a function) keymap.h:3: initializer element is not constant keymap.h:3: (near initialization for `keymapInfos[1].map') etc etc etc, for about 2.5 pages You should look a little earlier in the logs to where the damage was really done: rm -f keymap.tmp for map in be.iso br275.iso danish.iso finnish.iso fr.iso german.iso hr.iso hu. iso2.101keys it.iso icelandic.iso jp.106 norwegian.iso pl_PL.ISO_8859-2 pt.iso ru.koi8-r si.iso spanish.iso swedish.iso swissfrench.iso swissgerman.iso ua.koi 8-u ua.koi8-u.shift.alt uk.iso us.dvorak us.iso us.pc-ctrl us.unix ; do env KE YMAP_PATH=/usr/src/usr.sbin/sysinstall/../../share/syscons/keymaps kbdcontrol - L $map | sed -e '/^static accentmap_t/,$d' keymap.tmp ; done Segmentation fault - core dumped Segmentation fault - core dumped Segmentation fault - core dumped Segmentation fault - core dumped Segmentation fault - core dumped ... It looks like kbdcontrol is not very happy. John -- John Hay -- [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
It seems that sysinstall(8) was not fully integrated into
buildworld - it depends on content of /usr/share/syscons/keymaps,
while it shouldn't.
I've just committed a patch that should fix this problem.
You should look a little earlier in the logs to where the damage was really
done:
rm -f keymap.tmp
for map in be.iso br275.iso danish.iso finnish.iso fr.iso german.iso hr.iso hu.
iso2.101keys it.iso icelandic.iso jp.106 norwegian.iso pl_PL.ISO_8859-2 pt.iso
ru.koi8-r si.iso spanish.iso swedish.iso swissfrench.iso swissgerman.iso ua.koi
8-u ua.koi8-u.shift.alt uk.iso us.dvorak us.iso us.pc-ctrl us.unix ; do env KE
YMAP_PATH=/usr/src/usr.sbin/sysinstall/../../share/syscons/keymaps kbdcontrol -
L $map | sed -e '/^static accentmap_t/,$d' keymap.tmp ; done
Segmentation fault - core dumped
...
It looks like kbdcontrol is not very happy.
Ok, here is a patch that fix the problem for me. The problem is that
a second call to mkfullname() will reuse the memory at the pointer that
it returns, so you have to preserve it before then.
John
--
John Hay -- [EMAIL PROTECTED]
Index: usr.sbin/kbdcontrol/kbdcontrol.c
===
RCS file: /home/ncvs/src/usr.sbin/kbdcontrol/kbdcontrol.c,v
retrieving revision 1.34
diff -u -r1.34 kbdcontrol.c
--- usr.sbin/kbdcontrol/kbdcontrol.c2001/05/12 09:16:09 1.34
+++ usr.sbin/kbdcontrol/kbdcontrol.c2001/05/13 15:02:14
@@ -751,8 +751,11 @@
char*prefix[] = {, , KEYMAP_PATH, NULL};
char*postfix[] = {, .kbd, NULL};
- if (cp = getenv(KEYMAP_PATH))
- prefix[0] = mkfullname(cp, /, );
+ if (cp = getenv(KEYMAP_PATH)) {
+ cp = mkfullname(cp, /, );
+ prefix[0] = malloc(strlen(cp) + 1);
+ strcpy(prefix[0], cp);
+ }
for (i=0; prefix[i]; i++)
for (j=0; postfix[j]; j++) {
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: -CURRENT b0rked?
I applied John's patch to usr.sbin/kbdcontrol/kbdcontrol.c, but it still dies for me; same way: -- stage 4: make dependencies -- ... === usr.sbin/sysinstall rm -f makedevs.tmp echo '#include sys/types.h' makedevs.tmp ... rm -f keymap.tmp for map in be.iso br275.iso danish.iso finnish.iso fr.iso german.iso hr.iso hu.iso2.101keys it.iso icelandic.iso jp.106 norwegian.iso pl_PL.ISO_8859-2 pt.iso ru.koi8-r si.iso spanish.iso swedish.iso swissfrench.iso swissgerman.iso ua.koi8-u ua.koi8-u.shift.alt uk.iso us.dvorak us.iso us.pc-ctrl us.unix ; do env KEYMAP_PATH=/usr/src/usr.sbin/sysinstall/../../share/syscons/keymaps kbdcontrol -L $map | sed -e '/^static accentmap_t/,$d' keymap.tmp ; done Segmentation fault - core dumped ... -- stage 4: building everything.. -- === usr.sbin/sysinstall cc -O -pipe -Wall -I/usr/src/usr.sbin/sysinstall/../../gnu/lib/libdialog -I. -I/usr/obj/usr/src/i386/usr/include -c /usr/src/usr.sbin/sysinstall/anonFTP.c ... cc -O -pipe -Wall -I/usr/src/usr.sbin/sysinstall/../../gnu/lib/libdialog -I. -I/usr/obj/usr/src/i386/usr/include -c /usr/src/usr.sbin/sysinstall/keymap.c In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:2: `keymap_be_iso' undeclared here (not in a function) keymap.h:2: initializer element is not constant keymap.h:2: (near initialization for `keymapInfos[0].map') keymap.h:3: `keymap_br275_iso' undeclared here (not in a function) keymap.h:3: initializer element is not constant ... keymap.h:27: initializer element is not constant keymap.h:27: (near initialization for `keymapInfos[25].map') keymap.h:28: `keymap_us_unix' undeclared here (not in a function) keymap.h:28: initializer element is not constant keymap.h:28: (near initialization for `keymapInfos[26].map') *** Error code 1 Stop in /usr/src/usr.sbin/sysinstall. *** Error code 1 Stop in /usr/src/usr.sbin. *** Error code 1 After patching usr.sbin/kbdcontrol/kbdcontrol.c, I just did the usual: date make buildworld date make kernel KERNCONF=LAPTOP_30W date make installworld date mergemaster date df -k The only non-comment lines in /etc/make.conf are: dhcp-140[13] grep -v '^#' /etc/make.conf CFLAGS= -O -pipe INSTALL=install -C COPTFLAGS= -O -pipe COMPAT22= yes COMPAT3X= yes PRINTERDEVICE= ps HAVE_MOTIF= yes USA_RESIDENT= YES FORCE_PKG_REGISTER=YES XFREE86_VERSION=4 SUP_UPDATE= yes SUP=/usr/local/bin/cvsup SUPFLAGS= -g -L 2 SUPFILE=/usr/local/etc/4.x-stable-supfile WITH_PNG_MMX=YES dhcp-140[14] uname -a FreeBSD dhcp-140.catwhisker.org 5.0-CURRENT FreeBSD 5.0-CURRENT #62: Sat May 12 14:01:53 PDT 2001 [EMAIL PROTECTED]:/common/C/obj/usr/src/sys/LAPTOP_30W i386 dhcp-140[15] Was there something else needed? Thanks, david -- David H. Wolfskill [EMAIL PROTECTED] As a computing professional, I believe it would be unethical for me to advise, recommend, or support the use (save possibly for personal amusement) of any product that is or depends on any Microsoft product. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: -CURRENT b0rked?
From: John Hay [EMAIL PROTECTED] Date: Sun, 13 May 2001 20:54:56 +0200 (SAT) Well I must admit that I cheated. After the patch I did a make all install in the kbdcontrol directory. The problem is that kdbcontrol is not in any of the build-tools/bootstrap-tools targets, so the installed version is getting used to do the work. OK; with that hint John's earlier-sent-out patch (to usr.sbin/kbdcontrol/kbdcontrol.c), I am now running: FreeBSD dhcp-140.catwhisker.org 5.0-CURRENT FreeBSD 5.0-CURRENT #63: Sun May 13 15:04:35 PDT 2001 [EMAIL PROTECTED]:/common/C/obj/usr/src/sys/LAPTOP_30W i386 I'd expect that this would be likely to affect folks who have a version of /usr/sbin/kbdcontrol built from usr.sbin/kbdcontrol/kbdcontrol.c 1.34 (2001/05/12 09:16:09), but I'm hardly an authority on such matters. Cheers, david -- David H. Wolfskill [EMAIL PROTECTED] As a computing professional, I believe it would be unethical for me to advise, recommend, or support the use (save possibly for personal amusement) of any product that is or depends on any Microsoft product. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: -CURRENT b0rked?
After having the sysinstall/kbdcontrol problem, I cd src/usr.sbin/sysinstall make clean cvsup make world and all worked OK. As of Sat May 12 1430 PDT. tomdean To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
On Sat, 12 May 2001 08:48:24 +0300 (EEST), Maxim Sobolev wrote: On Fri, 11 May 2001 23:44:17 -0500, Matthew D. Fuller wrote: On several attempts to build world, I'm getting ths same error: In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:3606: `keymap_ua_koi8_u_shift_alt' undeclared here (not in a function) keymap.h:3606: initializer element is not constant keymap.h:3606: (near initialization for `keymapInfos[21].map') at which point the build bombs out. This is with completely clean src/ and obj/ each time, and I haven't seen any commits to the file in the last 24+ hours. OTOH, I haven't seen a peep about this from anybody else, so am I just hitting some sort of really weird condition that nobody else has ever heard of here, or is nobody else building -CURRENT right now? It is unlikely that nobody else is doing buildworld. Please try to do the following and restart buildworld: # cd /usr/src/share/syscons/keymaps make all install cleandir It seems that sysinstall(8) was not fully integrated into buildworld - it depends on content of /usr/share/syscons/keymaps, while it shouldn't. I've just committed a patch that should fix this problem. -Maxim To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
On Sat, May 12, 2001 at 12:21:55PM +0300 I heard the voice of Maxim Sobolev, and lo! it spake thus: It seems that sysinstall(8) was not fully integrated into buildworld - it depends on content of /usr/share/syscons/keymaps, while it shouldn't. I've just committed a patch that should fix this problem. Hoo, here I come to make your life a living hell once more... In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:2: `keymap_be_iso' undeclared here (not in a function) keymap.h:2: initializer element is not constant keymap.h:2: (near initialization for `keymapInfos[0].map') keymap.h:3: `keymap_br275_iso' undeclared here (not in a function) keymap.h:3: initializer element is not constant keymap.h:3: (near initialization for `keymapInfos[1].map') etc etc etc, for about 2.5 pages -- Matthew Fuller (MF4839) |[EMAIL PROTECTED] Unix Systems Administrator |[EMAIL PROTECTED] Specializing in FreeBSD |http://www.over-yonder.net/ The only reason I'm burning my candle at both ends, is because I haven't figured out how to light the middle yet To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
* Matthew D. Fuller [EMAIL PROTECTED] [010512 19:35]: On Sat, May 12, 2001 at 12:21:55PM +0300 I heard the voice of Maxim Sobolev, and lo! it spake thus: It seems that sysinstall(8) was not fully integrated into buildworld - it depends on content of /usr/share/syscons/keymaps, while it shouldn't. I've just committed a patch that should fix this problem. Hoo, here I come to make your life a living hell once more... In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:2: `keymap_be_iso' undeclared here (not in a function) keymap.h:2: initializer element is not constant keymap.h:2: (near initialization for `keymapInfos[0].map') keymap.h:3: `keymap_br275_iso' undeclared here (not in a function) keymap.h:3: initializer element is not constant keymap.h:3: (near initialization for `keymapInfos[1].map') etc etc etc, for about 2.5 pages Deleting keymap.h (autogenerated, in obj/* somewhere, I forget), and restarting the build got me past this. K To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: Re: -CURRENT b0rked?
On Sat, May 12, 2001 at 10:07:20PM -0500 I heard the voice of Ken Wills, and lo! it spake thus: Deleting keymap.h (autogenerated, in obj/* somewhere, I forget), and restarting the build got me past this. I start all my builds with an empty /usr/obj and a freshly co'd /usr/src. Re-newfs'ing everything here and trying again, just to make doubly sure now, but I'm pretty sure I cleaned up as always. -- Matthew Fuller (MF4839) |[EMAIL PROTECTED] Unix Systems Administrator |[EMAIL PROTECTED] Specializing in FreeBSD |http://www.over-yonder.net/ The only reason I'm burning my candle at both ends, is because I haven't figured out how to light the middle yet To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: -CURRENT b0rked?
On Fri, 11 May 2001 23:44:17 -0500, Matthew D. Fuller wrote: On several attempts to build world, I'm getting ths same error: In file included from /usr/src/usr.sbin/sysinstall/keymap.c:40: keymap.h:3606: `keymap_ua_koi8_u_shift_alt' undeclared here (not in a function) keymap.h:3606: initializer element is not constant keymap.h:3606: (near initialization for `keymapInfos[21].map') at which point the build bombs out. This is with completely clean src/ and obj/ each time, and I haven't seen any commits to the file in the last 24+ hours. OTOH, I haven't seen a peep about this from anybody else, so am I just hitting some sort of really weird condition that nobody else has ever heard of here, or is nobody else building -CURRENT right now? It is unlikely that nobody else is doing buildworld. Please try to do the following and restart buildworld: # cd /usr/src/share/syscons/keymaps make all install cleandir -Maxim To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
