Re: -pthread deprecated, but when?
On Tuesday 09 September 2003 06:23, leafy wrote: IMO this deprecation deserves a place in UPDATING. And what are the plans to Do The Right Thing? QT currently does not compile on -current with the -pthread deprecated. Was port@ informed before the change? Not only qt isn't compiling any more on -current and I'm not sure if anybody is aware that ports can't be compiled on -current (at least the one I tried). Only the mozilla stuff has been patched so far. I'm also very interested what the plans are to Do The Right Thing. Thanks, -Harry Jiawei Ye pgp0.pgp Description: signature
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, Harald Schmalzbauer wrote:
On Tuesday 09 September 2003 06:23, leafy wrote:
IMO this deprecation deserves a place in UPDATING. And what are the
plans to Do The Right Thing? QT currently does not compile on -current
with the -pthread deprecated.
Probably be nice to bump __FreeBSD_version too, just for fun.
Was port@ informed before the change?
Yes.
I'm also very interested what the plans are to Do The Right Thing.
The right thing to do is to file a PR when this stuff breaks. This
process will actually be a good thing, since ports should not have been
compiling on -current with -pthread for a long time now.
BTW, several ports have already been fixed, and the fix is not
difficult. I do the following in my ports:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
-e 's#malloc.h#stdlib.h#g' \
${WRKSRC}/configure.Patched ${WRKSRC}/configure
Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.
HTH,
Doug
--
This .signature sanitized for your protection
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
On Tue, 2003-09-09 at 16:07, Doug Barton wrote:
Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.
Seems that -lc_r is set by default in bsd.port.mk for ${PTHREAD_LIBS}.
Does it mean that we should be able to specify a pthread library in
future as a make option for installing ports?
Or use libmap.conf(5) to relink libc_r to one of the threading
libraries?
--
Optimized, readable, on time; Pick any two.
FreeBSD 5.1-CURRENT i386
8:57PM up 21:31, 2 users, load averages: 0.09, 0.16, 0.16
signature.asc
Description: This is a digitally signed message part
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, Harald Schmalzbauer wrote:
On Tuesday 09 September 2003 06:23, leafy wrote:
IMO this deprecation deserves a place in UPDATING. And what are the
plans to Do The Right Thing? QT currently does not compile on -current
with the -pthread deprecated.
Was port@ informed before the change?
Yes.
Not only qt isn't compiling any more on -current and I'm not sure if anybody
is aware that ports can't be compiled on -current (at least the one I tried).
Only the mozilla stuff has been patched so far.
I'm also very interested what the plans are to Do The Right Thing.
See ${PTHREAD_LIBS} and ports@
--
Dan Eischen
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
Date: Tue, 9 Sep 2003 01:07:46 -0700 (PDT)
From: Doug Barton [EMAIL PROTECTED]
Sender: [EMAIL PROTECTED]
On Tue, 9 Sep 2003, Harald Schmalzbauer wrote:
On Tuesday 09 September 2003 06:23, leafy wrote:
IMO this deprecation deserves a place in UPDATING. And what are the
plans to Do The Right Thing? QT currently does not compile on -current
with the -pthread deprecated.
Probably be nice to bump __FreeBSD_version too, just for fun.
Was port@ informed before the change?
Yes.
I'm also very interested what the plans are to Do The Right Thing.
The right thing to do is to file a PR when this stuff breaks. This
process will actually be a good thing, since ports should not have been
compiling on -current with -pthread for a long time now.
BTW, several ports have already been fixed, and the fix is not
difficult. I do the following in my ports:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
-e 's#malloc.h#stdlib.h#g' \
${WRKSRC}/configure.Patched ${WRKSRC}/configure
Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.
For which versions of FreeBSD? I just tried using ${PTHREAD_LIBS}, but
the loader could not find any of the pthread routines. I assume it
should be defined in one of the .mk files, but it does not seem to be
on either a current (yesterday) or an older current (9/19).
--
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: [EMAIL PROTECTED] Phone: +1 510 486-8634
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
In the last episode (Sep 09), Kevin Oberman said:
From: Doug Barton [EMAIL PROTECTED] The right thing to do is to
file a PR when this stuff breaks. This process will actually be a
good thing, since ports should not have been compiling on -current
with -pthread for a long time now.
BTW, several ports have already been fixed, and the fix is not
difficult. I do the following in my ports:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
-e 's#malloc.h#stdlib.h#g' \
${WRKSRC}/configure.Patched ${WRKSRC}/configure
Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.
For which versions of FreeBSD? I just tried using ${PTHREAD_LIBS},
but the loader could not find any of the pthread routines. I assume
it should be defined in one of the .mk files, but it does not seem to
be on either a current (yesterday) or an older current (9/19).
bsd.port.mk has used -lc_r for pthreads on 5.0 since March 2001 (rev
1.363).
http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.362r2=1.363f=h
--
Dan Nelson
[EMAIL PROTECTED]
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
Doug Barton [EMAIL PROTECTED] writes:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
How about: ${SED} -Ee 's#-l?pthread#${PTHREAD_LIBS}#g' \
That's the one necessary to catch -pthread (such as BerkeleyDB) in
addition to -lpthread.
--
Matthias Andree
Encrypt your mail: my GnuPG key ID is 0x052E7D95
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, Khairil Yusof wrote:
On Tue, 2003-09-09 at 16:07, Doug Barton wrote:
Any occurences of -lc_r should be changed to ${PTHREAD_LIBS} too.
Seems that -lc_r is set by default in bsd.port.mk for ${PTHREAD_LIBS}.
The reason we use the variable is that it expands differently on
different platforms, so in theory it's always doing the right thing.
Does it mean that we should be able to specify a pthread library in
future as a make option for installing ports?
It means that you should always use the existing method of substituting
any instances of -pthread or -lc_r that are hard coded into a port with
${PTHREAD_LIBS}.
Doug
--
This .signature sanitized for your protection
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, Kevin Oberman wrote:
For which versions of FreeBSD? I just tried using ${PTHREAD_LIBS}, but
the loader could not find any of the pthread routines. I assume it
should be defined in one of the .mk files, but it does not seem to be
on either a current (yesterday) or an older current (9/19).
Sounds to me like you missed a step somewhere... you should follow up on
this topic on -ports.
Doug
--
This .signature sanitized for your protection
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, Matthias Andree wrote:
Doug Barton [EMAIL PROTECTED] writes:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
How about: ${SED} -Ee 's#-l?pthread#${PTHREAD_LIBS}#g' \
That's the one necessary to catch -pthread (such as BerkeleyDB) in
addition to -lpthread.
You should use whatever is appropriate for your port... I just posted an
example from one of mine.
Doug
--
This .signature sanitized for your protection
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
From: Doug Barton [EMAIL PROTECTED]
On Tue, 9 Sep 2003, Matthias Andree wrote:
Doug Barton [EMAIL PROTECTED] writes:
@ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched
@ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \
How about: ${SED} -Ee 's#-l?pthread#${PTHREAD_LIBS}#g' \
That's the one necessary to catch -pthread (such as BerkeleyDB) in
addition to -lpthread.
You should use whatever is appropriate for your port... I just posted an
example from one of mine.
Also look for PTHREAD_{LIBS/CFLAGS} in your ports configure script. Then
all you need to do is set CONFIGURE_ENV in the ports Makefile:
CONFIGURE_ENV+= PTHREAD_LIBS=${PTHREAD_LIBS} \
PTHREAD_CFLAGS=${PTHREAD_CFLAGS}
That's how I fixed the security/amavisd port in my ports tree.
Scot
___
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: -pthread deprecated, but when?
On Tue, 9 Sep 2003, leafy wrote: IMO this deprecation deserves a place in UPDATING. And what are the plans to Do The Right Thing? QT currently does not compile on -current See [EMAIL PROTECTED] They should not be using -pthread on -current. with the -pthread deprecated. -- Dan Eischen ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to [EMAIL PROTECTED]
