Re: Boot failure with r272146

2014-09-26 Thread Ian Lepore
On Fri, 2014-09-26 at 07:40 -0700, Justin Hibbits wrote:
> That fixed it, thanks!
> 
> -Justin

Fix committed as r272181, sorry for the glitch.

-- Ian

> On Sep 26, 2014 6:59 AM, "Ian Lepore"  wrote:
> 
> > On Thu, 2014-09-25 at 20:40 -0700, Justin Hibbits wrote:
> > > With r272146 my SATA controller fails to attach, preventing the kernel
> > > from mounting root.  I've attached a log of as much as dconschat would
> > > allow.  The relevant portion is pcib10:
> > >
> > > atapci0:  mem 0xfa402000-0xfa403fff
> > > at device 12.0 on pci10 pcib1: failed to reserve resource for pcib10
> > > pcib10: failed to allocate initial I/O port window (0-0x,0x10)
> > > atapci0: 0x10 bytes of rid 0x20 res 4 failed (0, 0x).
> > > atapci0: unable to map interrupt
> > > device_attach: atapci0 attach returned 6
> > >
> > > pcib10: allocated memory range (0xfa40-0xfa400fff) for rid 10 of
> > > pci1:3:14:0 atapci0:  mem
> > > 0xfa402000-0xfa403fff at device 12.0 on pci10 pcib1: failed to reserve
> > > resource for pcib10 pcib10: failed to allocate initial I/O port window
> > > (0-0x,0x10) atapci0: 0x10 bytes of rid 0x20 res 4 failed (0,
> > > 0x). atapci0: unable to map interrupt
> > > device_attach: atapci0 attach returned 6
> > > ata0:  mem 0xfa404000-0xfa407fff at device
> > > 13.0 on pci10 ofw_pci mapdev: start fa404000, len 16384
> > > ata0: unable to allocate interrupt
> > > device_attach: ata0 attach returned 6
> > >
> > >
> > > It works fine with r271697 kernel (latest I have booting).  I haven't
> > > yet tried bisecting.
> > >
> > > Hardware is a PowerMac G5 (last generation).
> > >
> > > - Justin
> >
> > Ooops, I think a paste-o in my r272109 caused it.  See if this fixes it.
> >
> > -- Ian
> >
> >
> >
> >
> > Index: sys/powerpc/ofw/ofw_pcibus.c
> > ===
> > --- sys/powerpc/ofw/ofw_pcibus.c(revision 272109)
> > +++ sys/powerpc/ofw/ofw_pcibus.c(working copy)
> > @@ -201,7 +201,7 @@ ofw_pcibus_enum_devtree(device_t dev, u_int domain
> >  * resource list.
> >  */
> > if (dinfo->opd_dinfo.cfg.intpin == 0)
> > -   ofw_bus_intr_to_rl(dev, node,
> > &dinfo->opd_dinfo.resources);
> > +   ofw_bus_intr_to_rl(dev, child,
> > &dinfo->opd_dinfo.resources);
> > }
> >  }
> >
> >
> >
> ___
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Boot failure with r272146

2014-09-26 Thread Justin Hibbits
That fixed it, thanks!

-Justin
On Sep 26, 2014 6:59 AM, "Ian Lepore"  wrote:

> On Thu, 2014-09-25 at 20:40 -0700, Justin Hibbits wrote:
> > With r272146 my SATA controller fails to attach, preventing the kernel
> > from mounting root.  I've attached a log of as much as dconschat would
> > allow.  The relevant portion is pcib10:
> >
> > atapci0:  mem 0xfa402000-0xfa403fff
> > at device 12.0 on pci10 pcib1: failed to reserve resource for pcib10
> > pcib10: failed to allocate initial I/O port window (0-0x,0x10)
> > atapci0: 0x10 bytes of rid 0x20 res 4 failed (0, 0x).
> > atapci0: unable to map interrupt
> > device_attach: atapci0 attach returned 6
> >
> > pcib10: allocated memory range (0xfa40-0xfa400fff) for rid 10 of
> > pci1:3:14:0 atapci0:  mem
> > 0xfa402000-0xfa403fff at device 12.0 on pci10 pcib1: failed to reserve
> > resource for pcib10 pcib10: failed to allocate initial I/O port window
> > (0-0x,0x10) atapci0: 0x10 bytes of rid 0x20 res 4 failed (0,
> > 0x). atapci0: unable to map interrupt
> > device_attach: atapci0 attach returned 6
> > ata0:  mem 0xfa404000-0xfa407fff at device
> > 13.0 on pci10 ofw_pci mapdev: start fa404000, len 16384
> > ata0: unable to allocate interrupt
> > device_attach: ata0 attach returned 6
> >
> >
> > It works fine with r271697 kernel (latest I have booting).  I haven't
> > yet tried bisecting.
> >
> > Hardware is a PowerMac G5 (last generation).
> >
> > - Justin
>
> Ooops, I think a paste-o in my r272109 caused it.  See if this fixes it.
>
> -- Ian
>
>
>
>
> Index: sys/powerpc/ofw/ofw_pcibus.c
> ===
> --- sys/powerpc/ofw/ofw_pcibus.c(revision 272109)
> +++ sys/powerpc/ofw/ofw_pcibus.c(working copy)
> @@ -201,7 +201,7 @@ ofw_pcibus_enum_devtree(device_t dev, u_int domain
>  * resource list.
>  */
> if (dinfo->opd_dinfo.cfg.intpin == 0)
> -   ofw_bus_intr_to_rl(dev, node,
> &dinfo->opd_dinfo.resources);
> +   ofw_bus_intr_to_rl(dev, child,
> &dinfo->opd_dinfo.resources);
> }
>  }
>
>
>
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Boot failure with r272146

2014-09-26 Thread Ian Lepore
On Thu, 2014-09-25 at 20:40 -0700, Justin Hibbits wrote:
> With r272146 my SATA controller fails to attach, preventing the kernel
> from mounting root.  I've attached a log of as much as dconschat would
> allow.  The relevant portion is pcib10:
> 
> atapci0:  mem 0xfa402000-0xfa403fff
> at device 12.0 on pci10 pcib1: failed to reserve resource for pcib10
> pcib10: failed to allocate initial I/O port window (0-0x,0x10)
> atapci0: 0x10 bytes of rid 0x20 res 4 failed (0, 0x).
> atapci0: unable to map interrupt
> device_attach: atapci0 attach returned 6
> 
> pcib10: allocated memory range (0xfa40-0xfa400fff) for rid 10 of
> pci1:3:14:0 atapci0:  mem
> 0xfa402000-0xfa403fff at device 12.0 on pci10 pcib1: failed to reserve
> resource for pcib10 pcib10: failed to allocate initial I/O port window
> (0-0x,0x10) atapci0: 0x10 bytes of rid 0x20 res 4 failed (0,
> 0x). atapci0: unable to map interrupt
> device_attach: atapci0 attach returned 6
> ata0:  mem 0xfa404000-0xfa407fff at device
> 13.0 on pci10 ofw_pci mapdev: start fa404000, len 16384
> ata0: unable to allocate interrupt
> device_attach: ata0 attach returned 6
> 
> 
> It works fine with r271697 kernel (latest I have booting).  I haven't
> yet tried bisecting.
> 
> Hardware is a PowerMac G5 (last generation).
> 
> - Justin

Ooops, I think a paste-o in my r272109 caused it.  See if this fixes it.

-- Ian



Index: sys/powerpc/ofw/ofw_pcibus.c
===
--- sys/powerpc/ofw/ofw_pcibus.c	(revision 272109)
+++ sys/powerpc/ofw/ofw_pcibus.c	(working copy)
@@ -201,7 +201,7 @@ ofw_pcibus_enum_devtree(device_t dev, u_int domain
 		 * resource list.
 		 */
 		if (dinfo->opd_dinfo.cfg.intpin == 0)
-			ofw_bus_intr_to_rl(dev, node, &dinfo->opd_dinfo.resources);
+			ofw_bus_intr_to_rl(dev, child, &dinfo->opd_dinfo.resources);
 	}
 }
 
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"