Re: Build failed: /usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional

2017-11-05 Thread David Wolfskill
On Sun, Nov 05, 2017 at 08:13:27AM -0800, Simon J. Gerraty wrote:
> Simon J. Gerraty  wrote:
> ...
> > I think I might have a fix for that.
> 
> Or rather I know what the issue is - RELDIR isn't defined because
> .CURDIR isn't under SRCTOP,
> if OBJTOP were defined at that point, the fix is trivial, but
> in the current tree that may not be so.
> If .CURDIR isn't under SRCTOP, RELDIR is of questionable value anyway.
> 
> For now you can avoid the error with below.
> 
> Index: share/mk/bsd.obj.mk
> ===
> --- share/mk/bsd.obj.mk   (revision 325436)
> +++ share/mk/bsd.obj.mk   (working copy)
> @@ -85,7 +85,7 @@
>  CANONICALOBJDIR:=/usr/obj${.CURDIR}
>  .endif
>  
> -.if defined(SRCTOP) && \
> +.if defined(RELDIR) && \
>  (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == /${RELDIR})
>  .error .OBJDIR incorrectly set to /${RELDIR}
>  .endif
> 

I had checked the svn-head before I saw the above, and noted bdrewery@'s
mention of:

Index: share/mk/bsd.obj.mk
===
--- share/mk/bsd.obj.mk (revision 325433)
+++ share/mk/bsd.obj.mk (working copy)
@@ -85,7 +85,7 @@
 CANONICALOBJDIR:=/usr/obj${.CURDIR}
 .endif
 
-.if defined(SRCTOP) && \
+.if defined(SRCTOP) && defined(RELDIR) && \
 (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == /${RELDIR})
 .error .OBJDIR incorrectly set to /${RELDIR}
 .endif


which I just tried, and that got through the issue:

FreeBSD g1-252.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #3  
r325433M/325433:1200052: Sun Nov  5 04:27:43 PST 2017 
r...@g1-252.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY  amd64


Peace,
david
-- 
David H. Wolfskill  da...@catwhisker.org
Unsubstantiated claims of "Fake News" are evidence that the claimant lies again.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.


signature.asc
Description: PGP signature


Re: Build failed: /usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional

2017-11-05 Thread Simon J. Gerraty
Simon J. Gerraty  wrote:

> David Wolfskill  wrote:
> > ===>  Building for nvidia-driver-340-340.102
> > ===> src (all)
> > make[6]: "/usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional 
> > (defined(SRCTOP) &&  (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == 
> > /${RELDIR}))
> > make[6]: Fatal errors encountered -- cannot continue
> > make[6]: stopped in 
> > /common/S4/obj/usr/src/amd64.amd64/sys/CANARY/common/ports/x11/nvidia-driver-340/work/NVIDIA-FreeBSD-x86_64-340.102/src
> > *** Error code 1
> 
> I think I might have a fix for that.

Or rather I know what the issue is - RELDIR isn't defined because
.CURDIR isn't under SRCTOP,
if OBJTOP were defined at that point, the fix is trivial, but
in the current tree that may not be so.
If .CURDIR isn't under SRCTOP, RELDIR is of questionable value anyway.

For now you can avoid the error with below.

Index: share/mk/bsd.obj.mk
===
--- share/mk/bsd.obj.mk (revision 325436)
+++ share/mk/bsd.obj.mk (working copy)
@@ -85,7 +85,7 @@
 CANONICALOBJDIR:=/usr/obj${.CURDIR}
 .endif
 
-.if defined(SRCTOP) && \
+.if defined(RELDIR) && \
 (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == /${RELDIR})
 .error .OBJDIR incorrectly set to /${RELDIR}
 .endif
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Build failed: /usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional

2017-11-05 Thread Simon J. Gerraty
David Wolfskill  wrote:
> ===>  Building for nvidia-driver-340-340.102
> ===> src (all)
> make[6]: "/usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional 
> (defined(SRCTOP) &&  (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == 
> /${RELDIR}))
> make[6]: Fatal errors encountered -- cannot continue
> make[6]: stopped in 
> /common/S4/obj/usr/src/amd64.amd64/sys/CANARY/common/ports/x11/nvidia-driver-340/work/NVIDIA-FreeBSD-x86_64-340.102/src
> *** Error code 1

I think I might have a fix for that.

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: Build failed: /usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional

2017-11-05 Thread O. Hartmann
Am Sun, 5 Nov 2017 04:44:44 -0800
David Wolfskill  schrieb:

> This is a self-hosted amd64; the failure was during the (re)build of the
> kernel module for x11/nvidia-driver-340 as the final bit of "make
> buildkernel":
> 
> ...
> >>> stage 3.1: building everything  
> ...
> ===>   nvidia-driver-340-340.102 depends on file: 
> /usr/local/libdata/pkgconfig/xext.pc
> - found ===>  Configuring for nvidia-driver-340-340.102
> ===>  Building for nvidia-driver-340-340.102
> ===> src (all)  
> make[6]: "/usr/src/share/mk/bsd.obj.mk" line 89: Malformed conditional 
> (defined(SRCTOP)
> &&  (${CANONICALOBJDIR} == /${RELDIR} || ${.OBJDIR} == /${RELDIR})) make[6]: 
> Fatal
> errors encountered -- cannot continue make[6]: stopped
> in 
> /common/S4/obj/usr/src/amd64.amd64/sys/CANARY/common/ports/x11/nvidia-driver-340/work/NVIDIA-FreeBSD-x86_64-340.102/src
> *** Error code 1
> 
> Stop.
> make[5]: stopped
> in 
> /common/S4/obj/usr/src/amd64.amd64/sys/CANARY/common/ports/x11/nvidia-driver-340/work/NVIDIA-FreeBSD-x86_64-340.102
> ===> Compilation failed unexpectedly. 
> 
> 
> As noted, the previous successful build in head/amd64 was r325383:
> 
> FreeBSD g1-252.catwhisker.org 12.0-CURRENT FreeBSD 12.0-CURRENT #2
> r325383M/325385:1200052: Sat Nov  4 06:54:48 PDT 2017
> r...@g1-252.catwhisker.org:/common/S4/obj/usr/src/amd64.amd64/sys/CANARY  
> amd64
> 
> 
> I have 'PORTS_MODULES=x11/nvidia-driver-340' in src.conf -- as I'm
> rebuilding the kernel fairly often (daily), it seemed to make sense
> to ensure that the nvidia kmod stays synchronized.
> 
> Any suggestions for evasive maneuvers?  Thanks!
> 
> Peace,
> david

Me, too, here. Reported this yesterday in to src list. It is the very same when 
building
emulators/virtualbox-ose-kmod among x11/nvidia-driver.

-- 
O. Hartmann

Ich widerspreche der Nutzung oder Übermittlung meiner Daten für
Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).


pgpVpqqS0pcHB.pgp
Description: OpenPGP digital signature