Re: Build failure due to block_abi.h

2014-04-04 Thread Marcel Moolenaar
On Apr 4, 2014, at 4:13 PM, David Chisnall wrote: > It turns out that tomorrow happened 12 minutes after this email... > > The attached diff lets it build with -Werror for me with FreeBSD clang and > gcc (with -fblocks and -fno-blocks) and with ports gcc 4.7.3 and doesn't > clutter the code.

Re: Build failure due to block_abi.h

2014-04-04 Thread David Chisnall
It turns out that tomorrow happened 12 minutes after this email... The attached diff lets it build with -Werror for me with FreeBSD clang and gcc (with -fblocks and -fno-blocks) and with ports gcc 4.7.3 and doesn't clutter the code. Please can you test it with Juniper's gcc? David Index: stdl

Re: Build failure due to block_abi.h

2014-04-04 Thread David Chisnall
Hi Marcel, This error is a warning for me with gcc 4.7.3 when I try. With 4.2.1 in the tree, it appears to be silenced by something (or possibly we're using the native blocks code path with gcc and clang doesn't emit that warning in non-blocks mode). We could pull out the structure definition