Re: Is this a typo in if_tap.c?

[Ed Schouten]

2012/11/22 David Xu :
> When I was trying to create a second tap device, kernel crashed.
> Is this patch correct ?

Yes, it looks okay.

Eventually we should get rid of the entire unit numbering thing in
if_tap and if_tun. If we would, we could remove a lot of dead code
from sys/sys/conf.h and sys/kern/kern_conf.c.

-- 
Ed Schouten 
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Is this a typo in if_tap.c?

[Kevin Lo]

On 2012/11/22 17:39, David Xu wrote:

When I was trying to create a second tap device, kernel crashed.
Is this patch correct ?


Index: sys/net/if_tap.c
===
--- sys/net/if_tap.c(revision 243397)
+++ sys/net/if_tap.c(working copy)
@@ -186,7 +186,7 @@
 /* Find any existing device, or allocate new unit number. */
 i = clone_create(&tapclones, &tap_cdevsw, &unit, &dev, 0);
 if (i) {
-dev = make_dev(&tap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
+dev = make_dev(&tap_cdevsw, unit, UID_ROOT, GID_WHEEL, 0600,
 "%s%d", tapname, unit);
 }



The patch looks right to me.

Kevin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Is this a typo?

[Jeroen Ruigrok van der Werven]

-On [20001026 23:30], Julian Elischer ([EMAIL PROTECTED]) wrote:
>in the bus_alloc_resource() man page it states:
>
>
> dev is the device that requests ownership of the resource.  Before
>allo-
> cation, the device is owned by the parent bus.
>
>should that be:
>"Before allocation, the resource is owned by the parent bus."  ?

I will fix the manpage later on today, your requested change is not
entirely accurate, yet.

-- 
Jeroen Ruigrok van der Werven  Network- and systemadministrator
<[EMAIL PROTECTED]>VIA Net.Works The Netherlands
BSD: Technical excellence at its best  http://www.via-net-works.nl
Judge not, that ye be not judged...


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message