Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 06/23/11 17:17, Alexander Motin wrote: Nathan Whitehorn wrote: I'm still having problems with an ATA bus containing a DVD drive and a Zip driver (da). Can't it be some different problem? What are the symptoms? Hanging in run_interrupt_driven_config_hooks, immediately after probing the zip drive, which it didn't do before. Here's the end of a verbose boot: pass0 at ata1 bus 0 scbus1 target 0 lun 0 pass0: Removable CD-ROM SCSI-0 device pass0: 16.700MB/s transfers (WDMA2, ATAPI 12bytes, PIO 65534bytes) pass1 at ata1 bus 0 scbus1 target 1 lun 0 pass1: Removable Direct Access SCSI-0 device pass1: 13.300MB/s transfers (WDMA1, ATAPI 12bytes, PIO 65534bytes) Adding CPU 0, pir=0, awake=1 Waking up CPU 1 (dev=ff83e928) Adding CPU 1, pir=1, awake=1 SMP: AP CPU #1 launched WARNING: WITNESS option enabled, expect reduced performance. (da0:ata1:0:1:0): SCSI status errorG EOM: new disk da(0da0 :ata1:0:1:0):G EROEMA:D nCeAwP AdCiIsTkY (c1d00). CDB: 25 0 0 0 0 0 0 0 0 0 (da0:ata1:0:1:0): CAM status: SCSI Status Error (da0:ata1:0:1:0): SCSI status: Check Condition (da0:ata1:0:1:0): SCSI sense: UNIT ATTENTION asc:29,0 (Power on, reset, or bus device reset occurred) (da0:ata1:0:1:0): Retrying command (per sense data) (cd0:ata1:0:0:0): SCSI status error (cd0:ata1:0:0:0): READ CAPACITY. CDB: 25 0 0 0 0 0 0 0 0 0 (cd0:ata1:0:0:0): CAM status: SCSI Status Error (cd0:ata1:0:0:0): SCSI status: Check Condition (cd0:ata1:0:0:0): SCSI sense: UNIT ATTENTION asc:29,0 (Power on, reset, or bus device reset occurred) (cd0:ata1:0:0:0): Retrying command (per sense data) (da0:ata1:0:1:0): SCSI status error (da0:ata1:0:1:0): READ CAPACITY(10). CDB: 25 0 0 0 0 0 0 0 0 0 (da0:ata1:0:1:0): CAM status: SCSI Status Error (da0:ata1:0:1:0): SCSI status: Check Condition (da0:ata1:0:1:0): SCSI sense: NOT READY asc:3a,0 (Medium not present) (da0:ata1:0:1:0): Error 6, Unretryable error da0 at ata1 bus 0 scbus1 target 1 lun 0 da0: Removable Direct Access SCSI-0 device da0: 13.300MB/s transfers (WDMA1, ATAPI 12bytes, PIO 65534bytes) da0: Attempt to query device size failed: NOT READY, Medium not present [hang] -Nathan ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
Nathan Whitehorn wrote: > I'm still having problems with an ATA bus containing a DVD drive and a > Zip driver (da). Can't it be some different problem? What are the symptoms? -- Alexander Motin ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 06/23/11 16:57, Hartmann, O. wrote: On 06/23/11 18:29, David Wolfskill wrote: On Thu, Jun 23, 2011 at 06:12:54PM +0300, Alexander Motin wrote: ... SVN rev 223443 broke ATAPI support. SVN rev 223475 should fix it. Thanks -- that did resolve the issue for me. Peace, david Me, too. Thanks, Oliver I'm still having problems with an ATA bus containing a DVD drive and a Zip driver (da). -Nathan ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 06/23/11 18:29, David Wolfskill wrote: On Thu, Jun 23, 2011 at 06:12:54PM +0300, Alexander Motin wrote: ... SVN rev 223443 broke ATAPI support. SVN rev 223475 should fix it. Thanks -- that did resolve the issue for me. Peace, david Me, too. Thanks, Oliver ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On Thu, Jun 23, 2011 at 06:12:54PM +0300, Alexander Motin wrote: > ... > SVN rev 223443 broke ATAPI support. SVN rev 223475 should fix it. Thanks -- that did resolve the issue for me. Peace, david -- David H. Wolfskill da...@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. pgp5oemRmqK7r.pgp Description: PGP signature
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
O. Hartmann wrote: > With today's update of sources > (Revision: 223466 > Node Kind: directory > Schedule: normal > Last Changed Author: adrian > Last Changed Rev: 223466 > Last Changed Date: 2011-06-23 08:55:29 +0200 (Do, 23 Jun 2011)) > > FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in > booting the kernel and ending up with the message (repeated every 60 > seconds): > > run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config > > What's up? SVN rev 223443 broke ATAPI support. SVN rev 223475 should fix it. -- Alexander Motin ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On Thu, Jun 23, 2011 at 03:10:20PM +0400, Andrey V. Elsukov wrote: > On 23.06.2011 11:54, O. Hartmann wrote: > > FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in booting > > the kernel and ending up > > with the message (repeated every 60 seconds): > > > > run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config > > > > What's up? > > I backed out r223443 and r223448 and it helped. Are you sure about r223443 one? It seems it does good thing: I still have hang at boot, but no more sleeping in "caplck", only xpt_thrd sleeping (forever) in "ccb_scan". -- http://ache.vniz.net/ pgpGY6bugeZGR.pgp Description: PGP signature
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 06/23/11 13:10, Andrey V. Elsukov wrote:
On 23.06.2011 11:54, O. Hartmann wrote:
FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in booting the
kernel and ending up
with the message (repeated every 60 seconds):
run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
What's up?
I backed out r223443 and r223448 and it helped.
It seems to be the only way out at the moment. The just checked out
codebase doesn't even compile a kernel and fails compiling in the ATH
module:
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain/ah_rd_domains.h:52:4:
note: instantiated from:
W1(_fg) }
^
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain/ah_rd_domains.h:34:45:
note: instantiated from:
(((_a) > 63 && (_a) < 128 ? (((uint64_t) 1)<<((_a)-64)) :
(uint64_t) 0))
^ ~
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain/ah_rd_domains.h:742:21:
warning: shift count is negative
.chan11g_turbo = BM1(T3_2437_2437)},
^
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain/ah_rd_domains.h:35:29:
note: instantiated from:
#define BM1(_fa){ W0(_fa), W1(_fa) }
^
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain/ah_rd_domains.h:34:45:
note: instantiated from:
(((_a) > 63 && (_a) < 128 ? (((uint64_t) 1)<<((_a)-64)) :
(uint64_t) 0))
^ ~
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain.c:170:2:
warning: implicit declaration of function 'HALDEBUG_G' is invalid in C99
[-Wimplicit-function-declaration]
HALDEBUG_G(ah, HAL_DEBUG_REGDOMAIN,
^
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain.c:170:17:
error: use of undeclared identifier 'HAL_DEBUG_REGDOMAIN'; did you mean
'HAL_REG_DOMAIN'?
HALDEBUG_G(ah, HAL_DEBUG_REGDOMAIN,
^
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain.c:612:22:
error: use of undeclared identifier 'HAL_DEBUG_ANY'; did you mean
'HALDEBUG_G'?
HALDEBUG_G(AH_NULL, HAL_DEBUG_ANY,
^
HALDEBUG_G
/usr/src/sys/modules/ath/../../dev/ath/ath_hal/ah_regdomain.c:170:2:
note: 'HALDEBUG_G' declared here
HALDEBUG_G(ah, HAL_DEBUG_REGDOMAIN,
^
434 warnings and 2 errors generated.
*** Error code 1
Stop in /usr/src/sys/modules/ath.
*** Error code 1
Stop in /usr/src/sys/modules.
*** Error code 1
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 23.06.11 09:54, O. Hartmann wrote: With today's update of sources (Revision: 223466 Node Kind: directory Schedule: normal Last Changed Author: adrian Last Changed Rev: 223466 Last Changed Date: 2011-06-23 08:55:29 +0200 (Do, 23 Jun 2011)) FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in booting the kernel and ending up with the message (repeated every 60 seconds): run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config What's up? +1, powerpc64. Would be nice if this could be fixed. Thanks, Andreas ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On Thu, Jun 23, 2011 at 09:54:46AM +0200, O. Hartmann wrote: > With today's update of sources > (Revision: 223466 > Node Kind: directory > Schedule: normal > Last Changed Author: adrian > Last Changed Rev: 223466 > Last Changed Date: 2011-06-23 08:55:29 +0200 (Do, 23 Jun 2011)) > > FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in > booting the kernel and ending up with the message (repeated every 60 > seconds): > > run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config See the same diagnostic loop I notice in thread with subj Re: Exactly that commit (was Re: Latest -current 100% hang at the late boot stage) Try to unplug your CDs/DVDs if you have them. -- http://ache.vniz.net/ ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 23.06.2011 11:54, O. Hartmann wrote: > FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in booting > the kernel and ending up > with the message (repeated every 60 seconds): > > run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config > > What's up? I backed out r223443 and r223448 and it helped. -- WBR, Andrey V. Elsukov signature.asc Description: OpenPGP digital signature
Re: kernel broken: run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config
On 23.06.2011 11:54, O. Hartmann wrote: > With today's update of sources > (Revision: 223466 > Node Kind: directory > Schedule: normal > Last Changed Author: adrian > Last Changed Rev: 223466 > Last Changed Date: 2011-06-23 08:55:29 +0200 (Do, 23 Jun 2011)) > > FreeBSD 9.0-CURRENT/amd64 won't boot anymore. The box gets stuck in booting > the kernel and ending up > with the message (repeated every 60 seconds): > > run_interrupt_driven_hooks: still waiting after XXX seconds for xpt_config I have this problem too. -- WBR, Andrey V. Elsukov signature.asc Description: OpenPGP digital signature
Re: Kernel broken at sysv_msg.c
On Sun, Jan 26, 2003 at 01:58:52PM -0800, walt wrote: > cc1: warnings being treated as errors > /usr/src/sys/kern/sysv_msg.c: In function `msgsnd': > /usr/src/sys/kern/sysv_msg.c:775: warning: cast discards qualifiers from > pointer target type > /usr/src/sys/kern/sysv_msg.c:818: warning: cast discards qualifiers from > pointer target type > *** Error code 1 Get version 1.47 of src/sys/kern/sysv_msg.c -- Craig Rodrigues http://home.attbi.com/~rodrigc [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
On 2002-11-26 19:21, Ray Kohler <[EMAIL PROTECTED]> wrote: > On Wed, Nov 27, 2002 at 02:02:12AM +0200, Giorgos Keramidas wrote: > > $FreeBSD: src/sys/dev/sound/isa/ad1816.c,v 1.24 2002/06/09 14:20:17 hm Exp $ > > [...] > > cg's latest commit (Tuesday) makes the above change and fixes these > errors. I still can't figure out what would make it work only for some > people, especially if we're all doing proper builds. Hum, hum. Apparently I was just lucky. Sorry for the false "but it works" statement. I checked the versions of the files that I have, and the ones that were in cg's commit log: 1.25 +2 -2 src/sys/dev/sound/isa/ad1816.c I had a kernel tree that didn't include the changes :( The buildworld+buildkernel I'm running now should be a better way of checking if anything's broken. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
On Wed, Nov 27, 2002 at 02:02:12AM +0200, Giorgos Keramidas wrote:
> On 2002-11-26 16:33, Gary Jennejohn <[EMAIL PROTECTED]> wrote:
> > Ray Kohler <[EMAIL PROTECTED]> wrote:
> > > On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote:
> > > > CVSuped (2 mins ago) -current kernel is broken:
> > > >
> > > > cc1: warnings being treated as errors
> > > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock':
> > > > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' pointer
> > > > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in
>something not a structure or union
> > > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock':
>/usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' pointer
> > > > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in
>something not a structure or union
> > >
> > > This turns out to be semi-reproduceable. I have this problem but the
> > > committer who made the change can't reproduce it.
> >
> > I have the same problem, [...]
> > The culprit seems to be a change in /sys/dev/sound/pcm/sound.h,
> > where snd_mtx{un}lock() were changed from routines to macros which
> > simply use mtx_{un}lock(). The routines required a ``void *'', but
> > the macros require a ``struct mtx *''.
> >
> > The following drivers still declare the lock to be a ``void *'',
> > which is totally bogus after the above mentioned change:
> >
> > /sys/dev/sound/isa/ad1816.c
> > /sys/dev/sound/isa/mss.c
> > /sys/dev/sound/isa/sbc.c
> > /sys/dev/sound/pci/cmi.c
> > /sys/dev/sound/pci/ds1.c
> > /sys/dev/sound/pci/emu10k1.c
> > /sys/dev/sound/pci/t4dwave.c
> > /sys/dev/sound/pcm/ac97.c
> > /sys/dev/sound/pcm/mixer.c
> > /sys/dev/sound/pcm/sound.c
>
> I successfuly rebuilt a kernel with the following revisions of these
> files.
>
> keramida@gothmog[02:01]/home/keramida> uname -v
> FreeBSD 5.0-CURRENT #1: Tue Nov 26 22:30:31 EET 2002 ...
>
> Can you check that you have the right revisions checked out:
>
> $FreeBSD: src/sys/dev/sound/isa/ad1816.c,v 1.24 2002/06/09 14:20:17 hm Exp $
> $FreeBSD: src/sys/dev/sound/isa/mss.c,v 1.78 2002/04/04 20:56:45 jhb Exp $
> $FreeBSD: src/sys/dev/sound/isa/sbc.c,v 1.35 2002/04/04 20:56:45 jhb Exp $
> $FreeBSD: src/sys/dev/sound/pci/cmi.c,v 1.17 2002/08/23 20:54:32 orion Exp $
> $FreeBSD: src/sys/dev/sound/pci/ds1.c,v 1.27 2002/04/04 20:56:46 jhb Exp $
> $FreeBSD: src/sys/dev/sound/pci/emu10k1.c,v 1.27 2002/11/25 17:07:33 cg Exp $
> $FreeBSD: src/sys/dev/sound/pci/t4dwave.c,v 1.34 2002/10/17 03:45:34 marcel Exp
>$
> $FreeBSD: src/sys/dev/sound/pcm/ac97.c,v 1.27 2002/08/23 06:19:28 orion Exp $
> $FreeBSD: src/sys/dev/sound/pcm/mixer.c,v 1.27 2002/07/25 04:49:45 green Exp $
> $FreeBSD: src/sys/dev/sound/pcm/sound.c,v 1.79 2002/11/25 17:17:42 cg Exp $
cg's latest commit (Tuesday) makes the above change and fixes these
errors. I still can't figure out what would make it work only for some
people, especially if we're all doing proper builds.
--
Ray Kohler <[EMAIL PROTECTED]>
This novel is not to be tossed lightly aside, but to be hurled with
great force.
-- Dorothy Parker
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
On 2002-11-26 16:33, Gary Jennejohn <[EMAIL PROTECTED]> wrote:
> Ray Kohler <[EMAIL PROTECTED]> wrote:
> > On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote:
> > > CVSuped (2 mins ago) -current kernel is broken:
> > >
> > > cc1: warnings being treated as errors
> > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock':
> > > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' pointer
> > > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in
>something not a structure or union
> > > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock':
>/usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' pointer
> > > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in
>something not a structure or union
> >
> > This turns out to be semi-reproduceable. I have this problem but the
> > committer who made the change can't reproduce it.
>
> I have the same problem, [...]
> The culprit seems to be a change in /sys/dev/sound/pcm/sound.h,
> where snd_mtx{un}lock() were changed from routines to macros which
> simply use mtx_{un}lock(). The routines required a ``void *'', but
> the macros require a ``struct mtx *''.
>
> The following drivers still declare the lock to be a ``void *'',
> which is totally bogus after the above mentioned change:
>
> /sys/dev/sound/isa/ad1816.c
> /sys/dev/sound/isa/mss.c
> /sys/dev/sound/isa/sbc.c
> /sys/dev/sound/pci/cmi.c
> /sys/dev/sound/pci/ds1.c
> /sys/dev/sound/pci/emu10k1.c
> /sys/dev/sound/pci/t4dwave.c
> /sys/dev/sound/pcm/ac97.c
> /sys/dev/sound/pcm/mixer.c
> /sys/dev/sound/pcm/sound.c
I successfuly rebuilt a kernel with the following revisions of these
files.
keramida@gothmog[02:01]/home/keramida> uname -v
FreeBSD 5.0-CURRENT #1: Tue Nov 26 22:30:31 EET 2002 ...
Can you check that you have the right revisions checked out:
$FreeBSD: src/sys/dev/sound/isa/ad1816.c,v 1.24 2002/06/09 14:20:17 hm Exp $
$FreeBSD: src/sys/dev/sound/isa/mss.c,v 1.78 2002/04/04 20:56:45 jhb Exp $
$FreeBSD: src/sys/dev/sound/isa/sbc.c,v 1.35 2002/04/04 20:56:45 jhb Exp $
$FreeBSD: src/sys/dev/sound/pci/cmi.c,v 1.17 2002/08/23 20:54:32 orion Exp $
$FreeBSD: src/sys/dev/sound/pci/ds1.c,v 1.27 2002/04/04 20:56:46 jhb Exp $
$FreeBSD: src/sys/dev/sound/pci/emu10k1.c,v 1.27 2002/11/25 17:07:33 cg Exp $
$FreeBSD: src/sys/dev/sound/pci/t4dwave.c,v 1.34 2002/10/17 03:45:34 marcel Exp $
$FreeBSD: src/sys/dev/sound/pcm/ac97.c,v 1.27 2002/08/23 06:19:28 orion Exp $
$FreeBSD: src/sys/dev/sound/pcm/mixer.c,v 1.27 2002/07/25 04:49:45 green Exp $
$FreeBSD: src/sys/dev/sound/pcm/sound.c,v 1.79 2002/11/25 17:17:42 cg Exp $
- Giorgos
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
> -Original Message-
> From: Ray Kohler <[EMAIL PROTECTED]>
> To: Jan Stocker <[EMAIL PROTECTED]>
> Date: Tue, 26 Nov 2002 07:12:37 -0500
> Subject: Re: Kernel broken
>
> On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote:
> > CVSuped (2 mins ago) -current kernel is broken:
> >=20
> > cc1: warnings being treated as errors
> > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock':
> > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *'
> > pointer
> > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in
> > something not a structure or union
> > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock':
> > /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *'
> > pointer
> > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in
> > something not a structure or union
>
This turns out to be semi-reproduceable. I have this problem but the
> committer who made the change can't reproduce it.
>
I have the same problem, and I've deleted my /usr/src and checked it
out new. I've also cvsup'd from 2 different servers - no help. Either
the commit never made it from the repository to the servers or something
else is totally fubar.
The culprit seems to be a change in /sys/dev/sound/pcm/sound.h, where
snd_mtx{un}lock() were changed from routines to macros which simply
use mtx_{un}lock(). The routines required a ``void *'', but the
macros require a ``struct mtx *''.
The following drivers still declare the lock to be a ``void *'',
which is totally bogus after the above mentioned change:
/sys/dev/sound/isa/ad1816.c
/sys/dev/sound/isa/mss.c
/sys/dev/sound/isa/sbc.c
/sys/dev/sound/pci/cmi.c
/sys/dev/sound/pci/ds1.c
/sys/dev/sound/pci/emu10k1.c
/sys/dev/sound/pci/t4dwave.c
/sys/dev/sound/pcm/ac97.c
/sys/dev/sound/pcm/mixer.c
/sys/dev/sound/pcm/sound.c
Changing the ``void *'' to ``struct mtx *'' allows the kernel to be compiled
and sound also works.
This is definitely a show-stopper and should be fixed ASAP, no matter
which change is correct. cg is the last committer who touched the header.
---
Gary Jennejohn / [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Re: Re: Kernel broken
I too could compile successfully last night without any problems.. it fixes the "pcm lock problems when using witness and invariant options ..." atleast for me. dheeraj -Original Message- From: Ray Kohler <[EMAIL PROTECTED]> To: Jan Stocker <[EMAIL PROTECTED]> Date: Tue, 26 Nov 2002 07:12:37 -0500 Subject: Re: Kernel broken On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote: > CVSuped (2 mins ago) -current kernel is broken: > > cc1: warnings being treated as errors > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock': > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' > pointer > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in > something not a structure or union > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock': > /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' > pointer > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in > something not a structure or union This turns out to be semi-reproduceable. I have this problem but the committer who made the change can't reproduce it. -- Ray Kohler <[EMAIL PROTECTED]> Math is like love -- a simple idea but it can get complicated. -- R. Drabek To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
Changing the locks from "void *" to "struct mtx *" seems to fix the problem.
Mark
diff -u -r ../../../../vendor/sys/dev/sound/isa/ad1816.c ./isa/ad1816.c
--- ../../../../vendor/sys/dev/sound/isa/ad1816.c Thu Nov 14 17:00:39 2002
+++ ./isa/ad1816.c Tue Nov 26 13:03:17 2002
@@ -53,7 +53,7 @@
int drq2_rid;
void *ih;
bus_dma_tag_t parent_dmat;
- void *lock;
+ struct mtx *lock;
unsigned int bufsize;
struct ad1816_chinfo pch, rch;
diff -u -r ../../../../vendor/sys/dev/sound/isa/mss.c ./isa/mss.c
--- ../../../../vendor/sys/dev/sound/isa/mss.c Thu Nov 14 17:00:39 2002
+++ ./isa/mss.c Tue Nov 26 13:05:48 2002
@@ -66,7 +66,7 @@
int drq2_rid;
void *ih;
bus_dma_tag_tparent_dmat;
-void *lock;
+struct mtx *lock;
char mss_indexed_regs[MSS_INDEXED_REGS];
char opl_indexed_regs[OPL_INDEXED_REGS];
diff -u -r ../../../../vendor/sys/dev/sound/isa/sbc.c ./isa/sbc.c
--- ../../../../vendor/sys/dev/sound/isa/sbc.c Thu Nov 14 17:00:39 2002
+++ ./isa/sbc.c Tue Nov 26 13:06:04 2002
@@ -64,7 +64,7 @@
void *ih[IRQ_MAX];
- void *lock;
+ struct mtx *lock;
u_int32_t bd_ver;
};
diff -u -r ../../../../vendor/sys/dev/sound/pci/cmi.c ./pci/cmi.c
--- ../../../../vendor/sys/dev/sound/pci/cmi.c Thu Nov 14 17:00:39 2002
+++ ./pci/cmi.c Tue Nov 26 13:06:19 2002
@@ -107,7 +107,7 @@
struct resource *reg, *irq;
int regid, irqid;
void*ih;
- void*lock;
+ struct mtx *lock;
int spdif_enabled;
unsigned intbufsz;
diff -u -r ../../../../vendor/sys/dev/sound/pci/ds1.c ./pci/ds1.c
--- ../../../../vendor/sys/dev/sound/pci/ds1.c Thu Nov 14 17:00:40 2002
+++ ./pci/ds1.c Tue Nov 26 13:06:36 2002
@@ -116,7 +116,7 @@
struct resource *reg, *irq;
int regid, irqid;
void*ih;
- void*lock;
+ struct mtx *lock;
void *regbase;
u_int32_t *pbase, pbankbase, pbanksize;
diff -u -r ../../../../vendor/sys/dev/sound/pci/emu10k1.c ./pci/emu10k1.c
--- ../../../../vendor/sys/dev/sound/pci/emu10k1.c Tue Nov 26 09:20:58 2002
+++ ./pci/emu10k1.c Tue Nov 26 13:06:49 2002
@@ -96,7 +96,7 @@
struct resource *reg, *irq;
void*ih;
- void*lock;
+ struct mtx *lock;
unsigned int bufsz;
int timer, timerinterval;
diff -u -r ../../../../vendor/sys/dev/sound/pci/t4dwave.c ./pci/t4dwave.c
--- ../../../../vendor/sys/dev/sound/pci/t4dwave.c Thu Nov 14 17:00:40 2002
+++ ./pci/t4dwave.c Tue Nov 26 13:07:10 2002
@@ -81,7 +81,7 @@
int regtype, regid, irqid;
void *ih;
- void *lock;
+ struct mtx *lock;
u_int32_t playchns;
unsigned int bufsz;
diff -u -r ../../../../vendor/sys/dev/sound/pcm/ac97.c ./pcm/ac97.c
--- ../../../../vendor/sys/dev/sound/pcm/ac97.c Thu Nov 14 17:00:40 2002
+++ ./pcm/ac97.cTue Nov 26 13:07:27 2002
@@ -55,7 +55,7 @@
u_int32_t flags;
struct ac97mixtable_entry mix[32];
char name[AC97_NAMELEN];
- void *lock;
+ struct mtx *lock;
};
struct ac97_codecid {
diff -u -r ../../../../vendor/sys/dev/sound/pcm/mixer.c ./pcm/mixer.c
--- ../../../../vendor/sys/dev/sound/pcm/mixer.cThu Nov 14 17:00:40 2002
+++ ./pcm/mixer.c Tue Nov 26 13:07:52 2002
@@ -47,7 +47,7 @@
u_int32_t recsrc;
u_int16_t level[32];
char name[MIXER_NAMELEN];
- void *lock;
+ struct mtx *lock;
};
static u_int16_t snd_mixerdefaults[SOUND_MIXER_NRDEVICES] = {
diff -u -r ../../../../vendor/sys/dev/sound/pcm/sound.c ./pcm/sound.c
--- ../../../../vendor/sys/dev/sound/pcm/sound.cTue Nov 26 09:20:59 2002
+++ ./pcm/sound.c Tue Nov 26 13:08:08 2002
@@ -50,7 +50,7 @@
char status[SND_STATUSLEN];
struct sysctl_ctx_list sysctl_tree;
struct sysctl_oid *sysctl_tree_top;
- void *lock;
+ struct mtx *lock;
};
devclass_t pcm_devclass;
On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote:
> CVSuped (2 mins ago) -current kernel is broken:
>
> cc1: warnings being treated as errors
> /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock':
> /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *'
> pointer
> /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in
> something not a structure or union
> /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock':
> /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *'
> pointer
> /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in
> something not a structure or union
>
> Jan
>
>
>
>
> To Unsubscribe: send mail to [EMAIL PROTECTED]
> with "unsubscribe freebsd-current" in the body of th
Re: Kernel broken
On Tue, Nov 26, 2002 at 12:53:39PM +0100, Jan Stocker wrote: > CVSuped (2 mins ago) -current kernel is broken: > > cc1: warnings being treated as errors > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_lock': > /usr/src/sys/dev/sound/isa/ad1816.c:81: warning: dereferencing `void *' > pointer > /usr/src/sys/dev/sound/isa/ad1816.c:81: request for member `mtx_lock' in > something not a structure or union > /usr/src/sys/dev/sound/isa/ad1816.c: In function `ad1816_unlock': > /usr/src/sys/dev/sound/isa/ad1816.c:87: warning: dereferencing `void *' > pointer > /usr/src/sys/dev/sound/isa/ad1816.c:87: request for member `mtx_lock' in > something not a structure or union This turns out to be semi-reproduceable. I have this problem but the committer who made the change can't reproduce it. -- Ray Kohler <[EMAIL PROTECTED]> Math is like love -- a simple idea but it can get complicated. -- R. Drabek To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (devfs maybe?)
that fixes it.. thanks On Fri, 25 Oct 2002, Poul-Henning Kamp wrote: > > Please try the rev 1.418 of vfs_subr.c > > >> db> tr > >> v_incr_usecount(c1d76cb8,,c037b472,863,cc34a92c) at > >> v_incr_usecount+0x48vrele(c1d76cb8,c1c90a00,c036cc7a,6,100) at > >> vrele+0xb0 > >> addaliasu(c1d76cb8,402,c1cb6200,cc34a9c0,c1d73b00) at addaliasu+0x1ad > >> devfs_allocv(c1d8f880,c1c90a00,cc34ac38,c0f26340,c01e6fe0) at > >> devfs_allocv+0xee > >> devfs_lookupx(cc34ab50,1,0,c0f26340,6) at devfs_lookupx+0x58f > >> devfs_lookup(cc34ab50,c0f26340,0,c0f26340,c037b472) at devfs_lookup+0x4b > >> lookup(cc34ac24,0,c037ad9a,a4,cc34abb8) at lookup+0x302 > >> namei(cc34ac24,c01bb4bd,c03fbac0,1,c037264a) at namei+0x24e > >> stat(c0f26340,cc34ad10,c039bed6,409,2) at stat+0x52 > >> syscall(2f,2f,2f,8057e86,805b52f) at syscall+0x28e > >> Xint0x80_syscall() at Xint0x80_syscall+0x1d > > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > [EMAIL PROTECTED] | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (devfs maybe?)
Please try the rev 1.418 of vfs_subr.c >> db> tr >> v_incr_usecount(c1d76cb8,,c037b472,863,cc34a92c) at >> v_incr_usecount+0x48vrele(c1d76cb8,c1c90a00,c036cc7a,6,100) at >> vrele+0xb0 >> addaliasu(c1d76cb8,402,c1cb6200,cc34a9c0,c1d73b00) at addaliasu+0x1ad >> devfs_allocv(c1d8f880,c1c90a00,cc34ac38,c0f26340,c01e6fe0) at >> devfs_allocv+0xee >> devfs_lookupx(cc34ab50,1,0,c0f26340,6) at devfs_lookupx+0x58f >> devfs_lookup(cc34ab50,c0f26340,0,c0f26340,c037b472) at devfs_lookup+0x4b >> lookup(cc34ac24,0,c037ad9a,a4,cc34abb8) at lookup+0x302 >> namei(cc34ac24,c01bb4bd,c03fbac0,1,c037264a) at namei+0x24e >> stat(c0f26340,cc34ad10,c039bed6,409,2) at stat+0x52 >> syscall(2f,2f,2f,8057e86,805b52f) at syscall+0x28e >> Xint0x80_syscall() at Xint0x80_syscall+0x1d -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Re: kernel broken? (devfs maybe?)
yep that fixes it.. On Thu, 24 Oct 2002, Andrew Gallatin wrote: > > Try backing out phk's src/sys/kern/vfs_subr.c 1.416 > Does that help? > > Drew > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Re: kernel broken? (devfs maybe?)
Try backing out phk's src/sys/kern/vfs_subr.c 1.416 Does that help? Drew To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (devfs maybe?)
nope.. not mine..(just backed everything out here and retested.. still got it..) don't know if the lock reversal is related... That may be an orthogonal bug.. On Thu, 24 Oct 2002, Julian Elischer wrote: > > I thought this might be one on mine, but > it doesn't look like mine.. > > (I'm busy recompiling a version with my latest changes backed out > to check though.. in the mean while.. if anyone wants to claim > this) > > IPsec: Initialized Security Association Processing. > ad0: 9541MB [19386/16/63] at ata0-master UDMA100 > acd0: CDROM at ata1-master PIO4 > Mounting root from ufs:/dev/ad0s1a > Enter full pathname of shell or RETURN for /bin/sh: > # fsck -p > lock order reversal > 1st 0xc0420400 spechash (spechash) @ ../../../kern/vfs_subr.c:1962 > 2nd 0xc1d6f228 process lock (process lock) @ > ../../../i386/i386/trap.c:731 > > > Fatal trap 12: page fault while in kernel mode > fault virtual address = 0x78 > fault code= supervisor write, page not present > instruction pointer = 0x8:0xc0217f58 > stack pointer = 0x10:0xcc34a8d8 > frame pointer = 0x10:0xcc34a8f0 > code segment = base 0x0, limit 0xf, type 0x1b > = DPL 0, pres 1, def32 1, gran 1 > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 42 (fsck) > kernel: type 12 trap, code=0 > Stopped at v_incr_usecount+0x48: addl%esi,0x78(%eax) > db> Context switches not allowed in the debugger. > db> tr > v_incr_usecount(c1d76cb8,,c037b472,863,cc34a92c) at > v_incr_usecount+0x48vrele(c1d76cb8,c1c90a00,c036cc7a,6,100) at > vrele+0xb0 > addaliasu(c1d76cb8,402,c1cb6200,cc34a9c0,c1d73b00) at addaliasu+0x1ad > devfs_allocv(c1d8f880,c1c90a00,cc34ac38,c0f26340,c01e6fe0) at > devfs_allocv+0xee > devfs_lookupx(cc34ab50,1,0,c0f26340,6) at devfs_lookupx+0x58f > devfs_lookup(cc34ab50,c0f26340,0,c0f26340,c037b472) at devfs_lookup+0x4b > lookup(cc34ac24,0,c037ad9a,a4,cc34abb8) at lookup+0x302 > namei(cc34ac24,c01bb4bd,c03fbac0,1,c037264a) at namei+0x24e > stat(c0f26340,cc34ad10,c039bed6,409,2) at stat+0x52 > syscall(2f,2f,2f,8057e86,805b52f) at syscall+0x28e > Xint0x80_syscall() at Xint0x80_syscall+0x1d > > > > > > To Unsubscribe: send mail to [EMAIL PROTECTED] > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken in ip_fw2.c
Dennis Kristensen wrote: > Hi! > > Looks like kernel is broken without the bellow patch. The below patch is incorrect, I just forgot to commit changes to ip_fw.h. This should be fixed now. Cheers, Maxime To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken(?) at vfs_mount.c
> cc1: warnings being treated as errors > /usr/src/sys/kern/vfs_mount.c: In function `checkdirs': > /usr/src/sys/kern/vfs_mount.c:1141: warning: implicit declaration of function >`vrefcnt' Oops, I commited this file before I commited a dependency. Please cvsup again. Specifically, you need the new vnode.h and vfs_subr.c Thanks, Jeff To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
Xcuse me...overread it... Jan On Wed, 2001-12-26 at 19:46, Maxime Henrion wrote: > Jan Stocker wrote: > > Sources from: Dec, 26 11:28 CET > > > > linking kernel > > procfs.o: In function `procfs_init': > > procfs.o(.text+0x1ac): undefined reference to `pfs_create_link' > > procfs.o(.text+0x1c0): undefined reference to `pfs_create_dir' > > procfs.o(.text+0x1db): undefined reference to `pfs_create_file' > > procfs.o(.text+0x1f4): undefined reference to `pfs_create_file' > [...] > > Please read /usr/src/UPDATING : > > 20011203: > The procfs pseudo-filesystem has now been converted to use the > pseudofs framework. If you have 'options PROCFS' in your > kernel config, you'll need to add 'options PSEUDOFS' if it's > not there already. > > Maxime > -- > Don't be fooled by cheap finnish imitations ; BSD is the One True Code To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: Kernel broken
Jan Stocker wrote: > Sources from: Dec, 26 11:28 CET > > linking kernel > procfs.o: In function `procfs_init': > procfs.o(.text+0x1ac): undefined reference to `pfs_create_link' > procfs.o(.text+0x1c0): undefined reference to `pfs_create_dir' > procfs.o(.text+0x1db): undefined reference to `pfs_create_file' > procfs.o(.text+0x1f4): undefined reference to `pfs_create_file' [...] Please read /usr/src/UPDATING : 20011203: The procfs pseudo-filesystem has now been converted to use the pseudofs framework. If you have 'options PROCFS' in your kernel config, you'll need to add 'options PSEUDOFS' if it's not there already. Maxime -- Don't be fooled by cheap finnish imitations ; BSD is the One True Code To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken in two places
Well, I deleted /usr/src/sys/, cvsup'd again, and now make depend works. Who knows ... -- Michael D. Harnois[EMAIL PROTECTED] Redeemer Lutheran Church Washburn, Iowa Be radical, be as radical as you can ... because radicals empower liberals. --John Preston To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken in two places
Dima Dorfman <[EMAIL PROTECTED]> said: > Are you compiling without "options INET"? No, that I could have figured out. -- Michael D. Harnois[EMAIL PROTECTED] Redeemer Lutheran Church Washburn, Iowa CYNIC, n. A blackguard whose faulty vision sees things as they are, not as they ought to be. -- Ambrose Bierce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken in two places
Michael Harnois <[EMAIL PROTECTED]> writes: > Unless I missed a heads-up somewhere ... > > mkdep -f .depend -a -nostdinc -D_KERNEL -DKLD_MODULE -I- -I. -I@ -I@/dev -I > @/../include /usr/src/sys/modules/if_sl/../../net/if_sl.c /usr/src/sys/modul > es/if_sl/../../net/slcompress.c > /usr/src/sys/modules/if_sl/../../net/if_sl.c:96: #error "Huh? Slip without in et?" Are you compiling without "options INET"? > > and then, if I overcome that breakage by brute force ... > > cc -c -O -pipe -march=pentiumpro -Wall -Wredundant-decls -Wnested-externs -Ws > trict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual > -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../dev -I../../../ > include -I../../contrib/dev/acpica/Subsystem/Include -D_KERNEL -include opt_ > global.h -elf -mpreferred-stack-boundary=2 ../../kern/tty_snoop.c > ../../kern/tty_snoop.c: In function `snp_detach': > ../../kern/tty_snoop.c:394: structure has no member named `snp_olddisc' > ../../kern/tty_snoop.c: In function `snpioctl': > ../../kern/tty_snoop.c:477: structure has no member named `snp_olddisc' > *** Error code 1 This is my fault. I've fixed it. Sorry, everybody :-/ Dima Dorfman [EMAIL PROTECTED] > > > -- > Michael D. Harnois[EMAIL PROTECTED] > Redeemer Lutheran Church Washburn, Iowa > Some folks you don't have to satirize, > you just quote 'em. --Tom Paxton > > To Unsubscribe: send mail to [EMAIL PROTECTED] > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On 12 Okt, [EMAIL PROTECTED] wrote: > You can try the patch in (my) PR 'kern/14278'. Works. Bye, Alexander. -- What do you mean, my birth certificate expired? http://netchild.home.pages.de A.Leidinger+Home @ WJPServer.CS.Uni-SB.de To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> Alexander Leidinger <[EMAIL PROTECTED]> wrote: > On 11 Oct, Bill Fumerola wrote: > >>> #makeoptionsCONF_CFLAGS=-fno-builtin >> >> We have enough breakages with the _documented_ kernel options that we > > As Bruce Evans already said, It's documented. > >> don't need to go hunting down oddities. :> > > Have you seen the '#' in "#makeoptions"? I assume a '#' in the config > file means: "Hey config, don't look at this!". Please correct me if I'm > wrong. > > I've tested both variants with and without '#'. After editing the file I > did a 'config -r CONFIG', 'cd ../../compile/CONFIG', 'make depend', > 'make'. I get the error independently of CONF_FLAGS. > Back at home I do it again if you want. Yes, in your case the errors are independent from this "makeoptions ..." line. But you are linking kernel.debug, so the (undefined in kernel) 'abs' function shows itself. You can try the patch in (my) PR 'kern/14278'. N.Dudorov To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On 11 Oct, Bill Fumerola wrote: >> #makeoptions CONF_CFLAGS=-fno-builtin > > We have enough breakages with the _documented_ kernel options that we As Bruce Evans already said, It's documented. > don't need to go hunting down oddities. :> Have you seen the '#' in "#makeoptions"? I assume a '#' in the config file means: "Hey config, don't look at this!". Please correct me if I'm wrong. I've tested both variants with and without '#'. After editing the file I did a 'config -r CONFIG', 'cd ../../compile/CONFIG', 'make depend', 'make'. I get the error independently of CONF_FLAGS. Back at home I do it again if you want. Bye, Alexander. -- http://netchild.home.pages.de A.Leidinger @ WJPServer.CS.Uni-SB.de To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
> >>Such an errors results from (uncommented) kernel option ^^^ > >> > >> #makeoptions CONF_CFLAGS=-fno-builtin > > > > We have enough breakages with the _documented_ kernel options that we > > don't need to go hunting down oddities. :> It's well documented. -fno-builtin is a standard gcc option, and CONF_FLAGS and its use of -fno-builtin is documented in 4 lines in LINT. > Does it mean that I throw away my PR with patches to > the 'newpcm' files which add 'abs' definition and therefore > make it possible to make kernel with > > makeoptions CONF_CFLAGS=-fno-builtin ? No, some patches are needed. I think pcm should use explicit code like (x < 0 : -x : x). It only calls abs() twice. > P.S. It seems to me that this option (or its absent) can > severely influence kernel run time efficience (not in the 'abs' > case, of course ;-). I used to use it for all kernels as a side effect of putting it in /etc/make.conf so that it gets used for LINT. Any efficiency effects seem to be limited to the +-0.1% range. The only place where it is likely to make much difference is for bcopy() vs memcpy() on some machines. The builtin memcpy() can be pessimal. This is supposed to be handled by using bcopy() for large copies and memcpy() (only) for small, fix-sized copies. The builtin memcpy() tends to be better for small copies. Since using memcpy() in the kernel is correct in some cases, it is backed up by a function to handle cases where there is no inline memcpy(). Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: > Such an errors results from (uncommented) kernel option > > #makeoptions CONF_CFLAGS=-fno-builtin This option is used in LINT to help expose such errors before they are committed. > because there is NO 'abs' function/macro in this files > (ac97.c, channel.c and mss.c) and they can be only compiled using > gcc's builtin 'abs' abs() doesn't exist in the kernel, so it shouldn't be used. > > linking kernel.debug > > ac97.o: In function `ac97_setmixer': > > /usr/src/sys/compile/WORK/../../dev/pcm/ac97.c(.text+0x18d): undefined reference >to `abs' > > channel.o: In function `chn_setblocksize': Test coverage of pcm in LINT is broken by not configuring pcm because of conflicts with the old sound drivers. Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > > We have enough breakages with the _documented_ kernel options that we > > don't need to go hunting down oddities. :> > > Does it mean that I throw away my PR with patches to > the 'newpcm' files which add 'abs' definition and therefore > make it possible to make kernel with > > makeoptions CONF_CFLAGS=-fno-builtin ? > > P.S. It seems to me that this option (or its absent) can > severely influence kernel run time efficience (not in the 'abs' > case, of course ;-). No. I was merely joking around. We welcome your patches. -- - bill fumerola - [EMAIL PROTECTED] - BF1560 - computer horizons corp - - ph:(800) 252-2421 - [EMAIL PROTECTED] - [EMAIL PROTECTED] - To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> Bill Fumerola <[EMAIL PROTECTED]> wrote: > On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > >> In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: >> Such an errors results from (uncommented) kernel option >> >> #makeoptions CONF_CFLAGS=-fno-builtin > > We have enough breakages with the _documented_ kernel options that we > don't need to go hunting down oddities. :> Does it mean that I throw away my PR with patches to the 'newpcm' files which add 'abs' definition and therefore make it possible to make kernel with makeoptions CONF_CFLAGS=-fno-builtin ? P.S. It seems to me that this option (or its absent) can severely influence kernel run time efficience (not in the 'abs' case, of course ;-). N.Dudorov To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
On Tue, 12 Oct 1999 [EMAIL PROTECTED] wrote: > In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: > Such an errors results from (uncommented) kernel option > > #makeoptions CONF_CFLAGS=-fno-builtin We have enough breakages with the _documented_ kernel options that we don't need to go hunting down oddities. :> -- - bill fumerola - [EMAIL PROTECTED] - BF1560 - computer horizons corp - - ph:(800) 252-2421 - [EMAIL PROTECTED] - [EMAIL PROTECTED] - To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: kernel broken? (pcm)
In <[EMAIL PROTECTED]> [EMAIL PROTECTED] wrote: Such an errors results from (uncommented) kernel option #makeoptionsCONF_CFLAGS=-fno-builtin because there is NO 'abs' function/macro in this files (ac97.c, channel.c and mss.c) and they can be only compiled using gcc's builtin 'abs' N.Dudorov > Hi, > > linking kernel.debug > ac97.o: In function `ac97_setmixer': > /usr/src/sys/compile/WORK/../../dev/pcm/ac97.c(.text+0x18d): undefined reference to >`abs' > channel.o: In function `chn_setblocksize': > /usr/src/sys/compile/WORK/../../dev/pcm/channel.c:712: undefined reference to `abs' > mss.o: In function `mss_speed': > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x182d): undefined reference >to `abs' > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x183f): undefined reference >to `abs' > /usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c(.text+0x1869): undefined reference >to `abs' > mss.o(.text+0x187b):/usr/src/sys/compile/WORK/../../dev/pcm/isa/mss.c: more >undefined references to `abs' follow > *** Error code 1 > 1 error > > I tried several cvsups since the morning. > > Kernelconfig attached. > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
