Re: Mbuf leak in if_lagg.c

2015-03-27 Thread Alexandre Martins
Le jeudi 26 mars 2015, 23:10:49 Andrey V. Elsukov a écrit : On 26.03.2015 22:42, Andrey V. Elsukov wrote: If lp_detaching is non 0, the mbuf pointer is set to NULL without m_freem it. Can you look at this ? Hi, what you thing about this patch? lp_detaching can be non zero in

Re: Mbuf leak in if_lagg.c

2015-03-26 Thread Adrian Chadd
Hi! Please file a bug! https://bugs.freebsd.org/submit/ Thanks! -a On 19 March 2015 at 09:31, Alexandre Martins alexandre.mart...@stormshield.eu wrote: Hi ! I found a leak of mbuf in the lagg driver : https://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?view=annotate#l1672

Re: Mbuf leak in if_lagg.c

2015-03-26 Thread Andrey V. Elsukov
On 19.03.2015 19:31, Alexandre Martins wrote: Hi ! I found a leak of mbuf in the lagg driver : https://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?view=annotate#l1672 -=-=-=-=-=-=-=-=-=-=- m = (lp-lp_detaching == 0) ? lagg_proto_input(sc, lp, m) : NULL; -=-=-=-=-=-=-=-=-=-=- If

Re: Mbuf leak in if_lagg.c

2015-03-26 Thread Andrey V. Elsukov
On 26.03.2015 22:42, Andrey V. Elsukov wrote: If lp_detaching is non 0, the mbuf pointer is set to NULL without m_freem it. Can you look at this ? Hi, what you thing about this patch? lp_detaching can be non zero in case of parent interface departure. So I don't see the reason to call