Re: PUC_FASTINTR broken
In message [EMAIL PROTECTED], Bruce Evans writes: % RCS file: /home/ncvs/src/sys/dev/puc/puc.c,v % Working file: puc.c % head: 1.14 % ... % % revision 1.14 % date: 2002/09/03 11:22:13; author: phk; state: Exp; lines: +3 -10 % Fix interrupt registration: % % PUC devices live on pccard or pci so INTR_FAST is never really an option. % Don't try to register the interrupt as fast and don't allow the children % to do so either. % INTR_FAST is an option for pci devices. It was configured (not quite right) by the PUC_FASTINTR option, which should work just as well as the similar but much older CY_PCI_FASTINTR option (perfectly if the interrupt is not shared). It doesn't work right if the puc manages to register the interrupt as FAST before we realize that it is shared. This change blows away the support for that option without even removing the option from conf/options, conf/NOTES or puc.4, and without even noting approval of the author of the code. I have yet to clean that fluff. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: PUC_FASTINTR broken
On Wed, 4 Sep 2002, Poul-Henning Kamp wrote: In message [EMAIL PROTECTED], Bruce Evans writes: INTR_FAST is an option for pci devices. It was configured (not quite right) by the PUC_FASTINTR option, which should work just as well as the similar but much older CY_PCI_FASTINTR option (perfectly if the interrupt is not shared). It doesn't work right if the puc manages to register the interrupt as FAST before we realize that it is shared. That is not a problem, since it is the configurer's responsibility to not use PUC_FASTINTR if it would not work. PUC_FASTINTR exists precisely to let the configurer make the correct choice, sint the driver and new-bus cannot. This change blows away the support for that option without even removing the option from conf/options, conf/NOTES or puc.4, and without even noting approval of the author of the code. I have yet to clean that fluff. Please don't. Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
