Re: Patch test review: vop_stdaccess()

2000-08-17 Thread Poul-Henning Kamp
In message [EMAIL PROTECTED], Boris Pop ov writes: On Wed, 16 Aug 2000, Poul-Henning Kamp wrote: Please test and review this patch: http://phk.freebsd.dk/patch/vop_stdaccess.patch Looks fine to me except vop_stdaccess() itself. Since VREAD, VWRITE and VEXEC bits are carefully layed

Re: Patch test review: vop_stdaccess()

2000-08-17 Thread Bruce Evans
On Thu, 17 Aug 2000, Boris Popov wrote: On Wed, 16 Aug 2000, Poul-Henning Kamp wrote: Please test and review this patch: http://phk.freebsd.dk/patch/vop_stdaccess.patch Looks fine to me except vop_stdaccess() itself. vop_stdaccess() is badly named. It is not a vop function

Re: Patch test review: vop_stdaccess()

2000-08-16 Thread Alfred Perlstein
* Poul-Henning Kamp [EMAIL PROTECTED] [000816 14:52] wrote: Please test and review this patch: http://phk.freebsd.dk/patch/vop_stdaccess.patch Not tested, but looks good, I'd like to see it applied. -Alfred To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe

Re: Patch test review: vop_stdaccess()

2000-08-16 Thread Boris Popov
On Wed, 16 Aug 2000, Poul-Henning Kamp wrote: Please test and review this patch: http://phk.freebsd.dk/patch/vop_stdaccess.patch Looks fine to me except vop_stdaccess() itself. Since VREAD, VWRITE and VEXEC bits are carefully layed this function can be rewritten to use single shift