Re: Please review: PC-Card melody beep code.

[Warner Losh]

In message <[EMAIL PROTECTED]> Tony Finch writes:
: I tried this on 4.1.1-STABLE with two pccards: a D-Link DE660 and a
: Lucent Wavelan card. The de card workedd fine, but the success melody
: beep for the wi card was several times slower than it should be. I can
: get more information if you need it.

I've noticed this on the unpackted -current as well.  Something in wi
keeps timeouts from firing quickly enough, or at least that's my guess.

Warner


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Re: Please review: PC-Card melody beep code.

[Rich Wales]

It looks like you have the "duration" and "pitch" elements reversed
in your "tone" structure.

Rich Wales [EMAIL PROTECTED] http://www.webcom.com/richw/



. . .

+struct tone {
+int duration;
+int pitch;
+};

. . .

+static struct tone success_melody_beep[] = {
+   {1200,7}, {1000,7}, { 800,   15}, {NULL, NULL}
+};

. . .





To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Re: Please review: PC-Card melody beep code.

[Tony Finch]

MIHIRA Sanpei Yoshiro <[EMAIL PROTECTED]> wrote:
>
>  This is PC-Card melody beep code for
>5-current(/sys/pccard/pccard_beep.c) from PAO3.  This patch does not
>need to change sys/i386/isa/clock.c.
>
>Any problems, please let me know.

I tried this on 4.1.1-STABLE with two pccards: a D-Link DE660 and a
Lucent Wavelan card. The de card workedd fine, but the success melody
beep for the wi card was several times slower than it should be. I can
get more information if you need it.

Tony.
-- 
en oeccget g mtcaaf.a.n.finch
v spdlkishrhtewe y[EMAIL PROTECTED]
eatp o v eiti i d.[EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message