Re: RFC: please put back spare fields in struct ifnet (removed in svn 270870)

2014-09-09 Thread Gleb Smirnoff
Luigi, On Tue, Sep 09, 2014 at 07:59:42PM +0200, Luigi Rizzo wrote: L> My point is preserving support for out of tree modules, L> and spares (or spare accessors, or the ABI you mention below; L> something that gets you quickly a vendor specific pointer L> from an opaque ifnet) were useful for th

Re: RFC: please put back spare fields in struct ifnet (removed in svn 270870)

2014-09-09 Thread Luigi Rizzo
On Tue, Sep 9, 2014 at 2:17 PM, Gleb Smirnoff wrote: > Luigi, > > On Tue, Sep 09, 2014 at 01:01:13PM +0200, Luigi Rizzo wrote: > L> > The harm is obvious: someone commits code that _uses_ spare field > L> > without assigning it a new name. Spare field is a placeholder. Of > L> > course you can

Re: RFC: please put back spare fields in struct ifnet (removed in svn 270870)

2014-09-09 Thread Gleb Smirnoff
Luigi, On Tue, Sep 09, 2014 at 01:01:13PM +0200, Luigi Rizzo wrote: L> > The harm is obvious: someone commits code that _uses_ spare field L> > without assigning it a new name. Spare field is a placeholder. Of L> > course you can use it while you experiment. However, I don't see L> > problem wit

Re: RFC: please put back spare fields in struct ifnet (removed in svn 270870)

2014-09-09 Thread Luigi Rizzo
On Tue, Sep 9, 2014 at 12:37 PM, Gleb Smirnoff wrote: > Luigi, > > On Tue, Sep 09, 2014 at 12:13:42PM +0200, Luigi Rizzo wrote: > L> svn 270870 removed all the if_*spare fields in struct ifnet. > L> They are replaced with the following comment > L> > L> /* > L> * Spare fields to be added befor

Re: RFC: please put back spare fields in struct ifnet (removed in svn 270870)

2014-09-09 Thread Gleb Smirnoff
Luigi, On Tue, Sep 09, 2014 at 12:13:42PM +0200, Luigi Rizzo wrote: L> svn 270870 removed all the if_*spare fields in struct ifnet. L> They are replaced with the following comment L> L> /* L> * Spare fields to be added before branching a stable branch, so L> * that structure can be enhanced w