Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]
On Fri, Nov 17, 2000 at 10:55:32PM +0900, Makoto MATSUSHITA wrote: > Attached below is a patch which I've made before. If nothing is going > wrong, please commit this change I committed something simular. BTW, you made ``make depend'' a requirement, which we did not have agreement on. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]
David O'Brien wrote:
>
> > > modules-depend:
> > > @mkdir -p ${.OBJDIR}/modules
> > > ! cd $S/modules; env ${MKMODULESENV} ${MAKE} obj
> > > ! env ${MKMODULESENV} ${MAKE} depend
>
> This is broken for non -j case.
Yes, this was known. The right diff was given at the beginning of the
message including the comment that the original patch had this breakage
:-)
--
Marcel Moolenaar
mail: [EMAIL PROTECTED] / [EMAIL PROTECTED]
tel: (408) 447-4222
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Re: RQ review: [was: Re: "make modules" kicks the first module directory twice]
On Mon, Nov 13, 2000 at 08:02:47PM -0800, Marcel Moolenaar wrote:
> Any objections?
Yes.
> (patches follow for your convenience)
[its easier to read patches when they aren't quoted in their entirety ;-)]
> > modules-depend:
> > @mkdir -p ${.OBJDIR}/modules
> > ! cd $S/modules; env ${MKMODULESENV} ${MAKE} obj
> > ! env ${MKMODULESENV} ${MAKE} depend
This is broken for non -j case.
--
-- David ([EMAIL PROTECTED])
GNU is Not Unix / Linux Is Not UniX
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
