Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now
On Sat, Apr 20, 2002 at 17:12:21 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > > NOTE: I just commit the fix, see session.c commit log for detailed > > explanation. > > Andrey, in the future please *submit patches for review*. This case is special - that was old code written by me and present in all previous versions of OpenSSH we have, but lost in merge very recently. The real subject is improper merge. Those people who does merge not submit patches for my review. I start alarming probably a bit late since I don't have machine suitable for recent -current until now. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now
"Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > NOTE: I just commit the fix, see session.c commit log for detailed > explanation. Andrey, in the future please *submit patches for review*. DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now
On Sat, Apr 20, 2002 at 06:43:05 +0400, Andrey A. Chernov wrote: > On Sat, Apr 20, 2002 at 05:21:42 +0400, Andrey A. Chernov wrote: > > Well, who damages LOGIN_CAP processing in sshd now? It not reads > > ~/.login_conf anymore and not sets LOGIN_CAP limits. > > I see parent environment seriously damaged in do_setusercontext() since > not saved. I mean MAIL,BLOCKSIZE & FTP_PASSIVE_MODE variables, > overwritten by /etc/login.conf Really any environment variable can be > overwritten here, so please restore good old code which saves&restores > parent environment before calling setusercontext(). do_setup_env() code is > broken too because call setusercontext() which modify _current_ > environment, and NOT child one. NOTE: I just commit the fix, see session.c commit log for detailed explanation. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now
On Sat, Apr 20, 2002 at 05:21:42 +0400, Andrey A. Chernov wrote: > Well, who damages LOGIN_CAP processing in sshd now? It not reads > ~/.login_conf anymore and not sets LOGIN_CAP limits. I see parent environment seriously damaged in do_setusercontext() since not saved. I mean MAIL,BLOCKSIZE & FTP_PASSIVE_MODE variables, overwritten by /etc/login.conf Really any environment variable can be overwritten here, so please restore good old code which saves&restores parent environment before calling setusercontext(). do_setup_env() code is broken too because call setusercontext() which modify _current_ environment, and NOT child one. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
