Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-02 Thread Gleb Smirnoff
  Oliver,

On Mon, Jun 01, 2015 at 10:46:33PM +0200, Oliver Pinter wrote:
O> In ath case I got some LOR during boot and during kismet, see the
O> attached dmesgs.

I've fixed the first one. But I believe the second LOR happens on
unmodified head as well.

Thanks a lot for your help.

-- 
Totus tuus, Glebius.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Gleb Smirnoff
On Tue, Jun 02, 2015 at 12:33:13AM +0300, Lev Serebryakov wrote:
L> > On Tue, Jun 02, 2015 at 12:00:46AM +0300, Lev Serebryakov wrote: L>
L> > > One confusing thing, that the underlaying devices (ath0 and
L> > iwn0) L> > has gone from ifconfig, and that's a little confusing,
L> > when you L> > have multiple pci card and try to create multiple VAP
L> > to specific L> > device. L>  I think, it is a bug. Some options
L> > could be configured only on L> underlying devices! What options?
L>   Regulatory domain, as far as I remember. But I've checked long ago,
L> maybe it was changed?
L> 
L>  And media/mode?

Looking into code, I don't see any. If I missed something, then please
point me at the problem, and I will fix it, so that the command will
work on wlanX (if it doesn't already).

-- 
Totus tuus, Glebius.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Lev Serebryakov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 02.06.2015 00:20, Gleb Smirnoff wrote:

> On Tue, Jun 02, 2015 at 12:00:46AM +0300, Lev Serebryakov wrote: L>
> > One confusing thing, that the underlaying devices (ath0 and
> iwn0) L> > has gone from ifconfig, and that's a little confusing,
> when you L> > have multiple pci card and try to create multiple VAP
> to specific L> > device. L>  I think, it is a bug. Some options
> could be configured only on L> underlying devices! What options?
  Regulatory domain, as far as I remember. But I've checked long ago,
maybe it was changed?

 And media/mode?

- -- 
// Lev Serebryakov
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (MingW32)

iQJ8BAEBCgBmBQJVbM+ZXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF
QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EePsUwP/36zZHte8ncFHl2jvgxeHOU/
qWMpexDLXJIx7HkmsER2559fPCQTC3ijTnzDtVVQxgp3T0YCvC+asyQHemmg8Jae
1NmLs2pFGXNdeD3UqRy7cFT5EQXOm9HAb2DiahfuIPtCxPfqN44gbxWRgdudWbdg
ZWL869G0YW1hWxq+XlIDAa5ojpFRgDg9XtGIE0XFrQYaS/e1L6JsRpv+/QaOVPax
PS6YB3cbUPHdAcNVqJbIbtwRT1j0aPoA7U1Rql7WUoGIOHfM3c4T/6ENMCRcw/f4
uxn9V/ReS63kqtoZgZfFMVGoBCTIHvqEGvZxnQ1tM2vULer3Btei5hvCsK7vEpD9
YejN8JH1tcGGmcwCcwHYuo2AtqaDsmALFbYRK8Il9FfCXXjuSp54SSe3UTgEsg94
Zyq9R/lDSC9dj6xXVPMN0UrxtKvREoIQ1wu4y1WdisWpkSUDvj6Jfog/ob0oXz4k
wdhFqwoMQx3ar24s5ei4s8kU1uus8DTXwkDDQVfpzvQ5xXZdMeuDQPUnDVsHyeBs
EUaakMLbLXkvBKGvUc+alr83wGVg6bxoVSoF2SgkhQM+WiC7EXkoYgDV0TZ1dPev
qX41VxbAzj95wi8yI1FmxNnJoBIH3ZpR5m/ho/EGEvTob3aeuVrq4lRzc/Lbwufy
rl0vu9y4NQXESFUr+VUQ
=tbA7
-END PGP SIGNATURE-
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Gleb Smirnoff
On Mon, Jun 01, 2015 at 10:46:33PM +0200, Oliver Pinter wrote:
O> And the same test against my atheros seems like working fine, both the
O> secondary VAP creation and destruction. I'm able to run kismet without
O> panic, and that seems too working fine.

Thanks a lot!

O> In ath case I got some LOR during boot and during kismet, see the
O> attached dmesgs.

I will look at these.

O> One confusing thing, that the underlaying devices (ath0 and iwn0) has
O> gone from ifconfig, and that's a little confusing, when you have
O> multiple pci card and try to create multiple VAP to specific device.

This is intended. The ifnet layer was making KPI more complex and
it is absolutely superfluous.

You've got a PCI device, seen in pciconf. You've get kernel device,
seen in devinfo. But you need to create wlan0 interface.

The ath0 or iwn0 were not actually interfaces. You couldn't assign
addresses to them, send packets, receive packets on them. They were
just sitting in the list, confusing people. Now people got used to
them, and their absense on list is confusing, like you said. But
you will get used again :)

-- 
Totus tuus, Glebius.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Gleb Smirnoff
On Tue, Jun 02, 2015 at 12:00:46AM +0300, Lev Serebryakov wrote:
L> > One confusing thing, that the underlaying devices (ath0 and iwn0)
L> > has gone from ifconfig, and that's a little confusing, when you
L> > have multiple pci card and try to create multiple VAP to specific
L> > device.
L>  I think, it is a bug. Some options could be configured only on
L> underlying devices!

What options?

-- 
Totus tuus, Glebius.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Lev Serebryakov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 01.06.2015 23:46, Oliver Pinter wrote:

> One confusing thing, that the underlaying devices (ath0 and iwn0)
> has gone from ifconfig, and that's a little confusing, when you
> have multiple pci card and try to create multiple VAP to specific
> device.
 I think, it is a bug. Some options could be configured only on
underlying devices!

- -- 
// Lev Serebryakov
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (MingW32)

iQJ8BAEBCgBmBQJVbMf+XxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF
QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EePMJsQALOpueKL8PqvTSn+wzORy/uY
DXW2IFwds5BSnAMrQTIwlfs3/aaf6EIQIo8UMcZdxXFhS4FyeBW4Br+Y8fDcwmK9
jLojBDmaUjUTduO0kl/iWFxb83YwTCOwnE+ruOYB1Y9m9+5posuB3bgzFQVuXHMX
2Ko8tXI+4DeW65QGFGhuU3D5ha4S2GL6gT/Q+zo6t0SIwioHoONCBgcUgruyJuM2
GzOYKGceUQk2fqiOrLQdt5HhxqivDRUhnFZ4rbsZWhj/in62WQvMkRgTj5168oR8
wFVTCxcJGFPd+1bs23Gsykk2kaLMdaDmCmyg5x9gYOBafyKPzd1y0e1Iy9ijtfQm
jffOxBA/ZIF/G8B0jyRU2rY7if62+uPWNorgzKN5mEs7mHZJXNouYw12RfIV3g5F
uuMhVzh8FHISSyxT/NHVP5p1ylx3/qAPqyg/vynVw30FXdU98RW0yMM4jpMymR3T
u8yg05HVbDQk9eRIvJB2Rg7kmRMVZrzHFU9ST89E3s1o3g6AONqHDMfnXOMTCx/T
CNuHAX5E4pI6RJbntLOxJ5T+oLdnv4dnZyzHjtoPzSTgmZS7v1c4grmj+Zj82KHS
rPkgaA223g8faRVOhx9F3LAkAarDgDF9CnIUGGC8x3dUt08CRssHavEeK34Uzdy+
FYqvXH0jZ9YzXp4y6qAF
=F+yH
-END PGP SIGNATURE-
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Lev Serebryakov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 01.06.2015 18:37, Gleb Smirnoff wrote:

> I've converted the ath(4), probably the most complex ieee80211
> driver.
> 
> The updated diff is uploaded to https://reviews.freebsd.org/D2655.
> 
> Pretty sure it will panic or fail on first try :) Nevertheless, 
> asking for your help. Please try to run it and report any problems 
> to me.
 And

#ifdef IEEE80211_SUPPORT_TDMA
if (sc->sc_tdma) {
if (sc->sc_tdmaswba == 0) {
struct ieee80211com *ic =
ifp->if_l2com;
struct ieee80211vap *vap =
TAILQ_FIRST(&ic->ic_vaps);
ath_tdma_beacon_send(sc, vap);
sc->sc_tdmaswba =
vap->iv_tdma->tdma_bintval;
} else
sc->sc_tdmaswba--;
} else
#endif


- -- 
// Lev Serebryakov
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (MingW32)

iQJ8BAEBCgBmBQJVbMdtXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF
QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EeP6ZsP/Rmjq4tv+M1grcjgX3IB3fvr
0s/DLtZkhU9/gV2uc+H9mPE1wMgH4jaS8230ZGna4kmQWN+hzRIAUrmV77Riaklm
PXjp1XhUtxIKB5QRVsrUvdcRpON0TNS/3q3BCJzb5Cz4lAUH6/Wppj/LWY6bak2H
Cx07otUZCNjF4V/FHmZ5S043tgWHIoKIkxkooLVD2TecRDR4Dmc1tKPB0poxSZ5M
ALybsdg0pdmI0xcMhBDMKsGHcqxb6nOHVv5tw8Bpuy9mctDn99aqRs3WIEn1QAar
tsqnufVrXy5bfQuVmzeU0saWAGHzoTFTQeTJz6mTBdghAQtTDmc2zVkBTk7sd0wL
wq7qfed7MpI5bv2xd8IlKM2D6qr5E1afXEpLB3eiyH/2X37148uYxpQOPvQOhF4X
vFqucRmB/1N6Slz6+kXRV5feQa9Re/lPmj/9Hd9ZtSmB74fijNAQjyvTgCz5onKN
GMgpk1ARVdKS11tFo23zkjo0wtpwP3Wn0CstQHMbdNlc2un5xGi18/z5xyO3eq0K
vNozMPiiee59JFngWmlLYVYWfuI6mbS0qIhfFBEaHQ6r23OKb/jKKNJDDbIU5w+Y
JjIIc036dKl5jsJeF3wvQTpSocSk6YgQaViQ55i6pCNhQ0OpuGUXoXBnL/claVq0
+QTQJ7D43eGxpWlvNMc0
=oUxO
-END PGP SIGNATURE-
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Lev Serebryakov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 01.06.2015 22:55, Oliver Pinter wrote:

>> Do you have compile tested the code? I got this build error:
 also, here are bunch of things like this:

DPRINTF(sc, ATH_DEBUG_ANY, "%s: if_flags %x\n",
__func__, ifp->if_flags);


- -- 
// Lev Serebryakov
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (MingW32)

iQJ8BAEBCgBmBQJVbMc+XxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGOTZEMUNBMEI1RjQzMThCNjc0QjMzMEFF
QUIwM0M1OEJGREM0NzhGAAoJEOqwPFi/3EePcq8P/21DPn/HpsowlSPQvRHgKzEQ
4p0g+k28h0faRxPU1nG98SBgvqfh/6nIT8+xfZorCfPo/TUxceECNfj7jPt5Hhsh
LK97FgEhUi9iz9dV3lwh19y17+785XdN1qE7mbuJBjMEEfx63CyWXwkQWrmKKRka
4jC0vhzzBEZxcBMkvH2XO0v8MeyIXdzxWLoc6VuIfJ4ewQCeoR6hwD4LAWSO7cT1
BguOi3wUU8YNFle6ApZkbLflPuzB98GlBJ89FO2H3ftExE8QgUB9r6iaMjB/lRno
duLGl2417LtRkVJcuNJxYsT9CG01+IakekrUBC4y2NjDd4EESJCnvnis32EneeET
+UesgOX4jsU3vNdeArCIz6mFEMBQ/PYORmmVBeKvjLkEIB1wL/c7GWSwvI+r4TJY
wtAU0utntiGBSFEpqTH7eAxO/IncB0oh4ybYna4C6B5ZCv4gUdZ4urANyJpLTN9c
zJp5hGkhlzLOhDgrvfEOxF6sqRX3RhDnlTb/4imBKCysAfvn4sT5U6CKpZd/CEY5
fEnpLC9kZCEQpa4hj6W8TbAoZIGSZA5UN3JinNVHgtWBOI4EeXVViMb9rOwGwTc1
XFNtaTHhH/itpk5QrPOQC1TmP7srm7sHT0MlV/tRxL8ClUwsS6Wy5aW1RpF34bNn
V3L45ftUymwknza4Rjd/
=6JDY
-END PGP SIGNATURE-
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Oliver Pinter
On Mon, Jun 1, 2015 at 9:55 PM, Oliver Pinter
 wrote:
> On Mon, Jun 1, 2015 at 9:47 PM, Oliver Pinter
>  wrote:
>> On Mon, Jun 1, 2015 at 5:37 PM, Gleb Smirnoff  wrote:
>>>   Hi!
>>>
>>> I've converted the ath(4), probably the most complex ieee80211 driver.
>>>
>>> The updated diff is uploaded to https://reviews.freebsd.org/D2655.
>>>
>>> Pretty sure it will panic or fail on first try :) Nevertheless,
>>> asking for your help. Please try to run it and report any problems
>>> to me.
>>
>> Hi!
>>
>> Do you have compile tested the code? I got this build error:
>>
>> --- if_ath.o ---
>> /usr/src/sys/dev/ath/if_ath.c:5732:26: error: no member named 'ic_ifp'
>> in 'struct ieee80211com'; did you mean 'ic_dfs'?
>> struct ifnet *ifp = ic->ic_ifp;
>> ^~
>> ic_dfs
>> /usr/src/sys/net80211/ieee80211_var.h:197:29: note: 'ic_dfs' declared here
>> struct ieee80211_dfs_state ic_dfs;  /* DFS state */
>>^
>> /usr/src/sys/dev/ath/if_ath.c:5732:16: error: initializing 'struct
>> ifnet *' with an expression of incompatible type 'struct
>> ieee80211_dfs_state'
>> struct ifnet *ifp = ic->ic_ifp;
>>   ^
>>
>
> diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c
> index 53763a6..b719ed4 100644
> --- a/sys/dev/ath/if_ath.c
> +++ b/sys/dev/ath/if_ath.c
> @@ -5729,8 +5729,7 @@ ath_scan_end(struct ieee80211com *ic)
>  static void
>  ath_update_chw(struct ieee80211com *ic)
>  {
> -   struct ifnet *ifp = ic->ic_ifp;
> -   struct ath_softc *sc = ifp->if_softc;
> +   struct ath_softc *sc = ic->ic_softc;
>
> DPRINTF(sc, ATH_DEBUG_STATE, "%s: called\n", __func__);
> ath_set_channel(ic);
> diff --git a/sys/dev/ath/if_ath_tdma.c b/sys/dev/ath/if_ath_tdma.c
> index fd23db1..d4c9ccd 100644
> --- a/sys/dev/ath/if_ath_tdma.c
> +++ b/sys/dev/ath/if_ath_tdma.c
> @@ -359,7 +359,7 @@ ath_tdma_update(struct ieee80211_node *ni,
>  #defineTU_TO_TSF(_tu)  (((u_int64_t)(_tu)) << 10)
> struct ieee80211vap *vap = ni->ni_vap;
> struct ieee80211com *ic = ni->ni_ic;
> -   struct ath_softc *sc = ic->ic_ifp->if_softc;
> +   struct ath_softc *sc = ic->ic_softc;
> struct ath_hal *ah = sc->sc_ah;
> const HAL_RATE_TABLE *rt = sc->sc_currates;
> u_int64_t tsf, rstamp, nextslot, nexttbtt, nexttbtt_full;
>

And the same test against my atheros seems like working fine, both the
secondary VAP creation and destruction. I'm able to run kismet without
panic, and that seems too working fine.

In ath case I got some LOR during boot and during kismet, see the
attached dmesgs.

One confusing thing, that the underlaying devices (ath0 and iwn0) has
gone from ifconfig, and that's a little confusing, when you have
multiple pci card and try to create multiple VAP to specific device.

op@opn ~> ifconfig wlan0 scan
SSID/MESH IDBSSID  CHAN RATE   S:N INT CAPS
IRA f4:ec:38:e4:48:b81   54M -91:-96  100 EPS  RSN
Fridel  38:60:77:d4:6b:811   54M -83:-96  100 EP   RSN HTCAP WPA WME
B4  f8:1a:67:38:9d:d86   54M -86:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
fagif8:d1:11:bd:f9:f66   54M -92:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Koka10:fe:ed:b5:c7:6a   11   54M -77:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Otti-home   b0:c5:54:86:16:9a   11   54M -93:-96  100 EPS  HTCAP
WPA RSN WME WPS
teszt   f8:1a:67:40:1d:b0   13   54M -93:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Linksys7038520:aa:4b:78:31:e42   54M -96:-96  100 EPS  RSN HTCAP WME WPS
teszt2  20:e5:2a:5d:30:2a3   54M -93:-96  100 EP   HTCAP RSN WME WPS
hellooo c0:4a:00:ea:5a:ea5   54M -74:-96  100 EPS  RSN HTCAP ATH
op@opn ~> ifconfig wlan0 list ap
SSID/MESH IDBSSID  CHAN RATE   S:N INT CAPS
IRA f4:ec:38:e4:48:b81   54M -91:-96  100 EPS  RSN
Fridel  38:60:77:d4:6b:811   54M -83:-96  100 EP   RSN HTCAP WPA WME
B4  f8:1a:67:38:9d:d86   54M -86:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
fagif8:d1:11:bd:f9:f66   54M -92:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Koka10:fe:ed:b5:c7:6a   11   54M -77:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Otti-home   b0:c5:54:86:16:9a   11   54M -93:-96  100 EPS  HTCAP
WPA RSN WME WPS
teszt   f8:1a:67:40:1d:b0   13   54M -93:-96  100 EPS  RSN
HTCAP WPA WME ATH WPS
Linksys7038520:aa:4b:78:31:e42   54M -96:-96  100 EPS  RSN HTCAP WME WPS
teszt2  20:e5:2a:5d:30:2a3   54M -93:-96  100 EP   HTCAP RSN WME WPS
hellooo c0:4a:00:ea:5a:ea5   54M -74:-96  100 EPS  RSN HTCAP ATH
op@opn ~> ifconfig wlan0 list sta
ADDR   AID CHAN RATE RSSI IDLE  TXSEQ  RXSEQ CAPS FLAG
c0:4a:00:ea:5a:ea45 135M 20.00  7 64 EPS  AEHTRS+
RSN HTCAP ATH

>>>
>>> --
>>> Totus tuus, Glebius.
>>> __

Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Oliver Pinter
On Mon, Jun 1, 2015 at 9:47 PM, Oliver Pinter
 wrote:
> On Mon, Jun 1, 2015 at 5:37 PM, Gleb Smirnoff  wrote:
>>   Hi!
>>
>> I've converted the ath(4), probably the most complex ieee80211 driver.
>>
>> The updated diff is uploaded to https://reviews.freebsd.org/D2655.
>>
>> Pretty sure it will panic or fail on first try :) Nevertheless,
>> asking for your help. Please try to run it and report any problems
>> to me.
>
> Hi!
>
> Do you have compile tested the code? I got this build error:
>
> --- if_ath.o ---
> /usr/src/sys/dev/ath/if_ath.c:5732:26: error: no member named 'ic_ifp'
> in 'struct ieee80211com'; did you mean 'ic_dfs'?
> struct ifnet *ifp = ic->ic_ifp;
> ^~
> ic_dfs
> /usr/src/sys/net80211/ieee80211_var.h:197:29: note: 'ic_dfs' declared here
> struct ieee80211_dfs_state ic_dfs;  /* DFS state */
>^
> /usr/src/sys/dev/ath/if_ath.c:5732:16: error: initializing 'struct
> ifnet *' with an expression of incompatible type 'struct
> ieee80211_dfs_state'
> struct ifnet *ifp = ic->ic_ifp;
>   ^
>

diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c
index 53763a6..b719ed4 100644
--- a/sys/dev/ath/if_ath.c
+++ b/sys/dev/ath/if_ath.c
@@ -5729,8 +5729,7 @@ ath_scan_end(struct ieee80211com *ic)
 static void
 ath_update_chw(struct ieee80211com *ic)
 {
-   struct ifnet *ifp = ic->ic_ifp;
-   struct ath_softc *sc = ifp->if_softc;
+   struct ath_softc *sc = ic->ic_softc;

DPRINTF(sc, ATH_DEBUG_STATE, "%s: called\n", __func__);
ath_set_channel(ic);
diff --git a/sys/dev/ath/if_ath_tdma.c b/sys/dev/ath/if_ath_tdma.c
index fd23db1..d4c9ccd 100644
--- a/sys/dev/ath/if_ath_tdma.c
+++ b/sys/dev/ath/if_ath_tdma.c
@@ -359,7 +359,7 @@ ath_tdma_update(struct ieee80211_node *ni,
 #defineTU_TO_TSF(_tu)  (((u_int64_t)(_tu)) << 10)
struct ieee80211vap *vap = ni->ni_vap;
struct ieee80211com *ic = ni->ni_ic;
-   struct ath_softc *sc = ic->ic_ifp->if_softc;
+   struct ath_softc *sc = ic->ic_softc;
struct ath_hal *ah = sc->sc_ah;
const HAL_RATE_TABLE *rt = sc->sc_currates;
u_int64_t tsf, rstamp, nextslot, nexttbtt, nexttbtt_full;

>>
>> --
>> Totus tuus, Glebius.
>> ___
>> freebsd-current@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: converted ath(4) for testing Was: [Testers needed!] WiFi drivers changes

2015-06-01 Thread Oliver Pinter
On Mon, Jun 1, 2015 at 5:37 PM, Gleb Smirnoff  wrote:
>   Hi!
>
> I've converted the ath(4), probably the most complex ieee80211 driver.
>
> The updated diff is uploaded to https://reviews.freebsd.org/D2655.
>
> Pretty sure it will panic or fail on first try :) Nevertheless,
> asking for your help. Please try to run it and report any problems
> to me.

Hi!

Do you have compile tested the code? I got this build error:

--- if_ath.o ---
/usr/src/sys/dev/ath/if_ath.c:5732:26: error: no member named 'ic_ifp'
in 'struct ieee80211com'; did you mean 'ic_dfs'?
struct ifnet *ifp = ic->ic_ifp;
^~
ic_dfs
/usr/src/sys/net80211/ieee80211_var.h:197:29: note: 'ic_dfs' declared here
struct ieee80211_dfs_state ic_dfs;  /* DFS state */
   ^
/usr/src/sys/dev/ath/if_ath.c:5732:16: error: initializing 'struct
ifnet *' with an expression of incompatible type 'struct
ieee80211_dfs_state'
struct ifnet *ifp = ic->ic_ifp;
  ^

>
> --
> Totus tuus, Glebius.
> ___
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"