Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Mon, Jun 22, 2015 at 09:51:23AM +0800, Kevin Lo wrote:
K> Thank you Gleb. urtw(4) works fine on amd64.
Thanks.
K> One minor problem, I got an compiler error and this diff below fixes it.
K>
K> --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800
K> +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800
K> @@ -10421,14 +10421,6 @@
K> struct urtw_vap *uvp = URTW_VAP(vap);
K> struct ieee80211_node *ni;
K> usb_error_t error = 0;
K> -@@ -1905,7 +1858,6 @@
K> -default:
K> -break;
K> -}
K> --fail:
K> -URTW_UNLOCK(sc);
K> -IEEE80211_LOCK(ic);
K> -return (uvp->newstate(vap, nstate, arg));
K> @@ -1915,12 +1867,11 @@
K> urtw_watchdog(void *arg)
K> {
This patch is unclear to me. Can you please send a diff between my version
and your version? Diff of diff drives me mad.
--
Totus tuus, Glebius.
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Thu, Jun 18, 2015 at 01:40:30PM +0300, Gleb Smirnoff wrote:
>
> On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote:
> K> > you signed up as tester of urtw(4). I have converted urtw(4)
> K> > and uploaded new patch at:
> K> >
> K> > https://reviews.freebsd.org/D2655
> K> >
> K> > Please try, report and update the project page.
> K> >
> K> > https://wiki.freebsd.org/projects/ifnet/net80211
> K> >
> K> > Thanks a lot for your help with the project.
> K>
> K> After bringing interface up I'm getting:
> K> http://i.imgur.com/XhOVJ68.jpg
>
> I've found the problem and updated the diff. Please test once more.
>
> Thanks for help! Without you the bug could leak into subversion.
Thank you Gleb. urtw(4) works fine on amd64.
# dmesg |grep urtw
urtw0: on
usbus4
urtw0: unknown RTL8187L type: 0x800
urtw0: rtl8187l rf rtl8225u hwrev none
One minor problem, I got an compiler error and this diff below fixes it.
--- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800
+++ D2655.diff 2015-06-22 09:47:56.121431950 +0800
@@ -10421,14 +10421,6 @@
struct urtw_vap *uvp = URTW_VAP(vap);
struct ieee80211_node *ni;
usb_error_t error = 0;
-@@ -1905,7 +1858,6 @@
- default:
- break;
- }
--fail:
- URTW_UNLOCK(sc);
- IEEE80211_LOCK(ic);
- return (uvp->newstate(vap, nstate, arg));
@@ -1915,12 +1867,11 @@
urtw_watchdog(void *arg)
{
>
> --
> Totus tuus, Glebius.
Kevin
___
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote: K> > you signed up as tester of urtw(4). I have converted urtw(4) K> > and uploaded new patch at: K> > K> > https://reviews.freebsd.org/D2655 K> > K> > Please try, report and update the project page. K> > K> > https://wiki.freebsd.org/projects/ifnet/net80211 K> > K> > Thanks a lot for your help with the project. K> K> After bringing interface up I'm getting: K> http://i.imgur.com/XhOVJ68.jpg I've found the problem and updated the diff. Please test once more. Thanks for help! Without you the bug could leak into subversion. -- Totus tuus, Glebius. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote: K> > you signed up as tester of urtw(4). I have converted urtw(4) K> > and uploaded new patch at: K> > K> > https://reviews.freebsd.org/D2655 K> > K> > Please try, report and update the project page. K> > K> > https://wiki.freebsd.org/projects/ifnet/net80211 K> > K> > Thanks a lot for your help with the project. K> K> After bringing interface up I'm getting: K> http://i.imgur.com/XhOVJ68.jpg What's the actual assertion in the mutex code? -- Totus tuus, Glebius. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Thu, Jun 18, 2015 at 12:04:55PM +0200, Olivier Cochard-Labbé wrote: O> > After bringing interface up I'm getting: O> > http://i.imgur.com/XhOVJ68.jpg O> > O> I didn't meet this problem on head (r284301) with D2655 applied and using O> an Alpha network AWUS036NHR v.2 Which is urtwn, not urtw. -- Totus tuus, Glebius. ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Thu, Jun 18, 2015 at 10:16 AM, Kevin Lo wrote: > > After bringing interface up I'm getting: > http://i.imgur.com/XhOVJ68.jpg > > I didn't meet this problem on head (r284301) with D2655 applied and using an Alpha network AWUS036NHR v.2 ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes
On Wed, Jun 17, 2015 at 11:28:55AM +0300, Gleb Smirnoff wrote: > > Hi Kevin, > > you signed up as tester of urtw(4). I have converted urtw(4) > and uploaded new patch at: > > https://reviews.freebsd.org/D2655 > > Please try, report and update the project page. > > https://wiki.freebsd.org/projects/ifnet/net80211 > > Thanks a lot for your help with the project. After bringing interface up I'm getting: http://i.imgur.com/XhOVJ68.jpg > -- > Totus tuus, Glebius. Kevin ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
