Re: ffs_truncate3 panics

2018-08-17 Thread Rick Macklem
Just fyi, I have committed r337962 to head, which stops the pNFS service from creating non-zero length empty files. Since these files were the ones causing the "ffs_truncate3" panics, the panics should no longer occur. I will take a closer look at some point to see if I can spot why the panics()

Re: ffs_truncate3 panics

2018-08-12 Thread Rick Macklem
Konstantin Belousov wrote: [stuff snipped] >Problem with this buffer is that BX_ALTDATA bit is not set. >This is the reason why vinvalbuf(V_ALT) skips it. [more stuff snipped] >The vnode is exclusively locked. Other thread must not be able to >instantiate a buffer under us. That's what I thought,

Re: ffs_truncate3 panics

2018-08-11 Thread Konstantin Belousov
On Sat, Aug 11, 2018 at 12:05:25PM +, Rick Macklem wrote: > Konstantin Belousov wrote: > >On Thu, Aug 09, 2018 at 08:38:50PM +, Rick Macklem wrote: > >> >BTW, does NFS server use extended attributes ? What for ? Can you, > >> >please, > >> >point out the code which does this ? > >> For

Re: ffs_truncate3 panics

2018-08-11 Thread Rick Macklem
Konstantin Belousov wrote: >On Thu, Aug 09, 2018 at 08:38:50PM +, Rick Macklem wrote: >> >BTW, does NFS server use extended attributes ? What for ? Can you, please, >> >point out the code which does this ? >> For the pNFS service, there are two system namespace extended attributes for >>

Re: ffs_truncate3 panics

2018-08-10 Thread Konstantin Belousov
On Thu, Aug 09, 2018 at 08:38:50PM +, Rick Macklem wrote: > >BTW, does NFS server use extended attributes ? What for ? Can you, please, > >point out the code which does this ? > For the pNFS service, there are two system namespace extended attributes for > each file stored on the service. >

Re: ffs_truncate3 panics

2018-08-10 Thread Rick Macklem
Konstantin Belousov wrote: >On Thu, Aug 09, 2018 at 08:38:50PM +, Rick Macklem wrote: >> I did notice that my code locks the vnode first and then calls >> vn_start_write() >> for the vn_extattr_set() calls, whereas the syscall code locks the vnode >> after the vn_start_write() call. >> >>

Re: ffs_truncate3 panics

2018-08-10 Thread Konstantin Belousov
On Thu, Aug 09, 2018 at 08:38:50PM +, Rick Macklem wrote: > I did notice that my code locks the vnode first and then calls > vn_start_write() > for the vn_extattr_set() calls, whereas the syscall code locks the vnode > after the vn_start_write() call. > > Does that matter? Yes, it matter.

Re: ffs_truncate3 panics

2018-08-09 Thread Rick Macklem
Konstantin Belousov wrote: [stuff snipped] >I wrote: >> >> I can add printf()s anywhere you suggest, but I'm not sure how you would >> catch >> this case sooner? (For example, I could print out di_extsize at the >> beginning of >> ffs_truncate(), if that would help?) >May be, add a loop at the

Re: ffs_truncate3 panics

2018-08-09 Thread Rick Macklem
Rodney W. Grimes wrote: [stuff snipped] >It should be possible to design a set of VM's using bhyve, xen or ones >favorite hypervisor/virtulization platform to do "more" pNFS testing. >If you could provide a rought machine set needed to have a functional >test bed, and what should be done to "test"

Re: ffs_truncate3 panics

2018-08-09 Thread Rodney W. Grimes
> Konstantin Belousov wrote: > [stuff snipped] > >> >Can you print the only buffer on the clean queue when the panic occur ? > >> ffst3 vtyp=1 bodirty=0 boclean=1 > >> buf at 0x428a110 > >> b_flags = 0x20001020, b_xflags=0x2, b_vflags=0x0 > >> b_error = 0, b_bufsize = 4096, b_bcount = 4096,

Re: ffs_truncate3 panics

2018-08-09 Thread Konstantin Belousov
On Thu, Aug 09, 2018 at 01:39:20AM +, Rick Macklem wrote: > Konstantin Belousov wrote: > [stuff snipped] > >> >Can you print the only buffer on the clean queue when the panic occur ? > >> ffst3 vtyp=1 bodirty=0 boclean=1 > >> buf at 0x428a110 > >> b_flags = 0x20001020, b_xflags=0x2,

Re: ffs_truncate3 panics

2018-08-08 Thread Rick Macklem
Konstantin Belousov wrote: [stuff snipped] >> >Can you print the only buffer on the clean queue when the panic occur ? >> ffst3 vtyp=1 bodirty=0 boclean=1 >> buf at 0x428a110 >> b_flags = 0x20001020, b_xflags=0x2, b_vflags=0x0 >> b_error = 0, b_bufsize = 4096, b_bcount = 4096, b_resid = 0 >>

Re: ffs_truncate3 panics

2018-08-08 Thread Konstantin Belousov
On Wed, Aug 08, 2018 at 12:30:54PM +, Rick Macklem wrote: > Konstantin Belousov wrote: > >On Tue, Aug 07, 2018 at 12:28:33PM +, Rick Macklem wrote: > >> Hi, > >> > >> During testing of the pNFS server I get an ffs_truncate3 panic every once > >> in a while. > >> A few things that might be

Re: ffs_truncate3 panics

2018-08-08 Thread Conrad Meyer
On Wed, Aug 8, 2018 at 5:30 AM, Rick Macklem wrote: > - Oh, and this is an old i386 with 256Mbytes (not one of them new fangled > computers, >where memory is in Gbytes;-) Have you run memtest86+ recently? Best, Conrad ___

Re: ffs_truncate3 panics

2018-08-08 Thread Rick Macklem
Konstantin Belousov wrote: >On Tue, Aug 07, 2018 at 12:28:33PM +, Rick Macklem wrote: >> Hi, >> >> During testing of the pNFS server I get an ffs_truncate3 panic every once in >> a while. >> A few things that might be relevant: >> - Seems to happen more often when soft update journaling is

Re: ffs_truncate3 panics

2018-08-07 Thread Konstantin Belousov
On Tue, Aug 07, 2018 at 12:28:33PM +, Rick Macklem wrote: > Hi, > > During testing of the pNFS server I get an ffs_truncate3 panic every once in > a while. > A few things that might be relevant: > - Seems to happen more often when soft update journaling is enabled, but will > happen when