Re: is 'device ether' mandatory now?
i'd rather fix the change so that ether is not mandatory. Let me think/experiment a bit about it. cheers luigi On Tue, Mar 26, 2002 at 11:16:49AM +0300, Maxim Konovalov wrote: > > Hello Luigi, > > On 05:20-0800, Mar 24, 2002, Luigi Rizzo wrote: > > > Do you have a suggestion for an #ifdef /#endif to > > remove the problem you mention ? > > Frankly speaking, I have no solution atm. But IMHO we should fix LINT > and warn our -stable users at least. > > Something like that: > > Index: sys/i386/conf/LINT > === > RCS file: /home/ncvs/src/sys/i386/conf/Attic/LINT,v > retrieving revision 1.749.2.106 > diff -u -r1.749.2.106 LINT > --- sys/i386/conf/LINT2002/03/11 01:23:05 1.749.2.106 > +++ sys/i386/conf/LINT2002/03/26 08:06:56 > @@ -468,8 +468,8 @@ > # Network interfaces: > # The `loop' pseudo-device is MANDATORY when networking is enabled. > # The `ether' pseudo-device provides generic code to handle > -# Ethernets; it is MANDATORY when a Ethernet device driver is > -# configured or token-ring is enabled. > +# Ethernets; it is MANDATORY when the Internet communication > +# protocols family (INET) is configured. > # The 'fddi' pseudo-device provides generic code to support FDDI. > # The `arcnet' pseudo-device provides generic code to support Arcnet. > # The `sppp' pseudo-device serves a similar role for certain types > Index: NOTES > === > RCS file: /home/ncvs/src/sys/i386/conf/NOTES,v > retrieving revision 1.1011 > diff -u -r1.1011 NOTES > --- NOTES 2002/03/23 18:39:54 1.1011 > +++ NOTES 2002/03/26 08:08:48 > @@ -521,8 +521,8 @@ > # Network interfaces: > # The `loop' device is MANDATORY when networking is enabled. > # The `ether' device provides generic code to handle > -# Ethernets; it is MANDATORY when a Ethernet device driver is > -# configured or token-ring is enabled. > +# Ethernets; it is MANDATORY when the Internet communication > +# protocols family (INET) is configured. > # The `fddi' device provides generic code to support FDDI. > # The `arcnet' device provides generic code to support Arcnet. > # The `sppp' device serves a similar role for certain types > > %%% > > I believe handbook is affected too. > > > cheers > > luigi > > > > On Sat, Mar 23, 2002 at 08:50:19PM +0300, Maxim Konovalov wrote: > > > > > > Hello, > > > > > > After this commit 'device ether' is mandatory if ever there is no any > > > ethernet or token-ring devices. > > > > > > | luigi 2002/02/18 14:50:13 PST > > > | > > > | Modified files: > > > |sys/net if.c > > > | Log: > > > | When the local link address is changed, send out gratuitous ARPs > > > | to notify other nodes about the address change. Otherwise, they > > > | might try and keep using the old address until their arp table > > > | entry times out and the address is refreshed. > > > | > > > | Maybe this ought to be done for INET6 addresses as well but i have > > > | no idea how to do it. It should be pretty straightforward though. > > > | > > > | MFC-after: 10 days > > > | > > > | Revision ChangesPath > > > | 1.128 +11 -0 src/sys/net/if.c > > > > > > -- > > > Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer > > > phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED] > > > > > > > To Unsubscribe: send mail to [EMAIL PROTECTED] > > with "unsubscribe freebsd-current" in the body of the message > > > > > > -- > Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer > phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED] > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: is 'device ether' mandatory now?
Hello Luigi, On 05:20-0800, Mar 24, 2002, Luigi Rizzo wrote: > Do you have a suggestion for an #ifdef /#endif to > remove the problem you mention ? Frankly speaking, I have no solution atm. But IMHO we should fix LINT and warn our -stable users at least. Something like that: Index: sys/i386/conf/LINT === RCS file: /home/ncvs/src/sys/i386/conf/Attic/LINT,v retrieving revision 1.749.2.106 diff -u -r1.749.2.106 LINT --- sys/i386/conf/LINT 2002/03/11 01:23:05 1.749.2.106 +++ sys/i386/conf/LINT 2002/03/26 08:06:56 @@ -468,8 +468,8 @@ # Network interfaces: # The `loop' pseudo-device is MANDATORY when networking is enabled. # The `ether' pseudo-device provides generic code to handle -# Ethernets; it is MANDATORY when a Ethernet device driver is -# configured or token-ring is enabled. +# Ethernets; it is MANDATORY when the Internet communication +# protocols family (INET) is configured. # The 'fddi' pseudo-device provides generic code to support FDDI. # The `arcnet' pseudo-device provides generic code to support Arcnet. # The `sppp' pseudo-device serves a similar role for certain types Index: NOTES === RCS file: /home/ncvs/src/sys/i386/conf/NOTES,v retrieving revision 1.1011 diff -u -r1.1011 NOTES --- NOTES 2002/03/23 18:39:54 1.1011 +++ NOTES 2002/03/26 08:08:48 @@ -521,8 +521,8 @@ # Network interfaces: # The `loop' device is MANDATORY when networking is enabled. # The `ether' device provides generic code to handle -# Ethernets; it is MANDATORY when a Ethernet device driver is -# configured or token-ring is enabled. +# Ethernets; it is MANDATORY when the Internet communication +# protocols family (INET) is configured. # The `fddi' device provides generic code to support FDDI. # The `arcnet' device provides generic code to support Arcnet. # The `sppp' device serves a similar role for certain types %%% I believe handbook is affected too. > cheers > luigi > > On Sat, Mar 23, 2002 at 08:50:19PM +0300, Maxim Konovalov wrote: > > > > Hello, > > > > After this commit 'device ether' is mandatory if ever there is no any > > ethernet or token-ring devices. > > > > | luigi 2002/02/18 14:50:13 PST > > | > > | Modified files: > > |sys/net if.c > > | Log: > > | When the local link address is changed, send out gratuitous ARPs > > | to notify other nodes about the address change. Otherwise, they > > | might try and keep using the old address until their arp table > > | entry times out and the address is refreshed. > > | > > | Maybe this ought to be done for INET6 addresses as well but i have > > | no idea how to do it. It should be pretty straightforward though. > > | > > | MFC-after: 10 days > > | > > | Revision ChangesPath > > | 1.128 +11 -0 src/sys/net/if.c > > > > -- > > Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer > > phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED] > > > > To Unsubscribe: send mail to [EMAIL PROTECTED] > with "unsubscribe freebsd-current" in the body of the message > > -- Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED] To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: is 'device ether' mandatory now?
Do you have a suggestion for an #ifdef /#endif to remove the problem you mention ? cheers luigi On Sat, Mar 23, 2002 at 08:50:19PM +0300, Maxim Konovalov wrote: > > Hello, > > After this commit 'device ether' is mandatory if ever there is no any > ethernet or token-ring devices. > > | luigi 2002/02/18 14:50:13 PST > | > | Modified files: > |sys/net if.c > | Log: > | When the local link address is changed, send out gratuitous ARPs > | to notify other nodes about the address change. Otherwise, they > | might try and keep using the old address until their arp table > | entry times out and the address is refreshed. > | > | Maybe this ought to be done for INET6 addresses as well but i have > | no idea how to do it. It should be pretty straightforward though. > | > | MFC-after: 10 days > | > | Revision ChangesPath > | 1.128 +11 -0 src/sys/net/if.c > > -- > Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer > phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED] > To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
Re: is 'device ether' mandatory now?
On Sat, Mar 23, 2002 at 08:50:19PM +0300, Maxim Konovalov wrote:
>
> Hello,
>
> After this commit 'device ether' is mandatory if ever there is no any
> ethernet or token-ring devices.
The same problem in STABLE...
from revision 1.85.2.15 of net/if.c:
#ifdef INET
/*
* Also send gratuitous ARPs to notify other nodes about
* the address change.
*/
TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) {
if (ifa->ifa_addr != NULL &&
ifa->ifa_addr->sa_family == AF_INET)
arp_ifinit((struct arpcom *)ifp, ifa);
}
#endif
arp_ifinit defined in netinet/if_ether.c
This makes 'device ether' mandatory for 'options INET',
so kernel with 'options INET', but without 'device ether'
failed to built:
sh ../../conf/newvers.sh DIALUP
cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions
-ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter
-D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 vers.c
linking kernel
if.o: In function `if_setlladdr':
if.o(.text+0x1ac8): undefined reference to `arp_ifinit'
*** Error code 1
Stop in /usr/src/sys/compile/DIALUP.
bash-2.05# uname -a
FreeBSD core.zp.ua 4.5-STABLE FreeBSD 4.5-STABLE #2: Thu Mar 14 20:31:11 EET 2002
[EMAIL PROTECTED]:/usr/obj/usr/src/sys/core i386
(yes, my computer@home doesn't have any arp-capable devices,
and connects with Internet via dialup)
>
> | luigi 2002/02/18 14:50:13 PST
> |
> | Modified files:
> |sys/net if.c
> | Log:
> | When the local link address is changed, send out gratuitous ARPs
> | to notify other nodes about the address change. Otherwise, they
> | might try and keep using the old address until their arp table
> | entry times out and the address is refreshed.
> |
> | Maybe this ought to be done for INET6 addresses as well but i have
> | no idea how to do it. It should be pretty straightforward though.
> |
> | MFC-after: 10 days
> |
> | Revision ChangesPath
> | 1.128 +11 -0 src/sys/net/if.c
>
> --
> Maxim Konovalov, MAcomnet, Internet-Intranet Dept., system engineer
> phone: +7 (095) 796-9079, mailto:[EMAIL PROTECTED]
>
>
> To Unsubscribe: send mail to [EMAIL PROTECTED]
> with "unsubscribe freebsd-current" in the body of the message
--
With best wishes
Oleg V. Nauman NO37-RIPE
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
