Re: kqueue for KBD.

2014-02-27 Thread Hans Petter Selasky
On 02/27/14 11:59, Kohji Okuno wrote: + sc = kbd->kb_dev->si_drv1; + knlist_clear(&sc->gkb_rsel.si_note, 0); + knlist_destroy(&sc->gkb_rsel.si_note); + free(kbd->kb_dev->si_drv1, M_DEVBUF); destroy_dev(kbd->kb_dev); Hi, You should put the "knlist_destroy()" af

Re: kqueue for KBD.

2014-02-27 Thread Kohji Okuno
Hi John-Mark, Thank you for your comment. I added knote_clear() and knote_destroy() in kbd_detach(). I attached patch, again. But, maybe this patch can not resolve all cases you pointed. Regards, Kohji Okuno > Kohji Okuno wrote this message on Thu, Feb 27, 2014 at 14:24 +0900: >> I tried to add

Re: kqueue for KBD.

2014-02-26 Thread John-Mark Gurney
Kohji Okuno wrote this message on Thu, Feb 27, 2014 at 14:24 +0900: > I tried to add kqueue I/F to kbd.c. I attached patch. > What do you think about my patch? So, knlist_destroy is missing in this patch too.. It also needs some style(9) loving in that some blank lines are missing and there are s